Re: [PATCH v4 0/6] binfmt_elf: Support segments with 0 filesz and misaligned starts

2023-09-29 Thread Kees Cook
On Fri, Sep 29, 2023 at 01:33:50PM +0200, Sebastian Ott wrote: > Hello Kees, > > On Thu, 28 Sep 2023, Kees Cook wrote: > > This is the continuation of the work Eric started for handling > > "p_memsz > p_filesz" in arbitrary segments (rather than just the last, > > BSS, segment). I've added the sug

Re: [PATCH v4 0/6] binfmt_elf: Support segments with 0 filesz and misaligned starts

2023-09-29 Thread Kees Cook
On Fri, Sep 29, 2023 at 12:58:18PM +0100, Pedro Falcato wrote: > So on that end, you can take my > > Tested-by: Pedro Falcato Thanks! -- Kees Cook

Re: [PATCH v4 0/6] binfmt_elf: Support segments with 0 filesz and misaligned starts

2023-09-29 Thread Eric W. Biederman
Sebastian Ott writes: > Hello Kees, > > On Thu, 28 Sep 2023, Kees Cook wrote: >> This is the continuation of the work Eric started for handling >> "p_memsz > p_filesz" in arbitrary segments (rather than just the last, >> BSS, segment). I've added the suggested changes: >> >> - drop unused "elf_bs

Re: [PATCH v4 0/6] binfmt_elf: Support segments with 0 filesz and misaligned starts

2023-09-29 Thread Eric W. Biederman
Pedro Falcato writes: > On Fri, Sep 29, 2023 at 4:24 AM Kees Cook wrote: >> >> Hi, >> >> This is the continuation of the work Eric started for handling >> "p_memsz > p_filesz" in arbitrary segments (rather than just the last, >> BSS, segment). I've added the suggested changes: >> >> - drop unus

Re: [PATCH v4 0/6] binfmt_elf: Support segments with 0 filesz and misaligned starts

2023-09-29 Thread Pedro Falcato
On Fri, Sep 29, 2023 at 4:24 AM Kees Cook wrote: > > Hi, > > This is the continuation of the work Eric started for handling > "p_memsz > p_filesz" in arbitrary segments (rather than just the last, > BSS, segment). I've added the suggested changes: > > - drop unused "elf_bss" variable > - refacto

Re: [PATCH v4 0/6] binfmt_elf: Support segments with 0 filesz and misaligned starts

2023-09-29 Thread Sebastian Ott
Hello Kees, On Thu, 28 Sep 2023, Kees Cook wrote: This is the continuation of the work Eric started for handling "p_memsz > p_filesz" in arbitrary segments (rather than just the last, BSS, segment). I've added the suggested changes: - drop unused "elf_bss" variable - refactor load_elf_interp()

[PATCH v4 0/6] binfmt_elf: Support segments with 0 filesz and misaligned starts

2023-09-28 Thread Kees Cook
Hi, This is the continuation of the work Eric started for handling "p_memsz > p_filesz" in arbitrary segments (rather than just the last, BSS, segment). I've added the suggested changes: - drop unused "elf_bss" variable - refactor load_elf_interp() to use elf_load() - refactor load_elf_library