Re: [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *_pkg*

2024-07-07 Thread Zhang, Rui
Hi, Peter, On Fri, 2024-07-05 at 11:24 +0200, Peter Zijlstra wrote: > On Fri, Jul 05, 2024 at 02:18:30AM +, Zhang, Rui wrote: > > > > > > I have a doubt about this, won't the future Intel multi-die > > > > > systems > > > > > have die-scope for the RAPL PMU like Casecadelake-AP? > > > > > >

Re: [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *_pkg*

2024-07-05 Thread Peter Zijlstra
On Fri, Jul 05, 2024 at 02:18:30AM +, Zhang, Rui wrote: > > > > I have a doubt about this, won't the future Intel multi-die > > > > systems > > > > have die-scope for the RAPL PMU like Casecadelake-AP? > > > > > > For future multi-die systems that I know, the RAPL is still package > > > scop

Re: [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *_pkg*

2024-07-04 Thread Zhang, Rui
On Wed, 2024-07-03 at 12:01 +0530, Dhananjay Ugwekar wrote: > Hi Rui, > > On 7/3/2024 9:37 AM, Zhang, Rui wrote: > > On Tue, 2024-07-02 at 15:50 +0530, Dhananjay Ugwekar wrote: > > > > > > > > > > > For Intel products, we have > > > > 1. Casecadelake-AP which has multi-die per package and has pe

Re: [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *_pkg*

2024-07-02 Thread Dhananjay Ugwekar
Hi Rui, On 7/3/2024 9:37 AM, Zhang, Rui wrote: > On Tue, 2024-07-02 at 15:50 +0530, Dhananjay Ugwekar wrote: >> >>> >>> For Intel products, we have >>> 1. Casecadelake-AP which has multi-die per package and has per-die >>> RAPL >>> MSRs >>> 2. all other platforms which has single-die per package,

Re: [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *_pkg*

2024-07-02 Thread Zhang, Rui
On Tue, 2024-07-02 at 15:50 +0530, Dhananjay Ugwekar wrote: > > > > > For Intel products, we have > > 1. Casecadelake-AP which has multi-die per package and has per-die > > RAPL > > MSRs > > 2. all other platforms which has single-die per package, so its > > RAPL > > MSRs can be considered as eit

Re: [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *_pkg*

2024-07-02 Thread Dhananjay Ugwekar
Hello Rui, On 7/2/2024 7:55 AM, Zhang, Rui wrote: > On Mon, 2024-07-01 at 15:08 +0200, Peter Zijlstra wrote: >> On Mon, Jun 24, 2024 at 05:59:05AM +, Dhananjay Ugwekar wrote: >>> Prep for addition of power_per_core PMU to handle core scope energy >>> consumption for AMD CPUs. >>> >>> Replace t

Re: [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *_pkg*

2024-07-01 Thread Zhang, Rui
On Mon, 2024-07-01 at 15:08 +0200, Peter Zijlstra wrote: > On Mon, Jun 24, 2024 at 05:59:05AM +, Dhananjay Ugwekar wrote: > > Prep for addition of power_per_core PMU to handle core scope energy > > consumption for AMD CPUs. > > > > Replace the generic names with *_pkg*, to differentiate betwee

Re: [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *_pkg*

2024-07-01 Thread Peter Zijlstra
On Mon, Jun 24, 2024 at 05:59:05AM +, Dhananjay Ugwekar wrote: > Prep for addition of power_per_core PMU to handle core scope energy > consumption for AMD CPUs. > > Replace the generic names with *_pkg*, to differentiate between the > scopes of the two different PMUs and their variables. But

[PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *_pkg*

2024-06-23 Thread Dhananjay Ugwekar
Prep for addition of power_per_core PMU to handle core scope energy consumption for AMD CPUs. Replace the generic names with *_pkg*, to differentiate between the scopes of the two different PMUs and their variables. No functional change. Signed-off-by: Dhananjay Ugwekar --- arch/x86/events/rap