Re: [PATCH v3] net: dsa: lan9303: use ethtool_puts() for lan9303_get_strings()

2024-04-09 Thread Alexander Lobakin
From: Justin Stitt Date: Mon, 08 Apr 2024 21:01:57 + > This pattern of strncpy with some pointer arithmetic setting fixed-sized > intervals with string literal data is a bit weird so let's use > ethtool_puts() as this has more obvious behavior and is less-error > prone. > > Nicely, we also g

Re: [PATCH v3] net: dsa: lan9303: use ethtool_puts() for lan9303_get_strings()

2024-04-08 Thread Kees Cook
On Mon, Apr 08, 2024 at 09:01:57PM +, Justin Stitt wrote: > This pattern of strncpy with some pointer arithmetic setting fixed-sized > intervals with string literal data is a bit weird so let's use > ethtool_puts() as this has more obvious behavior and is less-error > prone. > > Nicely, we als

[PATCH v3] net: dsa: lan9303: use ethtool_puts() for lan9303_get_strings()

2024-04-08 Thread Justin Stitt
This pattern of strncpy with some pointer arithmetic setting fixed-sized intervals with string literal data is a bit weird so let's use ethtool_puts() as this has more obvious behavior and is less-error prone. Nicely, we also get to drop a usage of the now deprecated strncpy() [1]. Link: https:/