On Mon, Dec 18, 2023 at 09:05:56AM -0800, Tanzir Hasan wrote:
> > While REPEAT_BYTE has a manageable number of users, upper_* and
> > lower_* have significantly more; I worry about moving those causing
> > regressions. We can move them, but such changes would need
> > significantly more soak time
On Mon, Dec 18, 2023 at 08:57:59AM -0800, Nick Desaulniers wrote:
> On Fri, Dec 15, 2023 at 11:09 AM Andy Shevchenko
> wrote:
> > On Fri, Dec 15, 2023 at 8:31 PM Tanzir Hasan wrote:
> > > On Fri, Dec 15, 2023 at 8:04 AM Andy Shevchenko wrote:
> > >> On Thu, Dec 14, 2023 at 09:06:12PM +, tanz
> While REPEAT_BYTE has a manageable number of users, upper_* and
> lower_* have significantly more; I worry about moving those causing
> regressions. We can move them, but such changes would need
> significantly more soak time than this series IMO. Tanzir is also
> working on statistical analysi
On Fri, Dec 15, 2023 at 11:09 AM Andy Shevchenko
wrote:
>
> On Fri, Dec 15, 2023 at 8:31 PM Tanzir Hasan wrote:
> > On Fri, Dec 15, 2023 at 8:04 AM Andy Shevchenko wrote:
> >> On Thu, Dec 14, 2023 at 09:06:12PM +, tanz...@google.com wrote:
>
> ...
>
> >> > +#include
> >>
> >> I highly disco
On Fri, Dec 15, 2023 at 8:31 PM Tanzir Hasan wrote:
> On Fri, Dec 15, 2023 at 8:04 AM Andy Shevchenko wrote:
>> On Thu, Dec 14, 2023 at 09:06:12PM +, tanz...@google.com wrote:
...
>> > +#include
>>
>> I highly discourage from doing that. Instead, split what is needed to
>> the separate (ne
On Thu, Dec 14, 2023 at 09:06:12PM +, tanz...@google.com wrote:
> This patch includes linux/kernel.h in asm/word-at-a-time.h for the
> sh architecture. WORD_AT_A_TIME_CONSTANTS depends on kernel.h.
> Making this implicit dependancy explicit allows for later improvements
> in the lib/string.c in
On Thu, Dec 14, 2023 at 1:37 PM Kees Cook wrote:
>
> Also, please double-check your email configs: your full name is missing
> from your emails (it's just "tanz...@google.com"):
> https://lore.kernel.org/lkml/20231214-libstringheader-v2-1-0f195dcff...@google.com/
This is the issue related to use
On Thu, Dec 14, 2023 at 09:06:12PM +, tanz...@google.com wrote:
> This patch includes linux/kernel.h in asm/word-at-a-time.h for the
> sh architecture. WORD_AT_A_TIME_CONSTANTS depends on kernel.h.
> Making this implicit dependancy explicit allows for later improvements
> in the lib/string.c in
This patch includes linux/kernel.h in asm/word-at-a-time.h for the
sh architecture. WORD_AT_A_TIME_CONSTANTS depends on kernel.h.
Making this implicit dependancy explicit allows for later improvements
in the lib/string.c inclusion list.
Suggested-by: Al Viro
---
arch/sh/include/asm/word-at-a-tim
