On Wed, 12 Jun 2024 07:23:40 +
Wei Yang wrote:
> >> >+struct reserve_mem_table {
> >> >+ charname[RESERVE_MEM_NAME_SIZE];
> >> >+ unsigned long start;
> >> >+ unsigned long size;
> >>
> >> phys_addr_t looks more precise?
> >
> >For just the start
On Wed, 12 Jun 2024 07:30:49 +
Wei Yang wrote:
> >+/* Add wildcard region with a lookup name */
> >+static int __init reserved_mem_add(unsigned long start, unsigned long size,
> >+ const char *name)
> >+{
> >+struct reserve_mem_table *map;
> >+
> >+if (!n
On Thu, Jun 06, 2024 at 11:01:44AM -0400, Steven Rostedt wrote:
>From: "Steven Rostedt (Google)"
>
>In order to allow for requesting a memory region that can be used for
>things like pstore on multiple machines where the memory layout is not the
>same, add a new option to the kernel command line c
On Tue, Jun 11, 2024 at 11:12:18AM -0400, Steven Rostedt wrote:
>On Tue, 11 Jun 2024 14:40:29 +
>Wei Yang wrote:
>
>Missed this just before sending out v3 :-p
>
>> >diff --git a/mm/memblock.c b/mm/memblock.c
>> >index d09136e040d3..a8bf0ee9e2b4 100644
>> >--- a/mm/memblock.c
>> >+++ b/mm/membl
On Tue, 11 Jun 2024 11:12:18 -0400
Steven Rostedt wrote:
> > >+ p++;
> > >+ err = reserved_mem_add(start, size, p);
> > >+ if (err) {
> > >+ memblock_phys_free(start, size);
> > >+ return err;
> > >+ }
> > >+
> > >+ p += strlen(p);
> > >+
> > >+ return *p == '\0' ? 0: -EIN
On Tue, 11 Jun 2024 19:30:47 +0300
Mike Rapoport wrote:
> > I don't know if we care what the align is. Zero is valid.
>
> memblock won't like zero align, it should be SMP_CACHE_BYTES at least.
> No point requiring it from user, just update the alignment if the user passed
> zero.
Thanks, will
On Tue, Jun 11, 2024 at 11:12:18AM -0400, Steven Rostedt wrote:
> On Tue, 11 Jun 2024 14:40:29 +
> Wei Yang wrote:
>
> > >+
> > >+ align = memparse(p+1, &p);
> > >+ if (*p != ':')
> > >+ return -EINVAL;
> > >+
> >
> > Make sure command line parameters are valid before doing the a
On Tue, 11 Jun 2024 14:40:29 +
Wei Yang wrote:
Missed this just before sending out v3 :-p
> >diff --git a/mm/memblock.c b/mm/memblock.c
> >index d09136e040d3..a8bf0ee9e2b4 100644
> >--- a/mm/memblock.c
> >+++ b/mm/memblock.c
> >@@ -2244,6 +2244,103 @@ void __init memblock_free_all(void)
> >
On 6/11/24 07:40, Wei Yang wrote:
[ ... ]
+/* Keep a table to reserve named memory */
+#define RESERVE_MEM_MAX_ENTRIES8
+#define RESERVE_MEM_NAME_SIZE 16
^
Suggest to align with previous line.
It _is_ aligned. It just looks una
On Thu, Jun 06, 2024 at 11:01:44AM -0400, Steven Rostedt wrote:
>From: "Steven Rostedt (Google)"
>
>In order to allow for requesting a memory region that can be used for
>things like pstore on multiple machines where the memory layout is not the
>same, add a new option to the kernel command line c
Hi Steve, thanks for the patch! Some suggestions/fixes below, inline.
On 06/06/2024 12:01, Steven Rostedt wrote:
> [...]
> +
> + The format is size:align:label for example, to request
> + 12 megabytes of 4096 alignment for ramoops:
> +
> +
From: "Steven Rostedt (Google)"
In order to allow for requesting a memory region that can be used for
things like pstore on multiple machines where the memory layout is not the
same, add a new option to the kernel command line called "reserve_mem".
The format is: reserve_mem=nn:align:name
Wher
12 matches
Mail list logo
