Re: [PATCH v2 1/1] mseal: update mseal.rst

2024-10-07 Thread Jeff Xu
Hi Theo On Fri, Oct 4, 2024 at 6:04 PM Theo de Raadt wrote: > > Randy Dunlap wrote: > > > On 10/4/24 9:52 AM, Jeff Xu wrote: > > >> above is not a sentence but I don't know how to fix it. > > >> > > > Would below work ? > > > > > > Certain destructive madvise behaviors, specifically MADV_DONTNEE

Re: [PATCH v2 1/1] mseal: update mseal.rst

2024-10-07 Thread Jeff Xu
Hi Theo On Fri, Oct 4, 2024 at 12:11 PM Theo de Raadt wrote: > > Jeff Xu wrote: > > > > > + replacement with a new mapping with new set of attributes, or can > > > > + overwrite the existing mapping with another mapping. > > > > + > > > > + mprotect and pkey_mprotect are blocked because th

Re: [PATCH v2 1/1] mseal: update mseal.rst

2024-10-07 Thread Jeff Xu
Hi Randy On Fri, Oct 4, 2024 at 4:52 PM Randy Dunlap wrote: > > > > On 10/4/24 9:52 AM, Jeff Xu wrote: > >> above is not a sentence but I don't know how to fix it. > >> > > Would below work ? > > > > Certain destructive madvise behaviors, specifically MADV_DONTNEED, > > MADV_FREE, MADV_DONTNEED_L

Re: [PATCH v2 1/1] mseal: update mseal.rst

2024-10-04 Thread Theo de Raadt
Randy Dunlap wrote: > On 10/4/24 9:52 AM, Jeff Xu wrote: > >> above is not a sentence but I don't know how to fix it. > >> > > Would below work ? > > > > Certain destructive madvise behaviors, specifically MADV_DONTNEED, > > MADV_FREE, MADV_DONTNEED_LOCKED, MADV_FREE, MADV_DONTFORK, > > MADV_WIP

Re: [PATCH v2 1/1] mseal: update mseal.rst

2024-10-04 Thread Randy Dunlap
On 10/4/24 9:52 AM, Jeff Xu wrote: >> above is not a sentence but I don't know how to fix it. >> > Would below work ? > > Certain destructive madvise behaviors, specifically MADV_DONTNEED, > MADV_FREE, MADV_DONTNEED_LOCKED, MADV_FREE, MADV_DONTFORK, > MADV_WIPEONFORK, can pose risks when applie

Re: [PATCH v2 1/1] mseal: update mseal.rst

2024-10-04 Thread Theo de Raadt
Jeff Xu wrote: > > > + replacement with a new mapping with new set of attributes, or can > > > + overwrite the existing mapping with another mapping. > > > + > > > + mprotect and pkey_mprotect are blocked because they changes the > > > + protection bits (RWX) of the mapping. > > > + > > >

Re: [PATCH v2 1/1] mseal: update mseal.rst

2024-10-04 Thread Jeff Xu
Hi Randy On Thu, Oct 3, 2024 at 3:54 PM Randy Dunlap wrote: > > Hi Jeff, > > Sorry for the delay. > Thanks for your v2 updates. > I appreciate you spending time proofreading the mseal.rst. > > On 9/30/24 5:26 PM, jef...@chromium.org wrote: > > From: Jeff Xu > > > > Update doc after in-loop chan

Re: [PATCH v2 1/1] mseal: update mseal.rst

2024-10-03 Thread Randy Dunlap
Hi Jeff, Sorry for the delay. Thanks for your v2 updates. On 9/30/24 5:26 PM, jef...@chromium.org wrote: > From: Jeff Xu > > Update doc after in-loop change: mprotect/madvise can have > partially updated and munmap is atomic. > > Fix indentation and clarify some sections to improve readabilit

[PATCH v2 1/1] mseal: update mseal.rst

2024-09-30 Thread jeffxu
From: Jeff Xu Update doc after in-loop change: mprotect/madvise can have partially updated and munmap is atomic. Fix indentation and clarify some sections to improve readability. Signed-off-by: Jeff Xu Fixes: df2a7df9a9aa ("mm/munmap: replace can_modify_mm with can_modify_vma") Fixes: 4a2dd02b