Re: [PATCH v2 00/10] lib/string_choices: Add new helpers

2025-03-04 Thread Kuninori Morimoto
Hi Kees, Andy Thank you for your feedbacks > That said, I would expect the series out of 3/4 patches > 1) add str_in_out() and/or str_input_output(); > 2) use it in gpio-crystalcove.c > 3) use it in gpio-wcove.c > > This can be easily combined into an immutable tag/branch and pulled by > the af

Re: [PATCH v2 00/10] lib/string_choices: Add new helpers

2025-03-04 Thread Kees Cook
On Tue, Mar 04, 2025 at 02:12:41AM +, Kuninori Morimoto wrote: > I would like to use string_choices helper to cleanup the code, but it is > missing some of well used string pair in kernel. This patch-set adds it. > > Step1 > Add new helpers (This patch-set) > Step2 > Each driver/fr

Re: [PATCH v2 00/10] lib/string_choices: Add new helpers

2025-03-03 Thread Andy Shevchenko
On Tue, Mar 4, 2025 at 8:53 AM Kuninori Morimoto wrote: ... > > > passed / failed > > > succeed/ failed > > > success/ failed > > > successful / failed > > > succeeded / failed > > > worked / failed > > > > It looks like something

Re: [PATCH v2 00/10] lib/string_choices: Add new helpers

2025-03-03 Thread Kuninori Morimoto
Hi Andy Thank you for the reply > First of all, please rebase your series against the top of the Kees' > branch: Also use --base when preparing the patch series. > > When you do that, you will note that the helpers now are ordered > alphabetically (which your series doesn't follow). So, you wi

Re: [PATCH v2 00/10] lib/string_choices: Add new helpers

2025-03-03 Thread Andy Shevchenko
On Tue, Mar 4, 2025 at 4:12 AM Kuninori Morimoto wrote: > > > Hi Kees, Andy > > This is v2 patch-set of "add new helpers". First of all, please rebase your series against the top of the Kees' branch: https://web.git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/hardening. Al

[PATCH v2 00/10] lib/string_choices: Add new helpers

2025-03-03 Thread Kuninori Morimoto
Hi Kees, Andy This is v2 patch-set of "add new helpers". I would like to use string_choices helper to cleanup the code, but it is missing some of well used string pair in kernel. This patch-set adds it. Step1 Add new helpers (This patch-set) Step2 Each driver/framework use new h