Re: [PATCH v2] net: mdio-gpio: replace deprecated strncpy with strscpy

2023-12-11 Thread Justin Stitt
On Thu, Dec 7, 2023 at 2:57 PM Russell King (Oracle) wrote: > > On Thu, Dec 07, 2023 at 09:54:31PM +, Justin Stitt wrote: > > We expect new_bus->id to be NUL-terminated but not NUL-padded based on > > its prior assignment through snprintf: > > | snprintf(new_bus->id, MII_BUS_ID_SIZE, "gp

Re: [PATCH v2] net: mdio-gpio: replace deprecated strncpy with strscpy

2023-12-07 Thread Russell King (Oracle)
On Thu, Dec 07, 2023 at 09:54:31PM +, Justin Stitt wrote: > We expect new_bus->id to be NUL-terminated but not NUL-padded based on > its prior assignment through snprintf: > | snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id); > > We can also use sizeof() instead of a length macr

[PATCH v2] net: mdio-gpio: replace deprecated strncpy with strscpy

2023-12-07 Thread Justin Stitt
strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. We expect new_bus->id to be NUL-terminated but not NUL-padded based on its prior assignment through snprintf: | snprintf(new_bus->id, MII_B