Re: [PATCH v1 0/2] mseal: fixing madvise for file-backed mapping and PROT_NONE

2024-10-17 Thread Lorenzo Stoakes
NACK. On Thu, Oct 17, 2024 at 12:51:03AM +, jef...@chromium.org wrote: > From: Jeff Xu > > Two fixes for madvise(MADV_DONTNEED) when sealed. > > For PROT_NONE mappings, the previous blocking of > madvise(MADV_DONTNEED) is unnecessary. As PROT_NONE already prohibits > memory access, madvise(MA

[PATCH v1 0/2] mseal: fixing madvise for file-backed mapping and PROT_NONE

2024-10-16 Thread jeffxu
From: Jeff Xu Two fixes for madvise(MADV_DONTNEED) when sealed. For PROT_NONE mappings, the previous blocking of madvise(MADV_DONTNEED) is unnecessary. As PROT_NONE already prohibits memory access, madvise(MADV_DONTNEED) should be allowed to proceed in order to free the page. For file-backed, p