Re: [PATCH v1] mseal: move can_do_mseal to mseal.c

2024-12-11 Thread Lorenzo Stoakes
On Tue, Dec 10, 2024 at 06:38:49PM -0800, Jeff Xu wrote: > Hi Lorenzo, > > Regarding your proposal of moving mseal.c to vma.c for unit testing. > > On Fri, Dec 6, 2024 at 9:04 AM Lorenzo Stoakes > wrote: > > > > > > > > An aside - I actually think we need to move the bulk of this code to > > > > m

Re: [PATCH v1] mseal: move can_do_mseal to mseal.c

2024-12-10 Thread Jeff Xu
Hi Lorenzo, Regarding your proposal of moving mseal.c to vma.c for unit testing. On Fri, Dec 6, 2024 at 9:04 AM Lorenzo Stoakes wrote: > > > > > > An aside - I actually think we need to move the bulk of this code to > > > mm/vma.c - it makes absolutely no sense to keep the internals in this > >

Re: [PATCH v1] mseal: move can_do_mseal to mseal.c

2024-12-06 Thread Lorenzo Stoakes
On Fri, Dec 06, 2024 at 08:17:40AM -0800, Jeff Xu wrote: > On Fri, Dec 6, 2024 at 1:13 AM Lorenzo Stoakes > wrote: > > > > On Thu, Dec 05, 2024 at 11:25:43PM -0500, Liam R. Howlett wrote: > > > * jef...@chromium.org [241205 20:39]: > > > > From: Jeff Xu > > > > > > > > No code logic change. > >

Re: [PATCH v1] mseal: move can_do_mseal to mseal.c

2024-12-06 Thread Jeff Xu
On Fri, Dec 6, 2024 at 1:13 AM Lorenzo Stoakes wrote: > > On Thu, Dec 05, 2024 at 11:25:43PM -0500, Liam R. Howlett wrote: > > * jef...@chromium.org [241205 20:39]: > > > From: Jeff Xu > > > > > > No code logic change. > > > > > > can_do_mseal is called exclusively by mseal.c, > > > and mseal.c

Re: [PATCH v1] mseal: move can_do_mseal to mseal.c

2024-12-06 Thread Jeff Xu
On Thu, Dec 5, 2024 at 8:25 PM Liam R. Howlett wrote: > > * jef...@chromium.org [241205 20:39]: > > From: Jeff Xu > > > > No code logic change. > > > > can_do_mseal is called exclusively by mseal.c, > > and mseal.c is compiled only when CONFIG_64BIT flag is > > set in makefile. Therefore, it is

Re: [PATCH v1] mseal: move can_do_mseal to mseal.c

2024-12-06 Thread Lorenzo Stoakes
On Thu, Dec 05, 2024 at 11:25:43PM -0500, Liam R. Howlett wrote: > * jef...@chromium.org [241205 20:39]: > > From: Jeff Xu > > > > No code logic change. > > > > can_do_mseal is called exclusively by mseal.c, > > and mseal.c is compiled only when CONFIG_64BIT flag is > > set in makefile. Therefore

Re: [PATCH v1] mseal: move can_do_mseal to mseal.c

2024-12-05 Thread Liam R. Howlett
* jef...@chromium.org [241205 20:39]: > From: Jeff Xu > > No code logic change. > > can_do_mseal is called exclusively by mseal.c, > and mseal.c is compiled only when CONFIG_64BIT flag is > set in makefile. Therefore, it is unnecessary to have > 32 bit stub function in the header file. There i

[PATCH v1] mseal: move can_do_mseal to mseal.c

2024-12-05 Thread jeffxu
From: Jeff Xu No code logic change. can_do_mseal is called exclusively by mseal.c, and mseal.c is compiled only when CONFIG_64BIT flag is set in makefile. Therefore, it is unnecessary to have 32 bit stub function in the header file. Signed-off-by: Jeff Xu --- mm/internal.h | 16 --