Re: [PATCH net-next 1/2] gve: Avoid unnecessary use of comma operator

2024-05-03 Thread Dan Carpenter
On Fri, May 03, 2024 at 09:31:26PM +0100, Simon Horman wrote: > Although it does not seem to have any untoward side-effects, > the use of ';' to separate to assignments seems more appropriate than ','. > Huh. Interesting. I wrote a check for that in Smatch. The only place where it would matter

[PATCH net-next 1/2] gve: Avoid unnecessary use of comma operator

2024-05-03 Thread Simon Horman
Although it does not seem to have any untoward side-effects, the use of ';' to separate to assignments seems more appropriate than ','. Flagged by clang-18 -Wcomma No functional change intended. Compile tested only. Signed-off-by: Simon Horman --- drivers/net/ethernet/google/gve/gve_adminq.c |