Re: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices

2023-10-25 Thread Borislav Petkov
Hi, On Wed, Oct 25, 2023 at 02:09:37PM +, Jeshua Smith wrote: <... snip a very detailed and good explanation... > > Writing 128 nor-flash pages would then take 120us * 128 = 15ms > typical, or 1800us * 128 = 230.4ms max. This is perfectly suitable to be in the commit message - it explains in

RE: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices

2023-10-25 Thread Jeshua Smith
Hi Boris, You asked several questions, and it's not clear to me if you are suggesting the answers be sent as email reply, or if you're asking for the answers to be added to the commit message. Below are my email replies to those questions. Borislav Petkov wrote: > When I see "may" in commit mes

Re: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices

2023-10-24 Thread Rafael J. Wysocki
On Tue, Oct 24, 2023 at 5:27 PM Tony Luck wrote: > > On Wed, Jul 12, 2023 at 10:34:48PM +, Jeshua Smith wrote: > > Slow devices such as flash may not meet the default 1ms timeout value, > > so use the ERST max execution time value that they provide as the > > timeout if it is larger. > > > > S

Re: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices

2023-10-24 Thread Tony Luck
On Wed, Jul 12, 2023 at 10:34:48PM +, Jeshua Smith wrote: > Slow devices such as flash may not meet the default 1ms timeout value, > so use the ERST max execution time value that they provide as the > timeout if it is larger. > > Signed-off-by: Jeshua Smith > +/* ERST Exec max timings */ > +

Re: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices

2023-10-24 Thread Borislav Petkov
On Tue, Oct 24, 2023 at 04:32:48PM +0200, Rafael J. Wysocki wrote: > So there are 3 designated reviewers for APEI: Tony Luck, Borislav > Petkov and James Morse. I need an ACK or Reviewed-by from one of > them, so I can proceed with an APEI patch. Here's what I see: cat /tmp/patch | ./scripts/get

Re: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices

2023-10-24 Thread Rafael J. Wysocki
...@alien8.de > Cc: linux-a...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-hardening@vger.kernel.org; linux-te...@vger.kernel.org; Thierry Reding > ; Jonathan Hunter > Subject: RE: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices > > Resending due to lack of res

RE: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices

2023-10-23 Thread Jeshua Smith
; james.mo...@arm.com; b...@alien8.de Cc: linux-a...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-hardening@vger.kernel.org; linux-te...@vger.kernel.org; Thierry Reding ; Jonathan Hunter Subject: RE: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices Resending due to lack of responses

RE: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices

2023-10-02 Thread Jeshua Smith
-ker...@vger.kernel.org; linux-hardening@vger.kernel.org; linux-te...@vger.kernel.org; Thierry Reding ; Jonathan Hunter Subject: RE: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices Any further questions? Anything else holding up this patch? -Original Message- From: Jeshua Smith