Re: [PATCH 2/2] wifi: cfg80211: simplify cfg80211_mlme_register_mgmt()

2024-12-30 Thread kernel test robot
Hello, kernel test robot noticed "BUG:sleeping_function_called_from_invalid_context_at_include/linux/sched/mm.h" on: commit: f3ec4051049a8cc013993b615303b283770c6482 ("[PATCH 2/2] wifi: cfg80211: simplify cfg80211_mlme_register_mgmt()") url: https://github.com/intel-l

Re: [PATCH 2/2] wifi: cfg80211: simplify cfg80211_mlme_register_mgmt()

2024-12-12 Thread Johannes Berg
On Tue, 2024-12-10 at 17:39 +0300, Dmitry Antipov wrote: > Simplify 'cfg80211_mlme_register_mgmt()' to allocate an instance of > 'struct cfg80211_mgmt_registration' only if the latter is really > needed  This part is very much broken, and I don't see that it's actually useful to add a new "goto" j

[PATCH 2/2] wifi: cfg80211: simplify cfg80211_mlme_register_mgmt()

2024-12-10 Thread Dmitry Antipov
Simplify 'cfg80211_mlme_register_mgmt()' to allocate an instance of 'struct cfg80211_mgmt_registration' only if the latter is really needed (i.e. when the list of registrations should be updated) and prefer 'kmalloc()' over 'kzalloc()' since all of the members are explicitly initialized. Fixes: 9d