Re: [PATCH] x86/tdx: refactor deprecated strncpy

2023-09-29 Thread Kees Cook
On Fri, Sep 29, 2023 at 11:14:14PM +0200, Ingo Molnar wrote: > > * Kees Cook wrote: > > > On Mon, 11 Sep 2023 18:27:25 +, Justin Stitt wrote: > > > `strncpy` is deprecated and we should prefer more robust string apis. > > > > > > In this case, `message.str` is not expected to be NUL-termina

Re: [PATCH] x86/tdx: refactor deprecated strncpy

2023-09-29 Thread Kees Cook
On Fri, Sep 29, 2023 at 02:27:39PM -0700, Dave Hansen wrote: > On 9/29/23 11:33, Kees Cook wrote: > > On Mon, 11 Sep 2023 18:27:25 +, Justin Stitt wrote: > >> `strncpy` is deprecated and we should prefer more robust string apis. > >> > >> In this case, `message.str` is not expected to be NUL-te

Re: [PATCH] x86/tdx: refactor deprecated strncpy

2023-09-29 Thread Dave Hansen
On 9/29/23 11:33, Kees Cook wrote: > On Mon, 11 Sep 2023 18:27:25 +, Justin Stitt wrote: >> `strncpy` is deprecated and we should prefer more robust string apis. >> >> In this case, `message.str` is not expected to be NUL-terminated as it >> is simply a buffer of characters residing in a union

Re: [PATCH] x86/tdx: refactor deprecated strncpy

2023-09-29 Thread Ingo Molnar
* Kees Cook wrote: > On Mon, 11 Sep 2023 18:27:25 +, Justin Stitt wrote: > > `strncpy` is deprecated and we should prefer more robust string apis. > > > > In this case, `message.str` is not expected to be NUL-terminated as it > > is simply a buffer of characters residing in a union which a

Re: [PATCH] x86/tdx: refactor deprecated strncpy

2023-09-29 Thread Kees Cook
On Mon, 11 Sep 2023 18:27:25 +, Justin Stitt wrote: > `strncpy` is deprecated and we should prefer more robust string apis. > > In this case, `message.str` is not expected to be NUL-terminated as it > is simply a buffer of characters residing in a union which allows for > named fields represen