Re: [PATCH] wireguard: noise: Add __nonstring annotations for unterminated strings

2025-03-11 Thread Kees Cook
On Tue, Mar 11, 2025 at 11:19:27AM +0100, Jakub Kicinski wrote: > On Mon, 10 Mar 2025 15:22:50 -0700 Kees Cook wrote: > > When a character array without a terminating NUL character has a static > > initializer, GCC 15's -Wunterminated-string-initialization will only > > warn if the array lacks the

Re: [PATCH] wireguard: noise: Add __nonstring annotations for unterminated strings

2025-03-11 Thread Jakub Kicinski
On Mon, 10 Mar 2025 15:22:50 -0700 Kees Cook wrote: > When a character array without a terminating NUL character has a static > initializer, GCC 15's -Wunterminated-string-initialization will only > warn if the array lacks the "nonstring" attribute[1]. Mark the arrays > with __nonstring to and corr

[PATCH] wireguard: noise: Add __nonstring annotations for unterminated strings

2025-03-10 Thread Kees Cook
When a character array without a terminating NUL character has a static initializer, GCC 15's -Wunterminated-string-initialization will only warn if the array lacks the "nonstring" attribute[1]. Mark the arrays with __nonstring to and correctly identify the char array as "not a C string" and thereb