Re: [PATCH] qlcnic: replace deprecated strncpy with strscpy

2023-12-01 Thread Kees Cook
On Thu, Nov 30, 2023 at 10:43:12PM -0800, Jakub Kicinski wrote: > On Thu, 30 Nov 2023 14:00:28 -0800 Kees Cook wrote: > > [1/1] qlcnic: replace deprecated strncpy with strscpy > > https://git.kernel.org/kees/c/f8bef1ef8095 > > You asked for changes yourself here, please drop all the networki

Re: [PATCH] qlcnic: replace deprecated strncpy with strscpy

2023-11-30 Thread Jakub Kicinski
On Thu, 30 Nov 2023 14:00:28 -0800 Kees Cook wrote: > [1/1] qlcnic: replace deprecated strncpy with strscpy > https://git.kernel.org/kees/c/f8bef1ef8095 You asked for changes yourself here, please drop all the networking patches you applied today :|

Re: [PATCH] qlcnic: replace deprecated strncpy with strscpy

2023-11-30 Thread Kees Cook
On Thu, 12 Oct 2023 19:44:29 +, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We expect fw_info->fw_file_name to be NUL-terminated based on its use > within

Re: [PATCH] qlcnic: replace deprecated strncpy with strscpy

2023-10-16 Thread Justin Stitt
On Sat, Oct 14, 2023 at 7:47 PM Kees Cook wrote: > > On Thu, Oct 12, 2023 at 07:44:29PM +, Justin Stitt wrote: > > strncpy() is deprecated for use on NUL-terminated destination strings > > [1] and as such we should prefer more robust and less ambiguous string > > interfaces. > > > > We expect

Re: [PATCH] qlcnic: replace deprecated strncpy with strscpy

2023-10-14 Thread Kees Cook
On Thu, Oct 12, 2023 at 07:44:29PM +, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We expect fw_info->fw_file_name to be NUL-terminated based on its use > w

[PATCH] qlcnic: replace deprecated strncpy with strscpy

2023-10-12 Thread Justin Stitt
strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. We expect fw_info->fw_file_name to be NUL-terminated based on its use within _request_firmware_prepare() wherein `name` refers to it: | if