Re: [PATCH] orangefs: cleanup uses of strncpy

2024-04-03 Thread Mike Marshall
Hi... I b4'd this patch (I love b4) and applied it to 6.9.0-rc2 and ran it through xfstests with no regressions, so please add a tested-by for hub...@omnibond.com. Thanks... -Mike Marshall On Mon, Apr 1, 2024 at 4:53 AM Christian Brauner wrote: > > On Fri, 22 Mar 2024 21:41:18 +, Justin St

Re: [PATCH] orangefs: cleanup uses of strncpy

2024-04-01 Thread Christian Brauner
On Fri, 22 Mar 2024 21:41:18 +, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > There is some care taken to ensure these destination buffers are > NUL-terminat

Re: [PATCH] orangefs: cleanup uses of strncpy

2024-03-28 Thread Kees Cook
On Fri, Mar 22, 2024 at 09:41:18PM +, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > There is some care taken to ensure these destination buffers are > NUL-te

[PATCH] orangefs: cleanup uses of strncpy

2024-03-22 Thread Justin Stitt
strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. There is some care taken to ensure these destination buffers are NUL-terminated by bounding the strncpy()'s by ORANGEFS_NAME_MAX - 1 or ORANGEFS_