Re: [PATCH] nvmet-fc: Remove __counted_by from nvmet_fc_tgt_queue.fod[]

2024-06-26 Thread Nathan Chancellor
On Wed, Jun 26, 2024 at 11:19:24AM -0600, Keith Busch wrote: > On Wed, Jun 26, 2024 at 10:06:05AM -0700, Nathan Chancellor wrote: > > Ping? This is still relevant and I don't think this is a compiler bug > > that would justify withholding this change. > > Sorry, I misunderstood the discussion to "

Re: [PATCH] nvmet-fc: Remove __counted_by from nvmet_fc_tgt_queue.fod[]

2024-06-26 Thread Keith Busch
On Wed, Jun 26, 2024 at 10:06:05AM -0700, Nathan Chancellor wrote: > Ping? This is still relevant and I don't think this is a compiler bug > that would justify withholding this change. Sorry, I misunderstood the discussion to "wait" on this. Queued up in nvme-6.10 now.

Re: [PATCH] nvmet-fc: Remove __counted_by from nvmet_fc_tgt_queue.fod[]

2024-06-26 Thread Nathan Chancellor
Ping? This is still relevant and I don't think this is a compiler bug that would justify withholding this change. On Wed, May 29, 2024 at 02:42:40PM -0700, Nathan Chancellor wrote: > Work for __counted_by on generic pointers in structures (not just > flexible array members) has started landing in

Re: [PATCH] nvmet-fc: Remove __counted_by from nvmet_fc_tgt_queue.fod[]

2024-05-30 Thread Nathan Chancellor
Hi Jiri, On Thu, May 30, 2024 at 08:41:18AM +0200, Jiri Slaby wrote: > On 29. 05. 24, 23:42, Nathan Chancellor wrote: > >drivers/nvme/target/fc.c:151:2: error: 'counted_by' should not be > > applied to an array with element of unknown size because 'struct > > nvmet_fc_fcp_iod' is a struct ty

Re: [PATCH] nvmet-fc: Remove __counted_by from nvmet_fc_tgt_queue.fod[]

2024-05-29 Thread Jiri Slaby
On 29. 05. 24, 23:42, Nathan Chancellor wrote: drivers/nvme/target/fc.c:151:2: error: 'counted_by' should not be applied to an array with element of unknown size because 'struct nvmet_fc_fcp_iod' is a struct type with a flexible array member. The same as for mxser_port: struct nvmet_fc_fc

[PATCH] nvmet-fc: Remove __counted_by from nvmet_fc_tgt_queue.fod[]

2024-05-29 Thread Nathan Chancellor
Work for __counted_by on generic pointers in structures (not just flexible array members) has started landing in Clang 19 (current tip of tree). During the development of this feature, a restriction was added to __counted_by to prevent the flexible array member's element type from including a flexi