Re: [PATCH] lib/string_choices: Add str_plural() helper

2024-02-15 Thread Kees Cook
On Wed, 14 Feb 2024 17:50:15 +0100, Michal Wajdeczko wrote: > Add str_plural() helper to replace existing open implementations > used by many drivers and help improve future user facing messages. I added some kern-doc just for good measure. Applied to for-next/hardening, thanks! [1/1] lib/string

Re: [PATCH] lib/string_choices: Add str_plural() helper

2024-02-15 Thread Michal Wajdeczko
On 15.02.2024 18:05, Andy Shevchenko wrote: > On Thu, Feb 15, 2024 at 05:55:43PM +0100, Michal Wajdeczko wrote: >> On 15.02.2024 17:11, Andy Shevchenko wrote: >>> On Thu, Feb 15, 2024 at 04:37:18PM +0100, Michal Wajdeczko wrote: On 15.02.2024 16:20, Jani Nikula wrote: > On Wed, 14 Feb 2

Re: [PATCH] lib/string_choices: Add str_plural() helper

2024-02-15 Thread Andy Shevchenko
On Thu, Feb 15, 2024 at 05:55:43PM +0100, Michal Wajdeczko wrote: > On 15.02.2024 17:11, Andy Shevchenko wrote: > > On Thu, Feb 15, 2024 at 04:37:18PM +0100, Michal Wajdeczko wrote: > >> On 15.02.2024 16:20, Jani Nikula wrote: > >>> On Wed, 14 Feb 2024, Kees Cook wrote: > On Wed, Feb 14, 2024

Re: [PATCH] lib/string_choices: Add str_plural() helper

2024-02-15 Thread Michal Wajdeczko
On 15.02.2024 17:11, Andy Shevchenko wrote: > On Thu, Feb 15, 2024 at 04:37:18PM +0100, Michal Wajdeczko wrote: >> On 15.02.2024 16:20, Jani Nikula wrote: >>> On Wed, 14 Feb 2024, Kees Cook wrote: On Wed, Feb 14, 2024 at 08:49:39PM +0200, Andy Shevchenko wrote: > > ... > Or a Coccin

Re: [PATCH] lib/string_choices: Add str_plural() helper

2024-02-15 Thread Andy Shevchenko
On Thu, Feb 15, 2024 at 04:37:18PM +0100, Michal Wajdeczko wrote: > On 15.02.2024 16:20, Jani Nikula wrote: > > On Wed, 14 Feb 2024, Kees Cook wrote: > >> On Wed, Feb 14, 2024 at 08:49:39PM +0200, Andy Shevchenko wrote: ... > >> Or a Coccinelle script that could do some rewrites? But, yes, if yo

Re: [PATCH] lib/string_choices: Add str_plural() helper

2024-02-15 Thread Michal Wajdeczko
On 15.02.2024 16:20, Jani Nikula wrote: > On Wed, 14 Feb 2024, Kees Cook wrote: >> On Wed, Feb 14, 2024 at 08:49:39PM +0200, Andy Shevchenko wrote: >>> On Wed, Feb 14, 2024 at 08:30:53PM +0200, Jani Nikula wrote: On Wed, 14 Feb 2024, Andy Shevchenko wrote: > On Wed, Feb 14, 2024

Re: [PATCH] lib/string_choices: Add str_plural() helper

2024-02-15 Thread Jani Nikula
On Wed, 14 Feb 2024, Kees Cook wrote: > On Wed, Feb 14, 2024 at 08:49:39PM +0200, Andy Shevchenko wrote: >> On Wed, Feb 14, 2024 at 08:30:53PM +0200, Jani Nikula wrote: >> > On Wed, 14 Feb 2024, Andy Shevchenko >> > wrote: >> > > On Wed, Feb 14, 2024 at 08:08:16PM +0200, Andy Shevchenko wrote: >

Re: [PATCH] lib/string_choices: Add str_plural() helper

2024-02-14 Thread Kees Cook
On Wed, Feb 14, 2024 at 08:49:39PM +0200, Andy Shevchenko wrote: > On Wed, Feb 14, 2024 at 08:30:53PM +0200, Jani Nikula wrote: > > On Wed, 14 Feb 2024, Andy Shevchenko > > wrote: > > > On Wed, Feb 14, 2024 at 08:08:16PM +0200, Andy Shevchenko wrote: > > >> On Wed, Feb 14, 2024 at 05:50:15PM +010

Re: [PATCH] lib/string_choices: Add str_plural() helper

2024-02-14 Thread Andy Shevchenko
On Wed, Feb 14, 2024 at 08:30:53PM +0200, Jani Nikula wrote: > On Wed, 14 Feb 2024, Andy Shevchenko > wrote: > > On Wed, Feb 14, 2024 at 08:08:16PM +0200, Andy Shevchenko wrote: > >> On Wed, Feb 14, 2024 at 05:50:15PM +0100, Michal Wajdeczko wrote: > >> > Add str_plural() helper to replace existi

Re: [PATCH] lib/string_choices: Add str_plural() helper

2024-02-14 Thread Jani Nikula
On Wed, 14 Feb 2024, Andy Shevchenko wrote: > On Wed, Feb 14, 2024 at 08:08:16PM +0200, Andy Shevchenko wrote: >> On Wed, Feb 14, 2024 at 05:50:15PM +0100, Michal Wajdeczko wrote: >> > Add str_plural() helper to replace existing open implementations >> > used by many drivers and help improve futur

Re: [PATCH] lib/string_choices: Add str_plural() helper

2024-02-14 Thread Andy Shevchenko
On Wed, Feb 14, 2024 at 08:08:16PM +0200, Andy Shevchenko wrote: > On Wed, Feb 14, 2024 at 05:50:15PM +0100, Michal Wajdeczko wrote: > > Add str_plural() helper to replace existing open implementations > > used by many drivers and help improve future user facing messages. > > Any user of this, ple

Re: [PATCH] lib/string_choices: Add str_plural() helper

2024-02-14 Thread Andy Shevchenko
On Wed, Feb 14, 2024 at 05:50:15PM +0100, Michal Wajdeczko wrote: > Add str_plural() helper to replace existing open implementations > used by many drivers and help improve future user facing messages. Any user of this, please? > Signed-off-by: Michal Wajdeczko > Cc: Andy Shevchenko > Cc: Jani

[PATCH] lib/string_choices: Add str_plural() helper

2024-02-14 Thread Michal Wajdeczko
Add str_plural() helper to replace existing open implementations used by many drivers and help improve future user facing messages. Signed-off-by: Michal Wajdeczko Cc: Andy Shevchenko Cc: Jani Nikula --- include/linux/string_choices.h | 5 + 1 file changed, 5 insertions(+) diff --git a/in