Re: [PATCH] kbuild: clang: Support building UM with SUBARCH=i386

2025-03-05 Thread Kees Cook
On Wed, Mar 05, 2025 at 03:45:54PM +0100, Nathan Chancellor wrote: > On Tue, Mar 04, 2025 at 09:07:57AM -0800, Kees Cook wrote: > > On Tue, Mar 04, 2025 at 03:51:19PM +0100, Thomas Weißschuh wrote: > > > No, it doesn't. > > > > > > Running tests with: > > > $ .kunit/linux kunit.filter_glob=overflo

Re: [PATCH] kbuild: clang: Support building UM with SUBARCH=i386

2025-03-05 Thread Nathan Chancellor
On Tue, Mar 04, 2025 at 09:07:57AM -0800, Kees Cook wrote: > On Tue, Mar 04, 2025 at 03:51:19PM +0100, Thomas Weißschuh wrote: > > No, it doesn't. > > > > Running tests with: > > $ .kunit/linux kunit.filter_glob=overflow.DEFINE_FLEX_test kunit.enable=1 > > mem=1G console=tty kunit_shutdown=halt >

Re: [PATCH] kbuild: clang: Support building UM with SUBARCH=i386

2025-03-04 Thread Kees Cook
On Tue, Mar 04, 2025 at 03:51:19PM +0100, Thomas Weißschuh wrote: > On 2025-03-04 11:25:36+0100, Nathan Chancellor wrote: > > On Mon, Mar 03, 2025 at 11:29:58PM +0100, Thomas Weißschuh wrote: > > > On 2025-03-03 13:52:41-0800, Kees Cook wrote: > > > > > > This is also what exists in tools/testin

Re: [PATCH] kbuild: clang: Support building UM with SUBARCH=i386

2025-03-04 Thread Thomas Weißschuh
On 2025-03-04 11:25:36+0100, Nathan Chancellor wrote: > On Mon, Mar 03, 2025 at 11:29:58PM +0100, Thomas Weißschuh wrote: > > On 2025-03-03 13:52:41-0800, Kees Cook wrote: > > This is also what exists in tools/testing/selftests/lib.mk. > > Minus the missing CONFIG_FORTIFY_SOURCE on clang x86_32

Re: [PATCH] kbuild: clang: Support building UM with SUBARCH=i386

2025-03-04 Thread Nathan Chancellor
On Mon, Mar 03, 2025 at 11:29:58PM +0100, Thomas Weißschuh wrote: > On 2025-03-03 13:52:41-0800, Kees Cook wrote: > > The UM builds distinguish i386 from x86_64 via SUBARCH, but we don't > > support building i386 directly with Clang. To make SUBARCH work for > > i386 UM, we need to explicitly test

Re: [PATCH] kbuild: clang: Support building UM with SUBARCH=i386

2025-03-03 Thread Thomas Weißschuh
On 2025-03-03 13:52:41-0800, Kees Cook wrote: > The UM builds distinguish i386 from x86_64 via SUBARCH, but we don't > support building i386 directly with Clang. To make SUBARCH work for > i386 UM, we need to explicitly test for it. > > This lets me run i386 KUnit tests with Clang: > > $ ./tools/

[PATCH] kbuild: clang: Support building UM with SUBARCH=i386

2025-03-03 Thread Kees Cook
The UM builds distinguish i386 from x86_64 via SUBARCH, but we don't support building i386 directly with Clang. To make SUBARCH work for i386 UM, we need to explicitly test for it. This lets me run i386 KUnit tests with Clang: $ ./tools/testing/kunit/kunit.py run \ --make_options LLVM=1 \