Re: [PATCH] igbvf: replace deprecated strncpy with strscpy

2023-10-10 Thread Jakub Kicinski
On Tue, 10 Oct 2023 17:47:31 -0700 Jakub Kicinski wrote: > Please do read the netdev rules Jesse pointed you at. > Maybe it's the combined flow of strncpy and __counted_by patches > but managing the state of the "hardening" patches is getting > a bit tedious :( > > Please group them into reasonab

Re: [PATCH] igbvf: replace deprecated strncpy with strscpy

2023-10-10 Thread Jakub Kicinski
On Tue, 10 Oct 2023 14:41:10 -0700 Justin Stitt wrote: > > Thanks Justin for these patches, please make sure you mark the subject > > line as per the netdev rules: > > [PATCH net-next v1] etc etc > > Sure, I'll resend! Please do read the netdev rules Jesse pointed you at. Maybe it's the combine

Re: [PATCH] igbvf: replace deprecated strncpy with strscpy

2023-10-10 Thread Justin Stitt
On Tue, Oct 10, 2023 at 09:12:00PM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We expect netdev->name to be NUL-terminated based on its usage with > `str

Re: [PATCH] igbvf: replace deprecated strncpy with strscpy

2023-10-10 Thread Justin Stitt
On Tue, Oct 10, 2023 at 2:20 PM Jesse Brandeburg wrote: > > On 10/10/2023 2:12 PM, Justin Stitt wrote: > > `strncpy` is deprecated for use on NUL-terminated destination strings > > [1] and as such we should prefer more robust and less ambiguous string > > interfaces. > > > > We expect netdev->name

Re: [PATCH] igbvf: replace deprecated strncpy with strscpy

2023-10-10 Thread Jesse Brandeburg
On 10/10/2023 2:20 PM, Jesse Brandeburg wrote: > On 10/10/2023 2:12 PM, Justin Stitt wrote: >> `strncpy` is deprecated for use on NUL-terminated destination strings >> [1] and as such we should prefer more robust and less ambiguous string >> interfaces. >> >> We expect netdev->name to be NUL-termin

Re: [PATCH] igbvf: replace deprecated strncpy with strscpy

2023-10-10 Thread Jesse Brandeburg
On 10/10/2023 2:12 PM, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We expect netdev->name to be NUL-terminated based on its usage with > `strlen` and format st

[PATCH] igbvf: replace deprecated strncpy with strscpy

2023-10-10 Thread Justin Stitt
`strncpy` is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. We expect netdev->name to be NUL-terminated based on its usage with `strlen` and format strings: | if (strlen(netdev->name) < (IFNAMSIZ - 5