Re: [PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-29 Thread Mark Brown
On Tue, Oct 29, 2024 at 03:14:53PM +, Aleksei Vetrov wrote: > On Tue, Oct 29, 2024 at 02:08:32PM +, Mark Brown wrote: > > For this fix I couldn't send v2, because it has been already applied by > > Mark Brown. Guess I would need to send a separate message to the stable > > team asking them

Re: [PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-29 Thread Aleksei Vetrov
On Tue, Oct 29, 2024 at 02:08:32PM +, Mark Brown wrote: > That doesn't seem to have shown up here? Sorry for the mix up, I've accidentally replied in the wrong thread. As I said in https://lore.kernel.org/all/zydndtgj5vko-...@google.com/: > Actually, my reply above meant to be for the nl80211

Re: [PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-29 Thread Mark Brown
On Tue, Oct 29, 2024 at 01:37:05PM +, Aleksei Vetrov wrote: > Sent v2. That doesn't seem to have shown up here? signature.asc Description: PGP signature

Re: [PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-29 Thread Aleksei Vetrov
On Tue, Oct 29, 2024 at 01:37:09PM +, Aleksei Vetrov wrote: > On Mon, Oct 28, 2024 at 04:58:58PM -0600, Gustavo A. R. Silva wrote: > > > > As in the previous patch, this should include the following tag > > (and probably CC stable): > > > > Fixes: 80e698e2df5b ("ASoC: soc-dapm: Annotate struc

Re: [PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-29 Thread Aleksei Vetrov
On Mon, Oct 28, 2024 at 04:58:58PM -0600, Gustavo A. R. Silva wrote: > > As in the previous patch, this should include the following tag > (and probably CC stable): > > Fixes: 80e698e2df5b ("ASoC: soc-dapm: Annotate struct > snd_soc_dapm_widget_list with __counted_by") Thank you very much for t

Re: [PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-29 Thread Mark Brown
On Mon, 28 Oct 2024 22:50:30 +, Aleksei Vetrov wrote: > The widgets array in the snd_soc_dapm_widget_list has a __counted_by > attribute attached to it, which points to the num_widgets variable. This > attribute is used in bounds checking, and if it is not set before the > array is filled, then

Re: [PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-29 Thread Amadeusz Sławiński
On 10/29/2024 11:30 AM, Takashi Iwai wrote: On Tue, 29 Oct 2024 10:50:21 +0100, Amadeusz Sławiński wrote: On 10/28/2024 11:50 PM, Aleksei Vetrov wrote: The widgets array in the snd_soc_dapm_widget_list has a __counted_by attribute attached to it, which points to the num_widgets variable. This

Re: [PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-29 Thread Takashi Iwai
On Tue, 29 Oct 2024 13:11:32 +0100, Amadeusz Sławiński wrote: > > On 10/29/2024 11:30 AM, Takashi Iwai wrote: > > On Tue, 29 Oct 2024 10:50:21 +0100, > > Amadeusz Sławiński wrote: > >> > >> On 10/28/2024 11:50 PM, Aleksei Vetrov wrote: > >>> The widgets array in the snd_soc_dapm_widget_list has a

Re: [PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-29 Thread Takashi Iwai
On Tue, 29 Oct 2024 10:50:21 +0100, Amadeusz Sławiński wrote: > > On 10/28/2024 11:50 PM, Aleksei Vetrov wrote: > > The widgets array in the snd_soc_dapm_widget_list has a __counted_by > > attribute attached to it, which points to the num_widgets variable. This > > attribute is used in bounds chec

Re: [PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-29 Thread Amadeusz Sławiński
On 10/28/2024 11:50 PM, Aleksei Vetrov wrote: The widgets array in the snd_soc_dapm_widget_list has a __counted_by attribute attached to it, which points to the num_widgets variable. This attribute is used in bounds checking, and if it is not set before the array is filled, then the bounds saniti

Re: [PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-28 Thread Kees Cook
On Mon, Oct 28, 2024 at 04:58:58PM -0600, Gustavo A. R. Silva wrote: > > > On 28/10/24 16:50, Aleksei Vetrov wrote: > > The widgets array in the snd_soc_dapm_widget_list has a __counted_by > > attribute attached to it, which points to the num_widgets variable. This > > attribute is used in bounds

Re: [PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-28 Thread Gustavo A. R. Silva
On 28/10/24 16:50, Aleksei Vetrov wrote: The widgets array in the snd_soc_dapm_widget_list has a __counted_by attribute attached to it, which points to the num_widgets variable. This attribute is used in bounds checking, and if it is not set before the array is filled, then the bounds sanitize

[PATCH] ASoC: dapm: fix bounds checker error in dapm_widget_list_create

2024-10-28 Thread Aleksei Vetrov
The widgets array in the snd_soc_dapm_widget_list has a __counted_by attribute attached to it, which points to the num_widgets variable. This attribute is used in bounds checking, and if it is not set before the array is filled, then the bounds sanitizer will issue a warning or a kernel panic if CO