Re: [PATCH] [RFC] iio: pressure: dlhl60d: Check mask_width for IRQs

2024-02-23 Thread Jonathan Cameron
On Fri, 23 Feb 2024 09:14:53 -0800 Kees Cook wrote: > On Fri, Feb 23, 2024 at 05:09:18PM +, Jonathan Cameron wrote: > > On Thu, 22 Feb 2024 14:23:39 -0800 > > Kees Cook wrote: > > > > > Clang tripped over a FORTIFY warning in this code, and while it seems it > > > may be a false positive

Re: [PATCH] [RFC] iio: pressure: dlhl60d: Check mask_width for IRQs

2024-02-23 Thread Kees Cook
On Fri, Feb 23, 2024 at 05:09:18PM +, Jonathan Cameron wrote: > On Thu, 22 Feb 2024 14:23:39 -0800 > Kees Cook wrote: > > > Clang tripped over a FORTIFY warning in this code, and while it seems it > > may be a false positive in Clang due to loop unwinding, the code in > > question seems to ma

Re: [PATCH] [RFC] iio: pressure: dlhl60d: Check mask_width for IRQs

2024-02-23 Thread Jonathan Cameron
On Thu, 22 Feb 2024 14:23:39 -0800 Kees Cook wrote: > Clang tripped over a FORTIFY warning in this code, and while it seems it > may be a false positive in Clang due to loop unwinding, the code in > question seems to make a lot of assumptions. Hi Kees, The assumptions are mostly characteristic

[PATCH] [RFC] iio: pressure: dlhl60d: Check mask_width for IRQs

2024-02-22 Thread Kees Cook
Clang tripped over a FORTIFY warning in this code, and while it seems it may be a false positive in Clang due to loop unwinding, the code in question seems to make a lot of assumptions. Comments added, and the Clang warning[1] has been worked around by growing the array size. Also there was an unin