Re: [PATCH][next] firewire: core: avoid -Wflex-array-member-not-at-end warning

2025-03-12 Thread Takashi Sakamoto
to the structure. Therefore the 'COUNT' argument of DEFINE_RAW_FLEX() macro should be 64 (= 256 / 4). Although the header field is not rarely used by userspace applications actually and the reduction of kernel stack usage is preferable itself, it is preferable to keep the compatibility. Thanks Takashi Sakamoto

Re: [PATCH v2][next] ALSA: firewire-lib: Avoid -Wflex-array-member-not-at-end warning

2024-03-25 Thread Takashi Sakamoto
sound/firewire/amdtp-stream.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) It looks good to me. Reviewed-by: Takashi Sakamoto I remark that the change requires a commit d8e45f2929b9 "overflow: Change DEFINE_FLEX to take __counted_by member"), added to v6.9-rc1. Thanks Takashi Sakamoto

Re: [PATCH][next] firewire: Annotate struct fw_iso_packet with __counted_by()

2024-03-25 Thread Takashi Sakamoto
changes to the other subsystem. Thanks Takashi Sakamoto

Re: [PATCH 0/2][next] firewire: Avoid -Wflex-array-member-not-at-end warnings

2024-03-05 Thread Takashi Sakamoto
elopment period for v6.8 kernel. Let me postpone applying the patches until closing the next merge window (for v6.9), since we need the term to evaluate the change. I mean that it goes to v6.10 kernel. If you would like me to applying the patch v6.9 kernel, please inform it to us. Thanks Takashi Sakamoto

Re: [PATCH] firewire: Annotate struct fw_node with __counted_by

2023-09-24 Thread Takashi Sakamoto
DS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct fw_node. > > [1] > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: