eviewed-by: Saeed Mahameed
--
Gustavo
On 26 Feb 17:25, Jakub Kicinski wrote:
On Wed, 26 Feb 2025 10:49:35 -0800 Saeed Mahameed wrote:
On 26 Feb 13:47, Gustavo A. R. Silva wrote:
>-struct mlx5e_umr_wqe {
>+struct mlx5e_umr_wqe_hdr {
>struct mlx5_wqe_ctrl_seg ctrl;
>struct mlx5_wqe_umr_ctrl_seg uctrl;
On 26 Feb 13:47, Gustavo A. R. Silva wrote:
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are
getting ready to enable it, globally.
So, in this particular case, we create a new `struct mlx5e_umr_wqe_hdr`
to enclose the header part of flexible structure `struct mlx5e_umr_wqe`.
T
On 20 Feb 10:26, Jakub Kicinski wrote:
On Thu, 6 Feb 2025 15:07:07 +1030 Gustavo A. R. Silva wrote:>
Here is another alternative for this. And similarly to the
struct_group_tagged()
change above, no struct members should be added before or after `struct
mlx5e_umr_wqe_hdr hdr;` in `struct mlx5e
-hardening@vger.kernel.org
Cc: Kees Cook
Signed-off-by: Justin Stitt
Reviewed-by: Kees Cook
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/main.c| 20 +++
1 file changed, 3 insertions(+), 17 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/
-hardening@vger.kernel.org
Cc: Kees Cook
Signed-off-by: Justin Stitt
Reviewed-by: Kees Cook
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/main.c| 20 +++
1 file changed, 3 insertions(+), 17 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/
-hardening@vger.kernel.org
Cc: Kees Cook
Signed-off-by: Justin Stitt
Reviewed-by: Kees Cook
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/main.c| 20 +++
1 file changed, 3 insertions(+), 17 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/
(for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct mlx5_flow_handle.
Cc: Saeed Mahameed
Cc: Leon Romanovsky
Cc: "David S. Miller"
Cc: Eric Dumazet
Cc: Jakub Kicinski
Cc: Paolo Abeni
Cc: net...@vger.kernel.org
Cc: linux-r...@vger.kerne
(for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct mlx5_fc_bulk.
Cc: Saeed Mahameed
Cc: Leon Romanovsky
Cc: "David S. Miller"
Cc: Eric Dumazet
Cc: Jakub Kicinski
Cc: Paolo Abeni
Cc: net...@vger.kernel.org
Cc: linux-r...@vger.kernel.org
Li
6a2c911d8f38d8247814b4c07f49a2
change-id: 20231011-strncpy-drivers-net-ethernet-mellanox-mlx4-fw-c-67809559dd1a
Best regards,
--
Justin Stitt
Reviewed-by: Saeed Mahameed
On 11 Oct 14:34, Kees Cook wrote:
On Wed, Oct 11, 2023 at 09:29:57PM +, Justin Stitt wrote:
In total, just assigning this version string takes:
(1) strncpy()'s
(5) strlen()'s
(3) strncat()'s
(1) snprintf()'s
(4) max_t()'s
Moreover, `strncpy` is deprecated [1] and `strncat` really shouldn't
11 matches
Mail list logo
