Re: [PATCH] alloc_tag: Tighten file permissions on /proc/allocinfo

2024-04-26 Thread Pavel Machek
On Fri 2024-04-26 04:25:40, Matthew Wilcox wrote: > On Thu, Apr 25, 2024 at 08:58:34PM -0400, Kent Overstreet wrote: > > On Thu, Apr 25, 2024 at 05:43:33PM -0700, Kees Cook wrote: > > > All this said, I'm still not excited about any of these files living > > > in /proc at all -- we were supposed to

Re: [PATCH] alloc_tag: Tighten file permissions on /proc/allocinfo

2024-04-26 Thread Pavel Machek
Hi! > > > > > The /proc/allocinfo file exposes a tremendous about of information > > > > > about > > > > > kernel build details, memory allocations (obviously), and potentially > > > > > even image layout (due to ordering). As this is intended to be > > > > > consumed > > > > > by system owners

Re: [PATCH AUTOSEL 6.1 10/12] enic: Avoid false positive under FORTIFY_SOURCE

2024-03-11 Thread Pavel Machek
Hi! > From: Kees Cook > > [ Upstream commit 40b9385dd8e6a0515e1c9cd06a277483556b7286 ] > > FORTIFY_SOURCE has been ignoring 0-sized destinations while the kernel > code base has been converted to flexible arrays. In order to enforce > the 0-sized destinations (e.g. with __counted_by), the remai

Re: [RFC] string: Allow 2-argument strscpy()

2024-02-07 Thread Pavel Machek
Hi! > > Using sizeof(dst) is the overwhelmingly common case for strscpy(). > > Instead of requiring this everywhere, allow a 2-argument version to be > > used that will use the sizeof() internally. > > Yeah, this is definitely the case. I have a ton of patches replacing > strncpy with strscpy [1]

Re: [PATCH v6 2/2] arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree

2023-10-23 Thread Pavel Machek
Hi! > > Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc. > > > > Signed-off-by: Luka Panio > > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts > > @@ -0,0 +1,625 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > If there are no other copyrights here, why did you use BSD-