Re: [PATCH] octeontx2-af: Fix uninitialized scalar variable

2025-02-13 Thread Paolo Abeni
On 2/11/25 6:50 AM, Michal Swiatkowski wrote: > On Mon, Feb 10, 2025 at 09:01:52PM -0500, Ethan Carter Edwards wrote: >> The variable *max_mtu* is uninitialized in the function >> otx2_get_max_mtu. It is only assigned in the if-statement, leaving the >> possibility of returning an uninitialized val

Re: [PATCH] net/mlx4_core: Avoid impossible mlx4_db_alloc() order value

2025-02-13 Thread Paolo Abeni
On 2/13/25 1:10 AM, Justin Stitt wrote: > On Tue, Feb 11, 2025 at 6:22 AM Tariq Toukan wrote: >> On 11/02/2025 2:01, Justin Stitt wrote: diff --git a/drivers/net/ethernet/mellanox/mlx4/alloc.c b/drivers/net/ethernet/mellanox/mlx4/alloc.c index b330020dc0d6..f2bded847e61 100644

Re: [PATCH v2] net: core: Convert inet_addr_is_any() to sockaddr_storage

2024-12-19 Thread Paolo Abeni
On 12/17/24 21:34, Kees Cook wrote: > All the callers of inet_addr_is_any() have a sockaddr_storage-backed > sockaddr. Avoid casts and switch prototype to the actual object being > used. > > Reviewed-by: Christoph Hellwig > Reviewed-by: Simon Horman > Signed-off-by: Kees Cook It looks like the

Re: [PATCH v2] net/ipv4/tcp_cong: Replace strncpy() with strscpy()

2024-07-16 Thread Paolo Abeni
On 7/15/24 11:41, Simon Horman wrote: On Sat, Jul 13, 2024 at 09:11:15PM -0700, Kees Cook wrote: Replace the deprecated[1] uses of strncpy() in tcp_ca_get_name_by_key() and tcp_get_default_congestion_control(). The callers use the results as standard C strings (via nla_put_string() and proc hand