Re: [PATCH v2] iio: proximity: hx9023s: Added firmware file parsing functionality

2024-12-20 Thread Jonathan Cameron
On Mon, 16 Dec 2024 15:59:40 +0800 Yasin Lee wrote: > Configuration information is now prioritized from the firmware file. > If the firmware file is missing or fails to parse, the driver falls > back to using the default configuration list for writing the settings. > > Signed-off-by: Yasin Lee

Re: [PATCH] iio: proximity: hx9023s: Added firmware file parsing functionality

2024-12-15 Thread Jonathan Cameron
On Tue, 10 Dec 2024 12:24:03 +0800 Yasin Lee wrote: > Configuration information is now prioritized from the firmware file. > If the firmware file is missing or fails to parse, the driver falls > back to using the default configuration list for writing the settings. > > Signed-off-by: Yasin Lee

Re: [PATCH V9 2/2] iio: proximity: aw96103: Add support for aw96103/aw96105 proximity sensor

2024-09-05 Thread Jonathan Cameron
On Wed, 4 Sep 2024 03:30:34 +0300 Andy Shevchenko wrote: > Tue, Aug 27, 2024 at 08:02:29AM +, wangshuai...@awinic.com kirjoitti: > > From: shuaijie wang > > > > AW96103 is a low power consumption capacitive touch and proximity > > controller. > > Each channel can be independently config as

Re: [PATCH V10 2/2] iio: proximity: aw96103: Add support for aw96103/aw96105 proximity sensor

2024-09-05 Thread Jonathan Cameron
On Wed, 4 Sep 2024 11:35:55 + wangshuai...@awinic.com wrote: > From: shuaijie wang > > AW96103 is a low power consumption capacitive touch and proximity controller. > Each channel can be independently config as sensor input, shield output. > > Channel Information: > aw96103: 3-channel >

Re: [PATCH V9 0/2] Add support for aw96103/aw96105 proximity sensor

2024-09-03 Thread Jonathan Cameron
On Tue, 3 Sep 2024 06:03:04 + wrote: > On Sat, 31 Aug 2024 15:07:24 +0100, ji...@kernel.org wrote: > >On Tue, 27 Aug 2024 08:02:27 + > >wangshuai...@awinic.com wrote: > > > >> From: shuaijie wang > >> > >> Add drivers that support Awinic aw96103/aw96105 proximity sensors. > >> > >>

Re: [PATCH V9 0/2] Add support for aw96103/aw96105 proximity sensor

2024-08-31 Thread Jonathan Cameron
On Tue, 27 Aug 2024 08:02:27 + wangshuai...@awinic.com wrote: > From: shuaijie wang > > Add drivers that support Awinic aw96103/aw96105 proximity sensors. > > The aw9610x series are high-sensitivity capacitive proximity detection > sensors. This device detects human proximity and assists el

Re: [PATCH V8 2/2] iio: proximity: aw96103: Add support for aw96103/aw96105 proximity sensor

2024-08-24 Thread Jonathan Cameron
On Fri, 23 Aug 2024 09:49:46 + wangshuai...@awinic.com wrote: > From: shuaijie wang > > AW96103 is a low power consumption capacitive touch and proximity controller. > Each channel can be independently config as sensor input, shield output. > > Channel Information: > aw96103: 3-channel >

Re: [PATCH V7 1/2] dt-bindings: iio: aw96103: Add bindings for aw96103/aw96105 sensor

2024-08-17 Thread Jonathan Cameron
On Wed, 14 Aug 2024 03:18:07 + wangshuai...@awinic.com wrote: > From: shuaijie wang > > Add device tree bindings for aw96103/aw96105 proximity sensor. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: shuaijie wang > --- > .../iio/proximity/awinic,aw96103.yaml | 63 ++

Re: [PATCH V7 2/2] iio: proximity: aw96103: Add support for aw96103/aw96105 proximity sensor

2024-08-17 Thread Jonathan Cameron
On Wed, 14 Aug 2024 03:18:08 + wangshuai...@awinic.com wrote: > From: shuaijie wang > > AW96103 is a low power consumption capacitive touch and proximity controller. > Each channel can be independently config as sensor input, shield output. > > Channel Information: > aw96103: 3-channel >

Re: [PATCH V6 2/2] iio: proximity: aw96103: Add support for aw96103/aw96105 proximity sensor

2024-08-17 Thread Jonathan Cameron
On Thu, 8 Aug 2024 10:28:51 + wangshuai...@awinic.com wrote: > From: shuaijie wang > > AW96103 is a low power consumption capacitive touch and proximity controller. > Each channel can be independently config as sensor input, shield output. > > Channel Information: > aw96103: 3-channel >

Re: [PATCH V6 1/2] dt-bindings: iio: aw96103: Add bindings for aw96103/aw96105 sensor

2024-08-17 Thread Jonathan Cameron
On Thu, 8 Aug 2024 10:28:50 + wangshuai...@awinic.com wrote: > From: shuaijie wang > > Add device tree bindings for aw96103/aw96105 proximity sensor. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: shuaijie wang > --- > .../iio/proximity/awinic,aw96103.yaml | 63 ++

Re: [PATCH] iio: event: use sizeof(*pointer) instead of sizeof(type)

2024-06-08 Thread Jonathan Cameron
On Sun, 2 Jun 2024 19:23:54 +0200 Erick Archer wrote: > It is preferred to use sizeof(*pointer) instead of sizeof(type) > due to the type of the variable can change and one needs not > change the former (unlike the latter). At the same time refactor > the NULL comparison. > > This patch has no

Re: [PATCH v4 5/8] iio: core: Use new helpers from overflow.h in iio_device_alloc()

2024-03-03 Thread Jonathan Cameron
On Thu, 29 Feb 2024 16:29:43 +0100 Nuno Sá wrote: > On Wed, 2024-02-28 at 22:41 +0200, Andy Shevchenko wrote: > > We have two new helpers struct_size_with_data() and struct_data_pointer() > > that we can utilize in iio_device_alloc(). Do it so. > > > > Signed-off-by: Andy Shevchenko > > Reviewe

Re: [PATCH v4 3/8] iio: core: NULLify private pointer when there is no private data

2024-03-03 Thread Jonathan Cameron
On Wed, 28 Feb 2024 23:36:43 +0200 Andy Shevchenko wrote: > On Wed, Feb 28, 2024 at 03:06:42PM -0600, David Lechner wrote: > > On Wed, Feb 28, 2024 at 2:50 PM Andy Shevchenko > > wrote: > > ... > > > > - indio_dev->priv = (char *)iio_dev_opaque + > > > - ALIGN(sizeof(stru

Re: [PATCH v2] iio: pressure: dlhl60d: Initialize empty DLH bytes

2024-02-25 Thread Jonathan Cameron
On Fri, 23 Feb 2024 09:50:10 -0800 Kees Cook wrote: > On Fri, Feb 23, 2024 at 07:47:36PM +0200, Andy Shevchenko wrote: > > On Fri, Feb 23, 2024 at 09:29:39AM -0800, Kees Cook wrote: > > > 3 bytes were being read but 4 were being written. Explicitly initialize > > > the unused bytes to 0 and ref

Re: [PATCH] [RFC] iio: pressure: dlhl60d: Check mask_width for IRQs

2024-02-23 Thread Jonathan Cameron
On Fri, 23 Feb 2024 09:14:53 -0800 Kees Cook wrote: > On Fri, Feb 23, 2024 at 05:09:18PM +0000, Jonathan Cameron wrote: > > On Thu, 22 Feb 2024 14:23:39 -0800 > > Kees Cook wrote: > > > > > Clang tripped over a FORTIFY warning in this code, and while it seems it

Re: [PATCH] [RFC] iio: pressure: dlhl60d: Check mask_width for IRQs

2024-02-23 Thread Jonathan Cameron
b.com/ClangBuiltLinux/linux/issues/2000 [1] > Signed-off-by: Kees Cook > --- > Cc: Jonathan Cameron > Cc: Lars-Peter Clausen > Cc: "Uwe Kleine-König" > Cc: Andy Shevchenko > Cc: "Nuno Sá" > Cc: linux-...@vger.kernel.org > --- > drivers/iio/pressu

Re: [PATCH v5] iio: sx9324: avoid copying property strings

2024-02-04 Thread Jonathan Cameron
On Fri, 2 Feb 2024 15:38:03 -0600 Stephen Boyd wrote: > Quoting Justin Stitt (2024-02-01 10:55:03) > > We're doing some needless string copies when trying to assign the proper > > `prop` string. We can make `prop` a const char* and simply assign to > > string literals. > > > > For the case where

Re: [PATCH v4] iio: sx9324: avoid copying property strings

2023-12-26 Thread Jonathan Cameron
On Tue, 19 Dec 2023 21:34:15 + Justin Stitt wrote: > We're doing some needless string copies when trying to assign the proper > `prop` string. We can make `prop` a const char* and simply assign to > string literals. > > For the case where a format string is used, let's extract the parsing >

Re: [PATCH v3] iio: sx9324: avoid copying property strings

2023-12-17 Thread Jonathan Cameron
On Mon, 11 Dec 2023 22:30:12 -0800 Joe Perches wrote: > On Tue, 2023-12-12 at 00:42 +, Justin Stitt wrote: > > We're doing some needless string copies when trying to assign the proper > > `prop` string. We can make `prop` a const char* and simply assign to > > string literals. > > trivia:

Re: [PATCH v2] iio: sx9324: avoid copying property strings

2023-12-17 Thread Jonathan Cameron
On Tue, 12 Dec 2023 15:51:04 -0800 Gwendal Grignou wrote: > Reviewed-by: Gwendal Grignou Hi Gwendal I'll ignore this tag given the email you've replied to says there is a different implementation. Please take a look at that version instead. Jonathan > > On Mon, Dec 11, 2023 at 4:46 PM Justin

Re: [PATCH v2] iio: sx9324: avoid copying property strings

2023-10-28 Thread Jonathan Cameron
On Thu, 26 Oct 2023 23:53:28 + Justin Stitt wrote: > We're doing some needless string copies when trying to assign the proper > `prop` string. We can make `prop` a const char* and simply assign to > string literals. > > For the case where a format string is used, let's allocate some memory >

Re: [PATCH] iio: adc: stm32-adc: replace deprecated strncpy

2023-10-05 Thread Jonathan Cameron
On Sat, 30 Sep 2023 10:57:03 -0700 Kees Cook wrote: > On Sat, Sep 30, 2023 at 06:41:18PM +0100, Jonathan Cameron wrote: > > On Sat, 23 Sep 2023 20:15:09 -0700 > > Kees Cook wrote: > > > > > On Thu, Sep 21, 2023 at 04:54:00AM +, Justin Stitt wrote: >

Re: [PATCH] iio: adc: stm32-adc: replace deprecated strncpy

2023-09-30 Thread Jonathan Cameron
On Sat, 23 Sep 2023 20:15:09 -0700 Kees Cook wrote: > On Thu, Sep 21, 2023 at 04:54:00AM +, Justin Stitt wrote: > > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > > > We should prefer more robust and less ambiguous string interfaces. > > > > We expect adc->ch

Re: [PATCH] iio: sx9324: replace deprecated strncpy

2023-09-23 Thread Jonathan Cameron
On Thu, 21 Sep 2023 07:01:01 + Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > We should prefer more robust and less ambiguous string interfaces. > > `prop` is defined as this string literal with size 30 (including null): > | #defin