l.org/all/202406261121.2FFD65647@keescook/ [1]
Fixes: 16c2004d9e4d ("mfd: omap-usb-tll: Allocate driver data at once")
Reviewed-by: Kees Cook
Signed-off-by: Javier Carrasco
---
Changes in v2:
- Patch 1/2: drop (applied).
- Patch 2/2: turn into fix.
- Link to v1:
https://lore.kernel.o
On 26/06/2024 20:43, Kees Cook wrote:
> On Thu, Jun 20, 2024 at 11:22:34PM +0200, Javier Carrasco wrote:
>> Use the struct_size macro to calculate the size of the tll, which
>> includes a trailing flexible array.
>>
>> Signed-off-by: Javier Carrasco
>>
>>
On 26/06/2024 17:26, Lee Jones wrote:
> On Thu, 20 Jun 2024, Javier Carrasco wrote:
>
>> Use the struct_size macro to calculate the size of the tll, which
>> includes a trailing flexible array.
>>
>> Signed-off-by: Javier Carrasco
>>
>> ---
>> The
Use the struct_size macro to calculate the size of the tll, which
includes a trailing flexible array.
Signed-off-by: Javier Carrasco
---
The memory allocation used to be carried out in two steps:
tll = devm_kzalloc(dev, sizeof(struct usbtll_omap), GFP_KERNEL);
tll->ch_clk = devm_kzalloc(
Use the __counted_by compiler attribute for the "struct clk *ch_clk[]"
flexible array member to improve the results of array bound sanitizers.
The comments for the variables are no longer needed as it is now clear
what is what.
Signed-off-by: Javier Carrasco
---
drivers/mfd/omap-usb
The first patch carries out a straightforward annotation, given that the
number of channels is initialized before any reference to the flexible
array.
I might need some feedback on the second patch. I added a comment
regarding the issue to provide clarification.
Signed-off-by: Javier Carrasco
This case of the common error message upon failure of
input_allocate_device() repeats the word "input".
Drop one "input" from the error message.
Signed-off-by: Javier Carrasco
---
drivers/input/misc/ims-pcu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -
Use the __counted_by compiler attribute for the data[] flexible array
member to improve the results of array bound sanitizers.
Signed-off-by: Javier Carrasco
---
drivers/input/misc/ims-pcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/ims-pcu.c b
The length is assigned before the first reference to the data flexible
array (see ims_pcu_flash_firmware()), which allows for a straightforward
annotation without further modifications.
When at it, I also fixed an error message that repeats the word "input".
Signed-off-by: Javie
Use the struct_size macro to calculate the size of the pkt, which
includes a trailing flexible array.
Suggested-by: Nathan Chancellor
Signed-off-by: Javier Carrasco
---
drivers/usb/serial/garmin_gps.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/serial
Use the __counted_by compiler attribute for the data[] flexible array
member to improve the results of array bound sanitizers.
Reviewed-by: Nathan Chancellor
Signed-off-by: Javier Carrasco
---
drivers/usb/serial/garmin_gps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
The size is assigned before the first reference to the flexible array
(see pkt_add()), which allows for a straightforward annotation without
further modifications.
Signed-off-by: Javier Carrasco
---
Changes in v2:
- Use struct_size to calculate the size of pkt.
- Link to v1:
https
On 19/06/2024 16:43, Nathan Chancellor wrote:
> On Wed, Jun 19, 2024 at 11:40:57AM +0200, Javier Carrasco wrote:
>> Use the __counted_by compiler attribute for the data[] flexible array member
>> to improve the results of array bound sanitizers.
>>
>> Signed-off-by: Jav
Use the __counted_by compiler attribute for the data[] flexible array member
to improve the results of array bound sanitizers.
Signed-off-by: Javier Carrasco
---
The size is assigned before the first reference to the flexible array
(see pkt_add()), which allows for a straightforward annotation
14 matches
Mail list logo
