Re: [PATCH] pinctrl: airoha: Use unsigned long for bit search

2024-11-17 Thread AngeloGioacchino Del Regno
note: object 'status' of size 4 2387 | u32 status; | ^~ Signed-off-by: Kees Cook Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] iommu/mtk_iommu: Use devm_kcalloc() instead of devm_kzalloc()

2024-02-12 Thread AngeloGioacchino Del Regno
cess/deprecated.html#open-coded-arithmetic-in-allocator-arguments [2] Signed-off-by: Erick Archer Reviewed-by: AngeloGioacchino Del Regno --- drivers/iommu/mtk_iommu.c| 2 +- drivers/iommu/mtk_iommu_v1.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH v2] mtd: rawnand: Prefer struct_size over open coded arithmetic

2024-02-12 Thread AngeloGioacchino Del Regno
the commit description issue. Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] mtd: rawnand: Prefer struct_size over open coded arithmetic

2024-02-12 Thread AngeloGioacchino Del Regno
nd more safer. This way, the code is more readable and safer. Apart from that, Reviewed-by: AngeloGioacchino Del Regno Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1] Link: https://github.com/KSPP/linux/issues/160 [

Re: [PATCH] ARM: unwind: Add missing "Call trace:" line

2024-01-11 Thread AngeloGioacchino Del Regno
f_bounds+0x80/0x84 ... Reported-by: Mark Brown Cc: Russell King Cc: Ard Biesheuvel Cc: Arnd Bergmann Cc: Linus Walleij Cc: Vladimir Murzin Cc: Zhen Lei Cc: Keith Packard Cc: Haibo Li Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Kees Cook Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 1/2] pstore/ram: Register to module device table

2024-01-11 Thread AngeloGioacchino Del Regno
Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] net: dsa: mt7530: replace deprecated strncpy with ethtool_sprintf

2023-10-10 Thread AngeloGioacchino Del Regno
90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Justin Stitt Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] leds: mt6360: Annotate struct mt6360_priv with __counted_by

2023-09-18 Thread AngeloGioacchino Del Regno
CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). As found with Coccinelle[1], add __counted_by for struct mt6360_priv. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Pavel Machek Cc: Lee Jones Cc: Matthias Brugger Cc: AngeloGioacchino Del Regno

Re: [PATCH] leds: mt6370: Annotate struct mt6370_priv with __counted_by

2023-09-18 Thread AngeloGioacchino Del Regno
CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). As found with Coccinelle[1], add __counted_by for struct mt6370_priv. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Pavel Machek Cc: Lee Jones Cc: Matthias Brugger Cc: AngeloGioacchino Del Regno