Re: [PATCH v2 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

2024-11-08 Thread Andreas Kemnade
Am Fri, 8 Nov 2024 09:51:07 + schrieb Mithil Bavishi : > > probably you did not notice an error in make dtbs and the old > > devicetree on the device was still there and was used. > > I messed up my PowerVR tree with mainline, hence the problems. I've fixed > it now locally. > > > are not

Re: [PATCH v2 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

2024-11-03 Thread Andreas Kemnade
Am Thu, 31 Oct 2024 10:41:45 + schrieb Mithil Bavishi : > > well, that takes time, I wanted to start that on the right thing. > > Yes indeed, I'll be more careful the next time, again sorry for the > trouble, I am not used to the process of mailing lists and may have > done some mistakes t

Re: [PATCH v2 3/6] dt-bindings: omap: Add Samaung Galaxy Tab 2 7.0

2024-10-31 Thread Andreas Kemnade
Am Thu, 31 Oct 2024 09:18:49 +0100 schrieb Krzysztof Kozlowski : > On Wed, Oct 30, 2024 at 09:18:43PM +, Mithil Bavishi wrote: > > Add samsung-espresso7 codename for the 7 inch variant > > > > Signed-off-by: Mithil Bavishi > > --- > > Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 +

Re: [PATCH v2 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

2024-10-31 Thread Andreas Kemnade
Hi, Am Thu, 31 Oct 2024 06:55:24 + schrieb Mithil Bavishi : > > this has to be system-power-controller; > > I am so sorry for the mess up, I was on the wrong branch which is > almost the same as pmOS but a bit older, hence the entire mess up. > I'll run a quick diff from pmOS and this patc

Re: [PATCH v2 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

2024-10-30 Thread Andreas Kemnade
Hi Mithil, Am Wed, 30 Oct 2024 21:12:11 + schrieb Mithil Bavishi : > + twl: twl@48 { > + reg = <0x48>; > + #clock-cells = <1>; > + > + pinctrl-names = "default"; > + pinctrl-0 = < > + &twl6030_pins > +

Re: [PATCH v1 4/6] arm/dts: Add initial support for Galaxy Tab 2 7.0

2024-10-30 Thread Andreas Kemnade
Am Wed, 30 Oct 2024 19:41:34 + schrieb Mithil Bavishi : > Create a device tree for the 3 inch variants (P3100, P3110, P3113) > > Signed-off-by: Mithil Bavishi > --- > arch/arm/boot/dts/ti/omap/Makefile| 1 + > .../dts/ti/omap/omap4-samsung-espresso7.dts | 70 > +++

Re: [PATCH v1 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

2024-10-30 Thread Andreas Kemnade
Hi, a quick first pass of review. Am Wed, 30 Oct 2024 19:41:32 + schrieb Mithil Bavishi : > Create common device tree for Samsung Espresso series devices > > Differentiate based on screen sizes, panels, touch controllers, > and batteries > > Signed-off-by: Mithil Bavishi > --- [...] > +