.
Reviewed-by: Alex Elder
I want to call attention to a few other spots that should
get a little more attention--related directly to what you're
doing here.
I noticed that the GB_CONTROL_TYPE_GET_MANIFEST response
structure also contains only a flexible array. It might
be good to add a si
On 2/17/24 3:58 PM, Kees Cook wrote:
On Sat, Feb 17, 2024 at 02:17:33PM -0600, Alex Elder wrote:
On 2/16/24 5:28 PM, Kees Cook wrote:
FORTIFY_SOURCE has been ignoring 0-sized destinations while the kernel
code base has been converted to flexible arrays. In order to enforce
the 0-sized
est, so I think it's unrelated to
the change you're proposing.
Johan can confirm this.
I'd like to hear from these others, but otherwise this change
looks good to me.
Reviewed-by: Alex Elder
I have search for another greybus drivers and I have f
().
Otherwise this looks good.
Reviewed-by: Alex Elder
Signed-off-by: Kees Cook
---
Cc: Viresh Kumar
Cc: Johan Hovold
Cc: Alex Elder
Cc: Greg Kroah-Hartman
Cc: Gustavo A. R. Silva
Cc: greybus-...@lists.linaro.org
Cc: linux-stag...@lists.linux.dev
---
drivers/staging/greybus/bootrom.c
a
Signed-off-by: Erick Archer
---
Changes in v2:
- Add more info in the commit message to better explain the change.
(Dan Carpenter)
- Add the "Reviewed-by:" tag.
Looks good.
Reviewed-by: Alex Elder
Previous versions:
v1 -
https://lore.kernel.org/linux-hardening/20240120152518.13
audited and
fixed manually.
Looks good to me, and I like the use of struct_size().
Reviewed-by: Alex Elder
Signed-off-by: Gustavo A. R. Silva
---
drivers/staging/greybus/raw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/raw.c b/drivers
CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct ipa_power.
Looks good, thanks.
Reviewed-by: Alex Elder
Note that there is some interaction between struct ipa_power_data
and struct ipa_power (the former is used to initialize the latter
