Re: [PATCH][next] scsi: qla2xxx: Fix memcpy field-spanning write issue

2025-07-30 Thread Martin K. Petersen
Gustavo, > + > + /* Must be last --ends in a flexible-array member. */ > + TRAILING_OVERLAP(struct purex_item, default_item, iocb, > + uint8_t __default_item_iocb[QLA_DEFAULT_PAYLOAD_SIZE]; > + ); > } scsi_qla_host_t; Looks OK to me but will have to wait for TRAILING_OV

Re: [PATCH v9 3/3] ARM: dts: aspeed: clemente: add NCSI3 and NCSI4 pinctrl nodes

2025-07-30 Thread Andrew Jeffery
On Wed, 2025-07-23 at 11:42 +0800, Leo Wang wrote: > Add pinctrl nodes for NCSI3 and NCSI4 to the AST2600 pinctrl > description, enabling support for RMII3 and RMII4 interfaces. > > Signed-off-by: Leo Wang > --- >  arch/arm/boot/dts/aspeed/aspeed-g6-pinctrl.dtsi | 10 ++ >  1 file changed,

Re: [PATCH v9 2/3] ARM: dts: aspeed: clemente: add Meta Clemente BMC

2025-07-30 Thread Andrew Jeffery
On Wed, 2025-07-23 at 11:42 +0800, Leo Wang wrote: > From: Leo Wang > > Add linux device tree entry for Meta Clemente compute-tray > BMC using AST2600 SoC. > > Signed-off-by: Leo Wang Aside from the usual ASPEED warnings, I see: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-clemente.dtb: adc@3

Re: [PATCH v5 0/4] i3c: add support for the Renesas controller

2025-07-30 Thread Alexandre Belloni
On Thu, 24 Jul 2025 11:41:39 +0200, Wolfram Sang wrote: > Detailed changes since v4 are described in the individual patches. A > branch with enablement patches for RZ/G3S+G3E can be found here: > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/g3s/i3c > > Old coverletter: >

Re: [PATCH bpf-next v5 08/12] bpf: Report rqspinlock deadlocks/timeout to BPF stderr

2025-07-30 Thread Kees Cook
On Wed, Jul 30, 2025 at 04:13:25PM -0700, Alexei Starovoitov wrote: > On Wed, Jul 30, 2025 at 4:09 PM Kees Cook wrote: > > > > On Wed, Jul 30, 2025 at 04:07:33PM -0700, Alexei Starovoitov wrote: > > > On Wed, Jul 30, 2025 at 4:02 PM Kees Cook wrote: > > > > > > > > On Thu, Jul 03, 2025 at 01:48:1

Re: [PATCH bpf-next v5 08/12] bpf: Report rqspinlock deadlocks/timeout to BPF stderr

2025-07-30 Thread Alexei Starovoitov
On Wed, Jul 30, 2025 at 4:09 PM Kees Cook wrote: > > On Wed, Jul 30, 2025 at 04:07:33PM -0700, Alexei Starovoitov wrote: > > On Wed, Jul 30, 2025 at 4:02 PM Kees Cook wrote: > > > > > > On Thu, Jul 03, 2025 at 01:48:14PM -0700, Kumar Kartikeya Dwivedi wrote: > > > > +static void bpf_prog_report_r

Re: [PATCH bpf-next v5 08/12] bpf: Report rqspinlock deadlocks/timeout to BPF stderr

2025-07-30 Thread Kees Cook
On Wed, Jul 30, 2025 at 04:07:33PM -0700, Alexei Starovoitov wrote: > On Wed, Jul 30, 2025 at 4:02 PM Kees Cook wrote: > > > > On Thu, Jul 03, 2025 at 01:48:14PM -0700, Kumar Kartikeya Dwivedi wrote: > > > +static void bpf_prog_report_rqspinlock_violation(const char *str, void > > > *lock, bool i

Re: [PATCH bpf-next v5 08/12] bpf: Report rqspinlock deadlocks/timeout to BPF stderr

2025-07-30 Thread Alexei Starovoitov
On Wed, Jul 30, 2025 at 4:02 PM Kees Cook wrote: > > On Thu, Jul 03, 2025 at 01:48:14PM -0700, Kumar Kartikeya Dwivedi wrote: > > +static void bpf_prog_report_rqspinlock_violation(const char *str, void > > *lock, bool irqsave) > > +{ > > + struct rqspinlock_held *rqh = this_cpu_ptr(&rqspinloc

Re: [PATCH bpf-next v5 08/12] bpf: Report rqspinlock deadlocks/timeout to BPF stderr

2025-07-30 Thread Kees Cook
On Thu, Jul 03, 2025 at 01:48:14PM -0700, Kumar Kartikeya Dwivedi wrote: > +static void bpf_prog_report_rqspinlock_violation(const char *str, void > *lock, bool irqsave) > +{ > + struct rqspinlock_held *rqh = this_cpu_ptr(&rqspinlock_held_locks); > + struct bpf_stream_stage ss; > + str

[PATCH][next] scsi: qla2xxx: Fix memcpy field-spanning write issue

2025-07-30 Thread Gustavo A. R. Silva
purex_item.iocb is defined as a 64-element u8 array, but 64 is the minimum size and it can be allocated larger. This makes it a standard empty flex array. This was motivated by field-spanning write warnings during FPIN testing. https://lore.kernel.org/linux-nvme/20250709211919.49100-1-bgur...@redh

Re: [PATCH v2 1/1] scsi: qla2xxx: replace non-standard flexible array purex_item.iocb

2025-07-30 Thread Gustavo A. R. Silva
On 30/07/25 09:43, Bryan Gurney wrote: Hi Gustavo, Yes, it passes. When I test this on top of the NVMe FPIN link integrity v9 patchset, I only see the "kernel: qla2xxx... : FPIN ELS" event. Tested-by: Bryan Gurney Awesome. :) Thanks! -Gustavo Thanks, Bryan On Tue, Jul 29, 2025 at

Re: [PATCH v3 02/15] pinctrl: ingenic: use struct pinfunction instead of struct function_desc

2025-07-30 Thread Paul Cercueil
Hi Bartosz, Le jeudi 24 juillet 2025 à 11:24 +0200, Bartosz Golaszewski a écrit : > From: Bartosz Golaszewski > > struct function_desc is a wrapper around struct pinfunction with an > additional void *data pointer. This driver doesn't use the data > pointer. > We're also working towards reducing

Re: [PATCH v3 09/15] pinctrl: constify pinmux_generic_get_function()

2025-07-30 Thread Geert Uytterhoeven
On Thu, 24 Jul 2025 at 11:24, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > With all users of struct function_desc limited to only accessing it using > the dedicated function and never modifying it, we can now constify the > return value of pinmux_generic_get_function() treewide. > >

Re: [PATCH v5 4/4] i3c: master: Add basic driver for the Renesas I3C controller

2025-07-30 Thread Wolfram Sang
> Why not use readl() and writel() directly? > To make it easier to add debug prints during initial development? Yes. And ultimately, there is a patch in the works converting the driver to MMIO regmap to get rid of _all_ the helpers. I couldn't make this in time for the 6.17 mergewindow, though,

Re: [PATCH v3 12/15] pinctrl: allow to mark pin functions as requestable GPIOs

2025-07-30 Thread Bartosz Golaszewski
On Wed, Jul 30, 2025 at 3:30 PM Andy Shevchenko wrote: > > On Wed, Jul 30, 2025 at 2:53 PM Bartosz Golaszewski wrote: > > On Wed, Jul 30, 2025 at 2:50 PM Andy Shevchenko > > wrote: > > > On Wed, Jul 30, 2025 at 11:54 AM Bartosz Golaszewski > > > wrote: > > > > On Thu, Jul 24, 2025 at 2:22 PM A

Re: [PATCH v5 4/4] i3c: master: Add basic driver for the Renesas I3C controller

2025-07-30 Thread Geert Uytterhoeven
Hi Wolfram, On Thu, 24 Jul 2025 at 11:41, Wolfram Sang wrote: > Add a basic driver for the I3C controller found in Renesas RZ/G3S and > G3E SoCs. Support I3C pure busses (tested with two targets) and mixed > busses (two I3C devices plus various I2C targets). DAA and communication > with temperatu

Re: [RFC][PATCH v2 16/29] mm/show_mem: Annotate static information into Kmemdump

2025-07-30 Thread David Hildenbrand
On 30.07.25 16:04, Eugen Hristev wrote: On 7/30/25 16:55, David Hildenbrand wrote: On 24.07.25 15:54, Eugen Hristev wrote: Annotate vital static information into kmemdump: - _totalram_pages Information on these variables is stored into dedicated kmemdump section. Signed-off-by: Eugen Hri

Re: [RFC][PATCH v2 22/29] mm/numa: Register information into Kmemdump

2025-07-30 Thread David Hildenbrand
On 30.07.25 15:57, Eugen Hristev wrote: Hello, On 7/30/25 16:52, David Hildenbrand wrote: On 24.07.25 15:55, Eugen Hristev wrote: Annotate vital static information into kmemdump: - node_data Information on these variables is stored into dedicated kmemdump section. Register dynamic informa

Re: [RFC][PATCH v2 16/29] mm/show_mem: Annotate static information into Kmemdump

2025-07-30 Thread Eugen Hristev
On 7/30/25 16:55, David Hildenbrand wrote: > On 24.07.25 15:54, Eugen Hristev wrote: >> Annotate vital static information into kmemdump: >> - _totalram_pages >> >> Information on these variables is stored into dedicated kmemdump section. >> >> Signed-off-by: Eugen Hristev >> --- >> mm/show_

Re: [PATCH 2/3] ext4: use memcpy() instead of strcpy()

2025-07-30 Thread Andy Shevchenko
On Sat, Jul 12, 2025 at 02:12:48PM -0400, Theodore Ts'o wrote: > The strcpy() function is considered dangerous and vil by people > who are using sophisticated code analysis tools such as "grep". This > is true even when a quick inspection would show that the source is a > constant string ("."

Re: [PATCH 3/3] ext4: refactor the inline directory conversion and new directory codepaths

2025-07-30 Thread Andy Shevchenko
On Mon, Jul 21, 2025 at 04:15:59PM -0700, Eric Biggers wrote: > On Sun, Jul 13, 2025 at 05:12:55AM +0800, kernel test robot wrote: > > All warnings (new ones prefixed by >>): > > > >fs/ext4/namei.c: In function 'ext4_init_new_dir': > > >> fs/ext4/namei.c:2968:34: warning: variable 'de' set but

Re: [RFC][PATCH v2 22/29] mm/numa: Register information into Kmemdump

2025-07-30 Thread Eugen Hristev
Hello, On 7/30/25 16:52, David Hildenbrand wrote: > On 24.07.25 15:55, Eugen Hristev wrote: >> Annotate vital static information into kmemdump: >> - node_data >> >> Information on these variables is stored into dedicated kmemdump section. >> >> Register dynamic information into kmemdump: >> -

Re: [RFC][PATCH v2 16/29] mm/show_mem: Annotate static information into Kmemdump

2025-07-30 Thread David Hildenbrand
On 24.07.25 15:54, Eugen Hristev wrote: Annotate vital static information into kmemdump: - _totalram_pages Information on these variables is stored into dedicated kmemdump section. Signed-off-by: Eugen Hristev --- mm/show_mem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/show

Re: [RFC][PATCH v2 22/29] mm/numa: Register information into Kmemdump

2025-07-30 Thread David Hildenbrand
On 24.07.25 15:55, Eugen Hristev wrote: Annotate vital static information into kmemdump: - node_data Information on these variables is stored into dedicated kmemdump section. Register dynamic information into kmemdump: - dynamic node data for each node This information is being allocated f

Re: [PATCH v3 12/15] pinctrl: allow to mark pin functions as requestable GPIOs

2025-07-30 Thread Andy Shevchenko
On Wed, Jul 30, 2025 at 2:53 PM Bartosz Golaszewski wrote: > On Wed, Jul 30, 2025 at 2:50 PM Andy Shevchenko > wrote: > > On Wed, Jul 30, 2025 at 11:54 AM Bartosz Golaszewski wrote: > > > On Thu, Jul 24, 2025 at 2:22 PM Andy Shevchenko > > > wrote: > > > > > > > > > struct pinfunction { > > >

Re: [PATCH v3 12/15] pinctrl: allow to mark pin functions as requestable GPIOs

2025-07-30 Thread Bartosz Golaszewski
On Wed, Jul 30, 2025 at 2:50 PM Andy Shevchenko wrote: > > On Wed, Jul 30, 2025 at 11:54 AM Bartosz Golaszewski wrote: > > > > On Thu, Jul 24, 2025 at 2:22 PM Andy Shevchenko > > wrote: > > > > > > > struct pinfunction { > > > > const char *name; > > > > const char * const *grou

Re: [PATCH v3 12/15] pinctrl: allow to mark pin functions as requestable GPIOs

2025-07-30 Thread Andy Shevchenko
On Wed, Jul 30, 2025 at 2:49 PM Andy Shevchenko wrote: > On Wed, Jul 30, 2025 at 11:54 AM Bartosz Golaszewski wrote: > > On Thu, Jul 24, 2025 at 2:22 PM Andy Shevchenko > > wrote: > > > > > > > struct pinfunction { > > > > const char *name; > > > > const char * const *groups; >

Re: [PATCH v3 12/15] pinctrl: allow to mark pin functions as requestable GPIOs

2025-07-30 Thread Andy Shevchenko
On Wed, Jul 30, 2025 at 11:54 AM Bartosz Golaszewski wrote: > > On Thu, Jul 24, 2025 at 2:22 PM Andy Shevchenko > wrote: > > > > > struct pinfunction { > > > const char *name; > > > const char * const *groups; > > > size_t ngroups; > > > + unsigned long flags; > > >

Re: [PATCH v3 12/15] pinctrl: allow to mark pin functions as requestable GPIOs

2025-07-30 Thread Bartosz Golaszewski
On Thu, Jul 24, 2025 at 2:22 PM Andy Shevchenko wrote: > > > struct pinfunction { > > const char *name; > > const char * const *groups; > > size_t ngroups; > > + unsigned long flags; > > Not sure we need this. If the function is GPIO, pin control already > knows abou