Re: [PATCH v5] hwmon: (pmbus/tps53679) Add support for TPS53685

2025-03-14 Thread Guenter Roeck
On 3/13/25 20:30, Chiang Brian wrote: The TPS53685 is a fully AMD SVI3 compliant step down controller with trans-inductor voltage regulator (TLVR) topology support, dual channels, built-in non-volatile memory (NVM), PMBus interface, and full compatible with TI NexFET smart power stages. Add suppo

[PATCH][next] misc: bcm-vk: avoid -Wflex-array-member-not-at-end warning

2025-03-14 Thread Gustavo A. R. Silva
Fix the following warning by removing unused flex-array member `data` in `struct bcm_vk_peer_log`: drivers/misc/bcm-vk/bcm_vk.h:415:32: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] Signed-off-by: Gustavo A. R. Silv

Re: [PATCH v4 4/6] mfd: max77759: add Maxim MAX77759 core mfd driver

2025-03-14 Thread André Draszik
Hi Lee, Thanks for your review! On Fri, 2025-03-14 at 12:31 +, Lee Jones wrote: > On Wed, 12 Mar 2025, André Draszik wrote: > > > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > > Port Controll

[PATCH 3/4] ASoC: Intel: max98373: move devm_kzalloc(..., size * n, ...) to devm_kcalloc

2025-03-14 Thread Ethan Carter Edwards
Open coded arithmetic in allocator arguments is discouraged. Helper functions like kcalloc or, in this case, devm_kcalloc are preferred. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments Signed-off-by: Ethan Carter Edwards --- sou

[PATCH 2/4] ASoC: Intel: ssm4567: move devm_kzalloc(..., size * n, ...) to devm_kcalloc

2025-03-14 Thread Ethan Carter Edwards
Open coded arithmetic in allocator arguments is discouraged. Helper functions like kcalloc or, in this case, devm_kcalloc are preferred. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments Signed-off-by: Ethan Carter Edwards --- sou

[PATCH 1/4] ASoC: Intel: avs: move devm_kzalloc(..., size * n, ...) to devm_kcalloc

2025-03-14 Thread Ethan Carter Edwards
Open coded arithmetic in allocator arguments is discouraged. Helper functions like kcalloc or, in this case, devm_kcalloc are preferred. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments Signed-off-by: Ethan Carter Edwards --- sou

[PATCH 0/4] ASoC: Intel: avs: move devm_kzalloc(..., size * n, ...) to devm_kcalloc

2025-03-14 Thread Ethan Carter Edwards
| 2 +- sound/soc/intel/avs/pcm.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) --- base-commit: da920b7df701770e006928053672147075587fb2 change-id: 20250314-sound-avs-kcalloc-91cedbc47074 Best regards, -- Ethan Carter Edwards

Re: [PATCH v2] scsi: pm80xx: Use C String API for string comparisons

2025-03-14 Thread David Laight
On Wed, 12 Mar 2025 13:05:36 -0700 Kees Cook wrote: > When a character array without a terminating NUL character has a static > initializer, GCC 15's -Wunterminated-string-initialization will only > warn if the array lacks the "nonstring" attribute[1]. There is no reason > for the command lookup

Re: [PATCH v4 4/6] mfd: max77759: add Maxim MAX77759 core mfd driver

2025-03-14 Thread Lee Jones
On Wed, 12 Mar 2025, André Draszik wrote: > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > Port Controller (TCPC), NVMEM, and a GPIO expander. > > Fuel Gauge and TCPC have separate and independent I2

Re: [PATCH][next] rtc: Avoid a couple of -Wflex-array-member-not-at-end warnings

2025-03-14 Thread Tzung-Bi Shih
On Fri, Mar 14, 2025 at 11:14:54AM +1030, Gustavo A. R. Silva wrote: > static int cros_ec_rtc_get(struct cros_ec_device *cros_ec, u32 command, > u32 *response) > { > + DEFINE_RAW_FLEX(struct cros_ec_command, msg, data, > + sizeof(struct ec_response

Re: [PATCH] mseal sysmap: add arch-support txt

2025-03-14 Thread Geert Uytterhoeven
Hi Jeff, On Thu, 13 Mar 2025 at 23:26, Jeff Xu wrote: > On Wed, Mar 12, 2025 at 10:21 PM Lorenzo Stoakes > wrote: > > On Thu, Mar 13, 2025 at 12:06:23AM +, jef...@chromium.org wrote: > > > From: Jeff Xu > > > Add Documentation/features/core/mseal_sys_mappings/arch-support.txt > > > > > > Si

Re: [PATCH] iio: magnetometer: ak8974: Add __nonstring annotations for unterminated strings

2025-03-14 Thread Linus Walleij
On Mon, Mar 10, 2025 at 11:23 PM Kees Cook wrote: > When a character array without a terminating NUL character has a static > initializer, GCC 15's -Wunterminated-string-initialization will only > warn if the array lacks the "nonstring" attribute[1]. Mark the arrays > with __nonstring to and corr

Re: [PATCH v2][next] rtc: Avoid a couple of -Wflex-array-member-not-at-end warnings

2025-03-14 Thread Tzung-Bi Shih
On Fri, Mar 14, 2025 at 07:00:54PM +1030, Gustavo A. R. Silva wrote: > Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of > a flexible structure where the size of the flexible-array member > is known at compile-time, and refactor the rest of the code, > accordingly. > > So, with thes

Re: [PATCH][next] rtc: Avoid a couple of -Wflex-array-member-not-at-end warnings

2025-03-14 Thread Gustavo A. R. Silva
Same here, how about: ((struct ec_response_rtc *)msg->data)->time = param; Yeah, let's go with that then :) https://lore.kernel.org/linux-hardening/Z9PpPg06OK8ghNvm@kspp/ Thanks! -- Gustavo

[PATCH v2][next] rtc: Avoid a couple of -Wflex-array-member-not-at-end warnings

2025-03-14 Thread Gustavo A. R. Silva
Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code, accordingly. So, with these changes, fix the following warning: drivers/rtc/rtc-cros-ec.c:62:40: warning:

Re: [PATCH v2 2/2] arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo

2025-03-14 Thread Gabriel Gonzales
On 3/8/25 23:11, Konrad Dybcio wrote: > > +&hsusb_phy1 { > > +    vdd-supply = <&vreg_l7a>; > > +    vdda-pll-supply = <&vreg_l10a>; > > +    vdda-phy-dpdm-supply = <&vreg_l15a>; >> +    status = "okay"; > Please add a before 'status', file-wide 'a-status'? [...] > > +&tlmm { > > +    gpio-res