Re: [PATCH v2 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

2025-02-27 Thread Linus Walleij
Hi André, thanks for your patch! mostly looks fine, given the MFD design is accepted. Nitpicks below: On Wed, Feb 26, 2025 at 6:51 PM André Draszik wrote: > +static irqreturn_t max77759_gpio_irqhandler(int irq, void *data) > +{ > + int handled = 0; bool handled = false; (...) > +

Re: [PATCH v3][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

2025-02-27 Thread Gustavo A. R. Silva
This patch was applied to netdev/net-next.git (main) Awesome. :) Thank you, guys. -- Gustavo

Re: [PATCH v3][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

2025-02-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 26 Feb 2025 13:47:32 +1030 you wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > So, in this particular case, we create a new `struct mlx

Re: your mail

2025-02-27 Thread Jeff Xu
Hi Lorenzo, On Tue, Feb 25, 2025, 9:43 PM Lorenzo Stoakes > > > > 2. Tests - could you please add some tests to assert that mremap() fails > > >for VDSO for instance? You've edited an existing test for VDSO in x86 > > > to > > >skip the test should this be enabled, but this is not the sam

Re: [PATCH v7 4/7] mseal, system mappings: enable arm64

2025-02-27 Thread Jeff Xu
On Wed, Feb 26, 2025 at 9:43 AM Lorenzo Stoakes wrote: > > On Wed, Feb 26, 2025 at 09:17:10AM -0800, Jeff Xu wrote: > > On Wed, Feb 26, 2025 at 9:12 AM Liam R. Howlett > > wrote: > > > > > > * Lorenzo Stoakes [250226 00:26]: > > > > On Tue, Feb 25, 2025 at 02:26:50PM -0800, Jeff Xu wrote: > > >

Re: [PATCH v7 1/7] mseal, system mappings: kernel config and header change

2025-02-27 Thread Jeff Xu
On Tue, Feb 25, 2025 at 10:04 PM Lorenzo Stoakes wrote: > > On Tue, Feb 25, 2025 at 05:33:24PM -0800, Jeff Xu wrote: > > On Mon, Feb 24, 2025 at 10:05 PM Lorenzo Stoakes > > wrote: > > > > +config ARCH_HAS_MSEAL_SYSTEM_MAPPINGS > > > > + bool > > > > + help > > > > + Control MSEAL_S

Re: [PATCH v7 0/7] mseal system mappings

2025-02-27 Thread Jeff Xu
On Tue, Feb 25, 2025 at 10:01 PM Lorenzo Stoakes wrote: > > On Tue, Feb 25, 2025 at 04:17:01PM -0800, Jeff Xu wrote: > > On Tue, Feb 25, 2025 at 2:32 AM Lorenzo Stoakes > > wrote: > > > > > > BTW can we please drop the 'mseal, system mappings' prefixes on this > > > series, it's really weird and

Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping

2025-02-27 Thread Jeff Xu
On Wed, Feb 26, 2025 at 10:25 AM Lorenzo Stoakes wrote: > > On Wed, Feb 26, 2025 at 07:20:50PM +0100, Oleg Nesterov wrote: > > On 02/26, Lorenzo Stoakes wrote: > > > > > > Like I said, Jeff opposes the change. I disagree with him, and agree with > > > you, > > > because this is very silly. > > >

Re: [PATCH] hwmon: (pmbus/core) Replace deprecated strncpy() with strscpy()

2025-02-27 Thread Guenter Roeck
On 2/27/25 09:39, Thorsten Blum wrote: strncpy() is deprecated for NUL-terminated destination buffers; use strscpy() instead. Compile-tested only. Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Thorsten Blum --- drivers/hwmon/pmbus/pmbus_core

Re: [PATCH v3][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

2025-02-27 Thread Saeed Mahameed
On 27 Feb 12:06, Gustavo A. R. Silva wrote: -struct mlx5e_umr_wqe { +struct mlx5e_umr_wqe_hdr { struct mlx5_wqe_ctrl_seg   ctrl; struct mlx5_wqe_umr_ctrl_seg   uctrl; struct mlx5_mkey_seg   mkc; +}; + +struct mlx5e_umr_wqe { +    struct mlx5e_umr_wqe_hdr hdr; You miss

Re: [PATCH v3][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

2025-02-27 Thread Saeed Mahameed
On 26 Feb 17:25, Jakub Kicinski wrote: On Wed, 26 Feb 2025 10:49:35 -0800 Saeed Mahameed wrote: On 26 Feb 13:47, Gustavo A. R. Silva wrote: >-struct mlx5e_umr_wqe { >+struct mlx5e_umr_wqe_hdr { >struct mlx5_wqe_ctrl_seg ctrl; >struct mlx5_wqe_umr_ctrl_seg uctrl; >struct mlx5_

Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping

2025-02-27 Thread Jeff Xu
Hi Oleg On Wed, Feb 26, 2025 at 10:21 AM Oleg Nesterov wrote: > > On 02/26, Lorenzo Stoakes wrote: > > > > Like I said, Jeff opposes the change. I disagree with him, and agree with > > you, > > because this is very silly. > > > > But I don't want to hold up this series with that discussion (this

Re: [PATCH v7 3/7] mseal, system mappings: enable x86-64

2025-02-27 Thread Jeff Xu
Hi Thomas On Tue, Feb 25, 2025 at 11:35 PM Thomas Weißschuh wrote: > > On Tue, Feb 25, 2025 at 04:48:47PM -0800, Jeff Xu wrote: > > On Tue, Feb 25, 2025 at 12:08 AM Thomas Weißschuh > > wrote: > > > On Mon, Feb 24, 2025 at 10:52:42PM +, jef...@chromium.org wrote: > > > > From: Jeff Xu > > >

[PATCH] hwmon: (pmbus/core) Replace deprecated strncpy() with strscpy()

2025-02-27 Thread Thorsten Blum
strncpy() is deprecated for NUL-terminated destination buffers; use strscpy() instead. Compile-tested only. Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Thorsten Blum --- drivers/hwmon/pmbus/pmbus_core.c | 3 +-- 1 file changed, 1 insertion(+)

Re: [PATCH v2 3/6] dt-bindings: mfd: add max77759 binding

2025-02-27 Thread André Draszik
On Thu, 2025-02-27 at 07:04 -0600, Rob Herring wrote: > On Wed, Feb 26, 2025 at 05:51:22PM +, André Draszik wrote: > > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > > Port Controller (TCPC), NVM

Re: [PATCH v2 2/6] dt-bindings: nvmem: add max77759 binding

2025-02-27 Thread Rob Herring (Arm)
On Wed, 26 Feb 2025 17:51:21 +, André Draszik wrote: > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > Port Controller (TCPC), NVMEM, and a GPIO expander. > > This describes its storage module (N

Re: [PATCH v2 3/6] dt-bindings: mfd: add max77759 binding

2025-02-27 Thread Rob Herring
On Wed, Feb 26, 2025 at 05:51:22PM +, André Draszik wrote: > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > Port Controller (TCPC), NVMEM, and a GPIO expander. > > This describes the top-level dev

Re: [PATCH v2 1/6] dt-bindings: gpio: add max77759 binding

2025-02-27 Thread Rob Herring (Arm)
On Wed, 26 Feb 2025 17:51:20 +, André Draszik wrote: > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > Port Controller (TCPC), NVMEM, and a GPIO expander. > > This describes its GPIO module. > >

Re: [PATCH v2 1/6] dt-bindings: gpio: add max77759 binding

2025-02-27 Thread André Draszik
On Thu, 2025-02-27 at 06:51 -0600, Rob Herring wrote: > On Thu, Feb 27, 2025 at 11:19:55AM +, André Draszik wrote: > > > The error is because the binding's 'description:' references the > > mfd binding using the complete path and the mfd binding is added > > in a later patch only in this versi

Re: [PATCH v2 1/6] dt-bindings: gpio: add max77759 binding

2025-02-27 Thread Rob Herring
On Thu, Feb 27, 2025 at 11:19:55AM +, André Draszik wrote: > On Wed, 2025-02-26 at 14:30 -0600, Rob Herring (Arm) wrote: > > > > On Wed, 26 Feb 2025 17:51:20 +, André Draszik wrote: > > > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > > > includes Battery Charger,

Re: [PATCH v2 1/6] dt-bindings: gpio: add max77759 binding

2025-02-27 Thread André Draszik
On Wed, 2025-02-26 at 14:30 -0600, Rob Herring (Arm) wrote: > > On Wed, 26 Feb 2025 17:51:20 +, André Draszik wrote: > > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > > Port Controller (TCPC),

Re: [PATCH] MIPS: Loongson2ef: Replace deprecated strncpy() with strscpy()

2025-02-27 Thread Thomas Bogendoerfer
On Mon, Feb 24, 2025 at 10:54:50PM +0100, Thorsten Blum wrote: > strncpy() is deprecated for NUL-terminated destination buffers. Use > strscpy() instead and remove the manual NUL-termination. > > Compile-tested only. > > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@vger.ker