Re: [PATCH v2 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

2024-10-30 Thread Mithil Bavishi
> this has to be system-power-controller; I am so sorry for the mess up, I was on the wrong branch which is almost the same as pmOS but a bit older, hence the entire mess up. I'll run a quick diff from pmOS and this patch and fix them accordingly. > There is still a lot other stuff to fix here

Re: [PATCH v2 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

2024-10-30 Thread Andreas Kemnade
Hi Mithil, Am Wed, 30 Oct 2024 21:12:11 + schrieb Mithil Bavishi : > + twl: twl@48 { > + reg = <0x48>; > + #clock-cells = <1>; > + > + pinctrl-names = "default"; > + pinctrl-0 = < > + &twl6030_pins > +

[PATCH v2 4/6] arm/dts: Add initial support for Galaxy Tab 2 7.0

2024-10-30 Thread Mithil Bavishi
Create a device tree for the 3 inch variants (P3100, P3110, P3113) Signed-off-by: Mithil Bavishi --- arch/arm/boot/dts/ti/omap/Makefile| 1 + .../dts/ti/omap/omap4-samsung-espresso7.dts | 70 +++ 2 files changed, 71 insertions(+) create mode 100644 arch/arm/boot/d

[PATCH v2 0/6] Initial support for Samsung Galaxy Tab 2 series

2024-10-30 Thread Mithil Bavishi
This series adds initial support for the Samsung Galaxy Tab 2 (samsung-espresso*) series of devices. It adds support for 6 variants (P3100, P3110, P3113, P5100, P5110, P5113). Downstream categorised them based on 3G and WiFi, but since they use different panel, touch controllers, batteries, I decid

[PATCH v2 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

2024-10-30 Thread Mithil Bavishi
Create common device tree for Samsung Espresso series devices Differentiate based on screen sizes, panels, touch controllers, and batteries Signed-off-by: Mithil Bavishi --- .../omap/omap4-samsung-espresso-common.dtsi | 690 ++ 1 file changed, 690 insertions(+) create mode 10

[PATCH v2 5/6] dt-bindings: omap: Add Samaung Galaxy Tab 2 10.1

2024-10-30 Thread Mithil Bavishi
Add samsung-espresso7 codename for the 7 inch variant Signed-off-by: Mithil Bavishi --- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml

[PATCH v2 6/6] arm/dts: Add initial support for Galaxy Tab 2 10.1

2024-10-30 Thread Mithil Bavishi
Create a device tree for the 10 inch variants (P5100, P5110, P5113) Signed-off-by: Mithil Bavishi --- arch/arm/boot/dts/ti/omap/Makefile| 1 + .../dts/ti/omap/omap4-samsung-espresso10.dts | 102 ++ 2 files changed, 103 insertions(+) create mode 100644 arch/arm/boo

[PATCH v2 3/6] dt-bindings: omap: Add Samaung Galaxy Tab 2 7.0

2024-10-30 Thread Mithil Bavishi
Add samsung-espresso7 codename for the 7 inch variant Signed-off-by: Mithil Bavishi --- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml

[PATCH v2 1/6] ARM: dts: twl6032: Add DTS file for TWL6032 PMIC

2024-10-30 Thread Mithil Bavishi
Add a dedicated DTS file for the TWL6032 PMIC (Phoenix Lite). Already has driver support with TWL6030 (Phoenix) since both of them are so similar, some nodes can be reused from TWL6030 as well. This can be included in the board files like twl6030. Example: ... &i2c1 { twl: twl@48 { reg

Re: [PATCH v1 4/6] arm/dts: Add initial support for Galaxy Tab 2 7.0

2024-10-30 Thread Andreas Kemnade
Am Wed, 30 Oct 2024 19:41:34 + schrieb Mithil Bavishi : > Create a device tree for the 3 inch variants (P3100, P3110, P3113) > > Signed-off-by: Mithil Bavishi > --- > arch/arm/boot/dts/ti/omap/Makefile| 1 + > .../dts/ti/omap/omap4-samsung-espresso7.dts | 70 > +++

Re: [PATCH v1 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

2024-10-30 Thread Andreas Kemnade
Hi, a quick first pass of review. Am Wed, 30 Oct 2024 19:41:32 + schrieb Mithil Bavishi : > Create common device tree for Samsung Espresso series devices > > Differentiate based on screen sizes, panels, touch controllers, > and batteries > > Signed-off-by: Mithil Bavishi > --- [...] > +

[PATCH v1 5/6] dt-bindings: omap: Add Samaung Galaxy Tab 2 10.1

2024-10-30 Thread Mithil Bavishi
Add samsung-espresso7 codename for the 7 inch variant Signed-off-by: Mithil Bavishi --- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml

[PATCH v1 6/6] arm/dts: Add initial support for Galaxy Tab 2 10.1

2024-10-30 Thread Mithil Bavishi
Create a device tree for the 10 inch variants (P5100, P5110, P5113) Signed-off-by: Mithil Bavishi --- arch/arm/boot/dts/ti/omap/Makefile| 1 + .../dts/ti/omap/omap4-samsung-espresso10.dts | 102 ++ 2 files changed, 103 insertions(+) create mode 100644 arch/arm/boo

[PATCH v1 4/6] arm/dts: Add initial support for Galaxy Tab 2 7.0

2024-10-30 Thread Mithil Bavishi
Create a device tree for the 3 inch variants (P3100, P3110, P3113) Signed-off-by: Mithil Bavishi --- arch/arm/boot/dts/ti/omap/Makefile| 1 + .../dts/ti/omap/omap4-samsung-espresso7.dts | 70 +++ 2 files changed, 71 insertions(+) create mode 100644 arch/arm/boot/d

[PATCH v1 3/6] dt-bindings: omap: Add Samaung Galaxy Tab 2 7.0

2024-10-30 Thread Mithil Bavishi
Add samsung-espresso7 codename for the 7 inch variant Signed-off-by: Mithil Bavishi --- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml

[PATCH v1 1/6] ARM: dts: twl6032: Add DTS file for TWL6032 PMIC

2024-10-30 Thread Mithil Bavishi
Add a dedicated DTS file for the TWL6032 PMIC (Phoenix Lite). Already has driver support with TWL6030 (Phoenix) since both of them are so similar, some nodes can be reused from TWL6030 as well. This can be included in the board files like twl6030. Example: ... &i2c1 { twl: twl@48 { reg

[PATCH v1 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

2024-10-30 Thread Mithil Bavishi
Create common device tree for Samsung Espresso series devices Differentiate based on screen sizes, panels, touch controllers, and batteries Signed-off-by: Mithil Bavishi --- .../omap/omap4-samsung-espresso-common.dtsi | 693 ++ 1 file changed, 693 insertions(+) create mode 10

[PATCH v1 0/6] Initial support for Samsung Galaxy Tab 2 series

2024-10-30 Thread Mithil Bavishi
This series adds initial support for the Samsung Galaxy Tab 2 (samsung-espresso*) series of devices. It adds support for 6 variants (P3100, P3110, P3113, P5100, P5110, P5113). Downstream categorised them based on 3G and WiFi, but since they use different panel, touch controllers, batteries, I decid

Re: [weiny2:dcd-v4-2024-10-29 9/28] drivers/cxl/cxlmem.h:755:35: error: use of undeclared identifier 'regions_retunred'

2024-10-30 Thread Ira Weiny
Nathan Chancellor wrote: > On Wed, Oct 30, 2024 at 09:50:42AM -0500, Ira Weiny wrote: > > [snip] > > > > > >> drivers/cxl/cxlmem.h:755:35: error: use of undeclared identifier > > > >> 'regions_retunred' > > > 755 | } __packed region[] __counted_by(regions_retunred); > > > |

Re: [weiny2:dcd-v4-2024-10-29 9/28] drivers/cxl/cxlmem.h:755:35: error: use of undeclared identifier 'regions_retunred'

2024-10-30 Thread Nathan Chancellor
On Wed, Oct 30, 2024 at 09:50:42AM -0500, Ira Weiny wrote: > [snip] > > > >> drivers/cxl/cxlmem.h:755:35: error: use of undeclared identifier > > >> 'regions_retunred' > > 755 | } __packed region[] __counted_by(regions_retunred); > > |

Re: [PATCH v2][next] mips: sgi-ip22: Replace "s[n]?printf" with sysfs_emit in sysfs callbacks

2024-10-30 Thread Thomas Bogendoerfer
On Thu, Oct 17, 2024 at 10:13:42PM +1300, Paulo Miguel Almeida wrote: > Replace open-coded pieces with sysfs_emit() helper in sysfs .show() > callbacks. > > Signed-off-by: Paulo Miguel Almeida > --- > Changelog: > - v2: amend commit message (Req: Maciej W. Rozycki) > - v1: https://lore.kernel.org