Re: [PATCH] coredump: Do not lock during 'comm' reporting

2024-09-28 Thread Kees Cook
On Sat, Sep 28, 2024 at 02:46:36PM -0700, Andrew Morton wrote: > On Sat, 28 Sep 2024 14:39:45 -0700 Kees Cook wrote: > > > On Sat, Sep 28, 2024 at 02:35:32PM -0700, Andrew Morton wrote: > > > On Sat, 28 Sep 2024 14:08:31 -0700 Kees Cook wrote: > > > > > > > The 'comm' member will always be NUL

Re: [PATCH] coredump: Do not lock during 'comm' reporting

2024-09-28 Thread Andrew Morton
On Sat, 28 Sep 2024 14:39:45 -0700 Kees Cook wrote: > On Sat, Sep 28, 2024 at 02:35:32PM -0700, Andrew Morton wrote: > > On Sat, 28 Sep 2024 14:08:31 -0700 Kees Cook wrote: > > > > > The 'comm' member will always be NUL terminated, > > > > Why is this? I thought this is only true if the calle

Re: [PATCH] coredump: Do not lock during 'comm' reporting

2024-09-28 Thread Kees Cook
On Sat, Sep 28, 2024 at 02:35:32PM -0700, Andrew Morton wrote: > On Sat, 28 Sep 2024 14:08:31 -0700 Kees Cook wrote: > > > The 'comm' member will always be NUL terminated, > > Why is this? I thought this is only true if the caller holds task_lock()? Because it's always written with strscpy_pad

Re: [PATCH] coredump: Do not lock during 'comm' reporting

2024-09-28 Thread Andrew Morton
On Sat, 28 Sep 2024 14:08:31 -0700 Kees Cook wrote: > The 'comm' member will always be NUL terminated, Why is this? I thought this is only true if the caller holds task_lock()? > and this is not > fast-path, so we can just perform a direct memcpy during a coredump > instead of potentially dead

[PATCH] coredump: Do not lock during 'comm' reporting

2024-09-28 Thread Kees Cook
The 'comm' member will always be NUL terminated, and this is not fast-path, so we can just perform a direct memcpy during a coredump instead of potentially deadlocking while holding the task struct lock. Reported-by: Vegard Nossum Closes: https://lore.kernel.org/all/d122ece6-3606-49de-ae4d-8da88

Re: [PATCH] MAINTAINERS: Add security/Kconfig.hardening to hardening section

2024-09-28 Thread Kees Cook
On Sat, 28 Sep 2024 11:26:09 -0700, Nathan Chancellor wrote: > When running get_maintainer.pl on security/Kconfig.hardening, only the > security subsystem folks show up, even though they have never taken > patches to this file: > > $ scripts/get_maintainer.pl security/Kconfig.hardening > Paul

Re: [PATCH] hardening: Adjust dependencies in selection of MODVERSIONS

2024-09-28 Thread Kees Cook
On Sat, 28 Sep 2024 11:13:13 -0700, Nathan Chancellor wrote: > MODVERSIONS recently grew a dependency on !COMPILE_TEST so that Rust > could be more easily tested. However, this introduces a Kconfig warning > when building allmodconfig with a clang version that supports RANDSTRUCT > natively because

Re: [PATCH -next v3 00/10] coccinelle: Add some rules for string_chioces helpers.

2024-09-28 Thread Julia Lawall
On Wed, 11 Sep 2024, Hongbo Li wrote: > We found that many of the detection rules for helpers in > string_choices.h are missing. This series of patches is > intended to complete these rules. We have verified in the > latest kernel tree that these rules can detect many places > where the string

Re: [PATCH v1 1/1] mseal: update mseal.rst

2024-09-28 Thread Randy Dunlap
On 9/27/24 11:52 AM, jef...@chromium.org wrote: > From: Jeff Xu > > Update doc after in-loop change: mprotect/madvise can have > partially updated and munmap is atomic. > > Fix indentation and clarify some sections to improve readability. > > Signed-off-by: Jeff Xu > --- > Documentation/us

[PATCH] MAINTAINERS: Add security/Kconfig.hardening to hardening section

2024-09-28 Thread Nathan Chancellor
nel/configs/hardening.config F: lib/usercopy_kunit.c F: mm/usercopy.c +F: security/Kconfig.hardening K: \b(add|choose)_random_kstack_offset\b K: \b__check_(object_size|heap_object)\b K: \b__counted_by\b --- base-commit: c00ac1f9fd7bfe87ff17b7a85f23118f3a3f0af2 cha

[PATCH] hardening: Adjust dependencies in selection of MODVERSIONS

2024-09-28 Thread Nathan Chancellor
d --- base-commit: 3efc57369a0ce8f76bf0804f7e673982384e4ac9 change-id: 20240928-fix-randstruct-modversions-kconfig-warning-013be4a0f673 Best regards, -- Nathan Chancellor

Re: [PATCH v1 1/1] mseal: update mseal.rst

2024-09-28 Thread Pedro Falcato
On Fri, Sep 27, 2024 at 06:29:30PM GMT, Jeff Xu wrote: > Hi Pedro, > > On Fri, Sep 27, 2024 at 3:59 PM Pedro Falcato wrote: > > > + > > > + Blocked mm syscall: > > > + - munmap > > > + - mmap > > > + - mremap > > > + - mprotect and pkey_mprotect > > > + - some destruct