[linux-next:master] BUILD REGRESSION e31185ce00a96232308300008db193416ceb9769

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: e31185ce00a9623230838db193416ceb9769 Add linux-next specific files for 20240222 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/20240223.h9rfmyj4-...@intel.com https

Re: [PATCH v2 0/4] leaking_addresses: Provide mechanism to scan binary files

Hi Kees, On Thu, Feb 22, 2024 at 02:00:47PM -0800, Kees Cook wrote: > Hi, > > Since I was in this script for the binary file scanning, I did other > clean-ups and tweaked the MAINTAINERS file per Tycho's suggestion. Thanks, the whole series is: Reviewed-by: Tycho Andersen I also pinged Tobin

Re: [PATCH] leaking_addresses: Provide mechanism to scan binary files

On Thu, Feb 22, 2024 at 01:00:40PM -0800, Kees Cook wrote: > > This does bring up some interesting questions. From off-list > > discussions with Tobin, I believe he is not particularly interested in > > maintaining this script any more. I was never set up to do the PRs > > myself, I agreed to be a

RE: [PATCH v2] checkpatch: add check for snprintf to scnprintf

From: Justin Stitt > Sent: 21 February 2024 22:12 > > I am going to quote Lee Jones who has been doing some snprintf -> > scnprintf refactorings: > > "There is a general misunderstanding amongst engineers that > {v}snprintf() returns the length of the data *actually* encoded into the > destinatio

[PATCH] [RFC] iio: pressure: dlhl60d: Check mask_width for IRQs

Clang tripped over a FORTIFY warning in this code, and while it seems it may be a false positive in Clang due to loop unwinding, the code in question seems to make a lot of assumptions. Comments added, and the Clang warning[1] has been worked around by growing the array size. Also there was an unin

[PATCH v2 4/4] leaking_addresses: Provide mechanism to scan binary files

Introduce --kallsyms argument for scanning binary files for known symbol addresses. This would have found the exposure in /sys/kernel/notes: $ scripts/leaking_addresses.pl --kallsyms=<(sudo cat /proc/kallsyms) /sys/kernel/notes: hypercall_page @ 156 /sys/kernel/notes: xen_hypercall_set_trap_table

[PATCH v2 2/4] leaking_addresses: Use File::Temp for /tmp files

Instead of using a statically named path in /tmp, use File::Temp to create (and remove) the temporary file used for parsing /proc/config.gz. Signed-off-by: Kees Cook --- Cc: Tycho Andersen Cc: "Tobin C. Harding" Cc: linux-hardening@vger.kernel.org --- scripts/leaking_addresses.pl | 9 -

[PATCH v2 3/4] leaking_addresses: Ignore input device status lines

These are false positives from the input subsystem: /proc/bus/input/devices: B: KEY=40200 3803078f800d001 fedfffef fffe /sys/devices/platform/i8042/serio0/input/input1/uevent: KEY=40200 3803078f800d001 fedfffef fffe /sys/devices/platform/i8042/seri

[PATCH v2 0/4] leaking_addresses: Provide mechanism to scan binary files

Hi, Since I was in this script for the binary file scanning, I did other clean-ups and tweaked the MAINTAINERS file per Tycho's suggestion. Changes in v2: patches 1-3, move hex() after ^0 skip Prior v1: https://lore.kernel.org/linux-hardening/20240218173809.work.286-k...@kernel.org/ -Kees Kees

[PATCH v2 1/4] MAINTAINERS: Update LEAKING_ADDRESSES details

Tobin hasn't been involved lately, and I can step up to be a reviewer with Tycho. I'll carry changes via the hardening tree. Signed-off-by: Kees Cook --- Cc: Tycho Andersen Cc: Tobin C. Harding --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS

Re: [PATCH] leaking_addresses: Provide mechanism to scan binary files

On Thu, Feb 22, 2024 at 01:00:40PM -0800, Kees Cook wrote: > On Thu, Feb 22, 2024 at 08:24:02AM -0700, Tycho Andersen wrote: > > Hi Kees, > > > > On Sun, Feb 18, 2024 at 09:38:12AM -0800, Kees Cook wrote: > > > Introduce --kallsyms argument for scanning binary files for known symbol > > > addresse

Re: [PATCH] leaking_addresses: Provide mechanism to scan binary files

On Thu, Feb 22, 2024 at 08:24:02AM -0700, Tycho Andersen wrote: > Hi Kees, > > On Sun, Feb 18, 2024 at 09:38:12AM -0800, Kees Cook wrote: > > Introduce --kallsyms argument for scanning binary files for known symbol > > addresses. This would have found the exposure in /sys/kernel/notes: > > > > $

Re: [PATCH] PM: hibernate: Don't ignore return from set_memory_ro()

On Sun, Feb 18, 2024 at 10:07 AM Kees Cook wrote: > > On Sun, Feb 18, 2024 at 09:40:58AM +0100, Christophe Leroy wrote: > > set_memory_ro() and set_memory_rw() can fail, leaving memory > > unprotected. > > > > Take the returned value into account and abort in case of > > failure. > > > > Signed-of

[PATCH] pstore: inode: Only d_invalidate() is needed

Unloading a modular pstore backend with records in pstorefs would trigger the dput() double-drop warning: WARNING: CPU: 0 PID: 2569 at fs/dcache.c:762 dput.part.0+0x3f3/0x410 Using the combo of d_drop()/dput() (as mentioned in Documentation/filesystems/vfs.rst) isn't the right approach here, an

Re: [PATCH v4 0/3] Tegra30: add support for LG tegra based phones

On Wed Feb 14, 2024 at 10:11 AM CET, Svyatoslav Ryhel wrote: > Bring up Tegra 3 based LG phones Optimus 4X HD and Optimus Vu based > on LG X3 board. > > --- > Changes from v3: > - set max77663 ldo0 to be always on since it is required by the SOC > - adjusted bluetooth module comment > - added enabl

[PATCH] x86, relocs: Ignore relocations in .notes section

When building with CONFIG_XEN_PV=y, .text symbols are emitted into the .notes section so that Xen can find the "startup_xen" entry point. This information is used prior to booting the kernel, so relocations are not useful. In fact, performing relocations against the .notes section means that the KA

Re: [PATCH v1 1/1] kernel.h: Move lib/cmdline.c prototypes to string.h

On Wed, Oct 04, 2023 at 12:27:41PM +0300, Andy Shevchenko wrote: > On Wed, Oct 4, 2023 at 2:39 AM Kees Cook wrote: > > On Tue, Oct 03, 2023 at 04:01:42PM +0300, Andy Shevchenko wrote: > > > The lib/cmdline.c is basically a set of some small string parsers > > > which are wide used in the kernel. T

Re: [PATCH 6/9] fortify: Split reporting and avoid passing string pointer

On Thu, Feb 22, 2024 at 6:30 PM Kees Cook wrote: > On Thu, Feb 22, 2024 at 02:00:26PM +0100, Arnd Bergmann wrote: > > On Thu, Apr 6, 2023, at 13:19, kernel test robot wrote: > > > > > If you fix the issue, kindly add following tag where applicable > > > | Reported-by: kernel test robot > > > | Li

Re: [PATCH 6/9] fortify: Split reporting and avoid passing string pointer

On Thu, Feb 22, 2024 at 02:00:26PM +0100, Arnd Bergmann wrote: > On Thu, Apr 6, 2023, at 13:19, kernel test robot wrote: > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot > > | Link: > > https://lore.kernel.org/oe-kbuild-all/202304061930.4

Re: [PATCH] leaking_addresses: Provide mechanism to scan binary files

Hi Kees, On Sun, Feb 18, 2024 at 09:38:12AM -0800, Kees Cook wrote: > Introduce --kallsyms argument for scanning binary files for known symbol > addresses. This would have found the exposure in /sys/kernel/notes: > > $ scripts/leaking_addresses.pl --kallsyms=<(sudo cat /proc/kallsyms) > /sys/kern

Re: [PATCH 6/9] fortify: Split reporting and avoid passing string pointer

On Thu, Apr 6, 2023, at 13:19, kernel test robot wrote: > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > | Link: > https://lore.kernel.org/oe-kbuild-all/202304061930.4au0pasm-...@intel.com/ > > All errors (new ones prefixed by >>): > >>> ld.l

Re: [PATCH bpf-next 1/2] bpf: Take return from set_memory_ro() into account with bpf_prog_lock_ro()

Le 21/02/2024 à 18:30, Daniel Borkmann a écrit : > On 2/19/24 7:39 AM, Christophe Leroy wrote: >> >> >> Le 19/02/2024 à 02:40, Hengqi Chen a écrit : >>> [Vous ne recevez pas souvent de courriers de hengqi.c...@gmail.com. >>> Découvrez pourquoi ceci est important à >>> https://aka.ms/LearnAboutS