Re: micro-patch for setup-storage

2012-11-30 Diskussionsfäden Brian Kroth
Brian Paul Kroth 2012-08-20 10:37: Thomas Neumann 2012-06-25 23:10: [Sorry for this monologue, but I think I got it sorted out now.] It seems I got the conditional wrong here: if ( scalar(grep(m{^$cur$}, @pre_deps)) == 0 ) { next COMMAND; } If I change it into: if ( scalar(grep(m{^$cur$}

Re: micro-patch for setup-storage

2012-08-28 Diskussionsfäden Thomas Neumann
Thomas Lange wrote: > Why not use setup-storage without -X which prints all commands without > executin them? Okay, I tried running with '-X' now, but there's still a logical bug which makes it a bit less useful for automated testing[1]. After the commands have been executed there's a call to Fst

Re: micro-patch for setup-storage

2012-08-28 Diskussionsfäden Thomas Neumann
> Why not use setup-storage without -X which prints all commands without > executin them? Ah. Yes. Forgot about it since I started rewriting setup-storage so it doesn't need root-priviledges for a dry-run. (e.g. setup-storage without '-X' will still happily try to stop md devices and access the ra

Re: micro-patch for setup-storage

2012-08-28 Diskussionsfäden Thomas Lange
> On Mon, 27 Aug 2012 21:27:43 +0200, Thomas Neumann > said: > Turn > &FAI::execute_command($FAI::commands{$_}{cmd}); > into > print '[fake-mode] $FAI::commands{$_}{cmd} . "\n"; > That way you can see the list of commands and have a visual check on what > is s

Re: micro-patch for setup-storage

2012-08-27 Diskussionsfäden Thomas Neumann
Thomas Neumann wrote: > I extracted a commandlist from your pastebin. Seems like the failing > command is the first one. Would be interesting to know which exit code > has been signaled. Try modifying Exec.pm::execute_command() but you may > have more luck kludging some output handler into the ret

Re: micro-patch for setup-storage

2012-08-27 Diskussionsfäden Thomas Neumann
Hello Brian > With your patches, an initial install of the attached MD_RAID1 + LVM > disk_config works, but a subsequent preserve_reinstall (without initial > flag) fails with a non-zero return code from "Executing: mdadm --stop > --scan". Full output is attached. [...] > Might have something

Re: micro-patch for setup-storage

2012-08-27 Diskussionsfäden Thomas Neumann
Hello Brian Kroth wrote: >> @Brian: I successfully tested this patch with your disk config. However I >>had to remove 'preserve_reinstall:vg-local.hd' since setup-storage >>does not recognize this option. > Since when? It's still in the man page. That is/was a very useful > f

Re: micro-patch for setup-storage

2012-08-27 Diskussionsfäden Brian Kroth
Just now catching up on things ... Thomas Neumann 2012-08-22 19:18: Thomas Neumann wrote: I'm currently experimenting with this attached patch, which simply logs and ignores any 'self_cleared_[a-z.]' dependencies. This makes the resolver finish successfully, but afterwards there's this little

Re: micro-patch for setup-storage

2012-08-22 Diskussionsfäden Thilo Uttendorfer
Hi, On Wednesday 22 August 2012 at 18:23:06, Thomas Neumann wrote: > [...] > > I'm currently experimenting with this attached patch, which simply logs and > ignores any 'self_cleared_[a-z.]' dependencies. This makes the resolver > finish successfully, but afterwards there's this little gem: > > w

Re: micro-patch for setup-storage

2012-08-22 Diskussionsfäden Thomas Neumann
[I have written a different mail to Brian off-list in between.] Brian Kroth wrote: > I'm running into this issue too, but the patches didn't help. There's > also a Prototype mismatch error dumped out by perl, but that doesn't > seem to be related from my reading so far. Attached is some debug

Re: micro-patch for setup-storage

2012-08-20 Diskussionsfäden Thomas Neumann
hiya Brian Kroth wrote: > Let me know if you need any more details. I'll have a look into this. About the perl prototype error: Encountered the same one, but ignored it since it seemed to have no impact. bye thomas

Re: micro-patch for setup-storage

2012-06-25 Diskussionsfäden Thomas Neumann
[Sorry for this monologue, but I think I got it sorted out now.] It seems I got the conditional wrong here: if ( scalar(grep(m{^$cur$}, @pre_deps)) == 0 ) { next COMMAND; } If I change it into: if ( scalar(grep(m{^$cur$}, @pre_deps)) != 0 ) { next COMMAND; } Then I have a worki

Re: micro-patch for setup-storage

2012-06-25 Diskussionsfäden Thomas Neumann
Hello again Sending this mail was followed by a small moment of embarassment, when perl told me this code is not valid. But maybe it was buggy all along. rewriting if scalar(grep(m{^$cur$}, @pre_deps)) { next COMMAND; } as if ( scalar(grep(m{^$cur$}, @pre_deps)) == 0 ) { next COMMAND; }