Re: [f2fs-dev] [PATCH 06/10] hugetlbfs: Convert remove_inode_hugepages() to use filemap_get_folios()

2022-06-10 Thread Mike Kravetz
On 6/10/22 14:17, Matthew Wilcox wrote: > On Fri, Jun 10, 2022 at 05:52:05PM +0200, Sumanth Korikkar wrote: >> To reproduce: >> * clone libhugetlbfs: >> * Execute, PATH=$PATH:"obj64/" LD_LIBRARY_PATH=../obj64/ >> alloc-instantiate-race shared > > ... it's a lot harder to set up hugetlb than that

Re: [f2fs-dev] [PATCH 06/10] hugetlbfs: Convert remove_inode_hugepages() to use filemap_get_folios()

2022-06-10 Thread Matthew Wilcox
On Fri, Jun 10, 2022 at 05:52:05PM +0200, Sumanth Korikkar wrote: > To reproduce: > * clone libhugetlbfs: > * Execute, PATH=$PATH:"obj64/" LD_LIBRARY_PATH=../obj64/ > alloc-instantiate-race shared ... it's a lot harder to set up hugetlb than that ... anyway, i figured it out without being able t

Re: [f2fs-dev] [PATCH 06/10] hugetlbfs: Convert remove_inode_hugepages() to use filemap_get_folios()

2022-06-10 Thread Gerald Schaefer
On Fri, 10 Jun 2022 17:52:05 +0200 Sumanth Korikkar wrote: [...] > > * Bisected the crash to this commit. > > To reproduce: > * clone libhugetlbfs: > * Execute, PATH=$PATH:"obj64/" LD_LIBRARY_PATH=../obj64/ > alloc-instantiate-race shared > > Crashes on both s390 and x86. FWIW, not really

[f2fs-dev] [PATCH] f2fs: fix iostat related lock protection

2022-06-10 Thread Daeho Jeong
From: Daeho Jeong Made iostat related locks safe to be called from irq context again. Signed-off-by: Daeho Jeong --- fs/f2fs/iostat.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/fs/f2fs/iostat.c b/fs/f2fs/iostat.c index be599f31d3c4..d8

Re: [f2fs-dev] [PATCH 10/31] Verify structure sizes at compile time

2022-06-10 Thread Bart Van Assche
On 6/9/22 19:05, Peter Collingbourne wrote: On Thu, Apr 21, 2022 at 03:18:15PM -0700, Bart Van Assche wrote: +static_assert(sizeof(struct f2fs_dentry_block) == 4096, ""); I noticed that this static_assert fails when PAGE_SIZE is defined to a value other than 4096. I have to admit to being unf

Re: [f2fs-dev] [PATCH 06/10] hugetlbfs: Convert remove_inode_hugepages() to use filemap_get_folios()

2022-06-10 Thread Sumanth Korikkar
Hi, The kernel crashes with the following backtrace on linux-next: [ 203.304451] kernel BUG at fs/inode.c:612! [ 203.304466] invalid opcode: [#1] PREEMPT SMP PTI [ 203.305215] CPU: 0 PID: 868 Comm: alloc-instantia Not tainted 5.19.0-rc1-next-20220609 #256 [ 203.305563] Hardware name: QE

Re: [f2fs-dev] [PATCH] docs: filesystems: f2fs: fix description about compress ioctl

2022-06-10 Thread Chao Yu
On 2022/6/2 15:25, Chao Liu wrote: From: Chao Liu Since commit c61404153eb6 ("f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit"), we no longer use the IMMUTABLE bit to prevent writing data for compression. Let's correct the corresponding documentation. BTW, this patch fixes

Re: [f2fs-dev] [PATCH] f2fs: refine comments for inline flags

2022-06-10 Thread Chao Yu
On 2022/6/2 15:24, Chao Liu wrote: From: Chao Liu Currently, we use f2fs_has_inline_xattr() to check whether the inode can store inline xattr. However, it might be misinterpreted as the inode has at least one inline xattr. The same is true for f2fs_has_inline_data() and f2fs_has_inline_dentry(

Re: [f2fs-dev] [PATCH v2 03/19] fs: Add aops->migrate_folio

2022-06-10 Thread David Hildenbrand
On 09.06.22 16:35, Matthew Wilcox wrote: > On Thu, Jun 09, 2022 at 02:50:20PM +0200, David Hildenbrand wrote: >> On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: >>> diff --git a/Documentation/filesystems/locking.rst >>> b/Documentation/filesystems/locking.rst >>> index c0fe711f14d3..3d28b23676bd