Re: [PATCH 3/8] lockref: use bool for false/true returns

2025-03-18 Thread Mateusz Guzik
On Tue, Mar 18, 2025 at 4:25 PM Mateusz Guzik wrote: > > On Wed, Jan 15, 2025 at 10:46:39AM +0100, Christoph Hellwig wrote: > > Replace int used as bool with the actual bool type for return values that > > can only be true or false. > > > [snip] > > > -int

Re: [PATCH 3/8] lockref: use bool for false/true returns

2025-03-18 Thread Mateusz Guzik
On Wed, Jan 15, 2025 at 10:46:39AM +0100, Christoph Hellwig wrote: > Replace int used as bool with the actual bool type for return values that > can only be true or false. > [snip] > -int lockref_get_not_zero(struct lockref *lockref) > +bool lockref_get_not_zero(struct lockref *lockref) > { > -

Re: [PATCH 3/8] lockref: use bool for false/true returns

2025-03-19 Thread Mateusz Guzik
On Wed, Mar 19, 2025 at 7:29 AM Christoph Hellwig wrote: > > On Tue, Mar 18, 2025 at 04:51:27PM +0100, Mateusz Guzik wrote: > > fwiw I confirmed clang does *not* have the problem, I don't know about gcc > > 14. > > > > Maybe I'll get around to testi