[PATCH 6.10 258/375] vfs: Fix potential circular locking through setxattr() and removexattr()

2024-09-10 Thread Greg Kroah-Hartman
6.10-stable review patch. If anyone has any objections, please let me know. -- From: David Howells [ Upstream commit c3a5e3e872f3688ae0dc57bb78ca633921d96a91 ] When using cachefiles, lockdep may emit something similar to the circular locking dependency notice below. The probl

[PATCH 6.6 177/269] vfs: Fix potential circular locking through setxattr() and removexattr()

2024-09-10 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: David Howells [ Upstream commit c3a5e3e872f3688ae0dc57bb78ca633921d96a91 ] When using cachefiles, lockdep may emit something similar to the circular locking dependency notice below. The proble

Re: [PATCH 00/25] staging: erofs: introduce erofs file system

2018-07-28 Thread Greg Kroah-Hartman
On Thu, Jul 26, 2018 at 08:21:43PM +0800, Gao Xiang wrote: > Hi, > > This is actually the 2nd patchset of erofs file system, > the original patchset can be found at > > Link: https://marc.info/?l=linux-fsdevel&m=152776480425624 > > In order to keep up with the mainline linux-kernel changes and >

Re: [PATCH] Revert "staging: erofs: disable compiling temporarile"

2018-08-27 Thread Greg Kroah-Hartman
On Tue, Aug 28, 2018 at 11:39:48AM +0800, Gao Xiang wrote: > This reverts commit 156c3df8d4db4e693c062978186f44079413d74d. > > Since XArray and the new mount apis aren't merged in 4.19-rc1 > merge window, the BROKEN mark can be reverted directly without > any problems. > > Fixes: 156c3df8d4db ("s

Re: [PATCH] Revert "staging: erofs: disable compiling temporarile"

2018-08-28 Thread Greg Kroah-Hartman
On Tue, Aug 28, 2018 at 04:56:43PM +0800, Chao Yu wrote: > Hi Greg, > > On 2018/8/28 14:28, Gao Xiang wrote: > > Hi Greg, > > > > On 2018/8/28 13:44, Greg Kroah-Hartman wrote: > >> On Tue, Aug 28, 2018 at 11:39:48AM +0800, Gao Xi

Re: [PATCH] staging: erofs: formatting unzip_vle_lz4.c

2018-08-30 Thread Greg Kroah-Hartman
zip_vle_lz4.c | 72 > ++- > 1 file changed, 37 insertions(+), 35 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing

Re: SKylake Edac support in linux 2.6.32.696 kernel build

2018-08-31 Thread Greg Kroah-Hartman
On Fri, Aug 31, 2018 at 04:46:41PM +0530, Nitin Gupta wrote: > Hi All > > I started back porting Skylake Edac driver from 4.8 kernel to 2.6.696 > kernel Ick, why would you ever want to do that? Just use a newer kernel please. If you really want to do this, you are on your own. good luck! gr

Re: SKylake Edac support in linux 2.6.32.696 kernel build

2018-08-31 Thread Greg Kroah-Hartman
On Fri, Aug 31, 2018 at 11:22:06PM +0530, Nitin Gupta wrote: > Hi Greg > > Thanks for your comments but somehow i cant use the latest kernel . Why not? What is not working properly for you? It will be easier to fix that than to work with a crazy half-backported mess that you will be the sole p

Re: SKylake Edac support in linux 2.6.32.696 kernel build

2018-09-02 Thread Greg Kroah-Hartman
On Sun, Sep 02, 2018 at 03:45:01PM +0530, Nitin Gupta wrote: > Hi Greg > > i am working on some project which is having huge changes and working > on kernel-2.6.32-131.696 > it will be very difficult to back port them into 4.8 . Why 4.8? That too is a totally unsupported kernel version. Anyway

Re: [PATCH v3] staging: erofs: use explicit unsigned int type

2018-09-10 Thread Greg Kroah-Hartman
On Sun, Sep 09, 2018 at 08:37:53PM +0200, Thomas Weißschuh wrote: > Changes since v1: > > * Removed changes that conflicted with > [PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c > * Added patch description > > Changes since v2: > > * Fixed conflicts with other patchsets > * Don'

Re: [PATCH 1/2 dhowells/mount-api] staging: erofs: rename superblock flags (MS_xyz -> SB_xyz)

2018-09-10 Thread Greg Kroah-Hartman
On Thu, Sep 06, 2018 at 06:37:37PM +0800, Gao Xiang wrote: > > > On 2018/9/6 18:08, David Howells wrote: > > Gao Xiang wrote: > > > >> This patch follows commit 1751e8a6cb93 ("Rename superblock > >> flags (MS_xyz -> SB_xyz)") and after commit ("vfs: Suppress > >> MS_* flag defs within the kerne

Re: [PATCH 0/8] staging: erofs: error handing and more tracepoints

2018-09-18 Thread Greg Kroah-Hartman
On Fri, Sep 14, 2018 at 10:40:22PM +0800, Gao Xiang wrote: > In order to avoid conflicts with cleanup patches, Chao and I think > it is better to send reviewed preview patches in the erofs mailing list > to the community in time. > > So here is reviewed & tested patches right now, which clean up a

Re: [PATCH 0/8] staging: erofs: error handing and more tracepoints

2018-09-18 Thread Greg Kroah-Hartman
On Tue, Sep 18, 2018 at 08:02:30PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/9/18 19:19, Greg Kroah-Hartman wrote: > > On Fri, Sep 14, 2018 at 10:40:22PM +0800, Gao Xiang wrote: > >> In order to avoid conflicts with cleanup patches, Chao and I think > >> it i

Re: [PATCH 0/8] staging: erofs: error handing and more tracepoints

2018-09-18 Thread Greg Kroah-Hartman
On Tue, Sep 18, 2018 at 04:03:37PM +0300, Dan Carpenter wrote: > On Tue, Sep 18, 2018 at 08:31:22PM +0800, Gao Xiang wrote: > > (I have no clang environment to build kernel yet... :( I will try later, > > but I have no idea why it happens, > > and it seems a false warning). > > > > Thanks, > > Ga

Re: [PATCH] staging: erofs: initialize `pblk' with 0 first in `z_erofs_map_blocks_iter'

2018-09-18 Thread Greg Kroah-Hartman
ialize the variable to keep gcc from printing foolish warnings. > > [1] https://lists.ozlabs.org/pipermail/linux-erofs/2018-September/000637.html > > Reported-by: Greg Kroah-Hartman > Thanks-to: Dan Carpenter > Signed-off-by: Gao Xiang > --- > drivers/staging/erofs/unzip_vl

Re: [PATCH v2 0/8] staging: erofs: error handing and more tracepoints

2018-09-18 Thread Greg Kroah-Hartman
On Tue, Sep 18, 2018 at 10:25:32PM +0800, Gao Xiang wrote: > change log v2: > - fix a gcc warning reported by Greg for the patch > staging: erofs: clean up z_erofs_map_blocks_iter > > > In order to avoid conflicts with cleanup patches, Chao and I think > it is better to send reviewed pr

Re: [PATCH] staging: erofs: add SPDX identifer

2018-10-08 Thread Greg Kroah-Hartman
On Mon, Oct 08, 2018 at 09:20:55PM +0800, Gao Xiang wrote: > Hi Loic, > > On 2018/10/8 18:41, Loic Tourlonias wrote: > > Add SPDX identifier to simplify header and remove whole license text > > > > Signed-off-by: Loic Tourlonias > > --- > > drivers/staging/erofs/lz4defs.h | 23 ++---

Re: [PATCH v2] staging: erofs: add SPDX identifer

2018-10-08 Thread Greg Kroah-Hartman
On Mon, Oct 08, 2018 at 04:14:09PM +0200, Loic Tourlonias wrote: > Add SPDX identifier to simplify header and remove whole license text > > v1 -> v2: > > Move SPDX identifier to first line and change comment delimiter The "changes" need to go below the --- line. > > Signed-off-by: Loic Tourlon

Re: [PATCH v2] staging: erofs: add SPDX identifer

2018-10-08 Thread Greg Kroah-Hartman
On Mon, Oct 08, 2018 at 10:36:39PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/10/8 22:22, Greg Kroah-Hartman wrote: > > Why delete that line? > > > > But wait, why do we even have this file at all? What's wrong with the > > lib/lz4/ code that we have in

Re: [PATCH v3 2/2] staging: erofs: Modify conditional checks

2018-11-05 Thread Greg Kroah-Hartman
On Mon, Nov 05, 2018 at 12:35:03PM +, Bhagyashri P. Dighole wrote: > Fix coding style alignment issues detected by checkpatch.pl > Use ! for NULL test rather than explicitly comparing to NULL. > > Signed-off-by: Bhagyashri P. Dighole > --- > drivers/staging/erofs/data.c | 14 +++--- >

Re: [PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL.

2018-11-12 Thread Greg Kroah-Hartman
On Mon, Nov 12, 2018 at 09:43:57PM +0100, Cristian Sicilia wrote: > Replace equal to NULL with logic unary operator, > and removing not equal to NULL comparison. > > Signed-off-by: Cristian Sicilia > --- > drivers/staging/erofs/unzip_vle.c | 86 > +++ > 1 fil

Re: [PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL.

2018-11-12 Thread Greg Kroah-Hartman
On Tue, Nov 13, 2018 at 12:31:58AM +0100, Cristian Sicilia wrote: > On Mon, Nov 12, 2018 at 11:46 PM Greg Kroah-Hartman < > gre...@linuxfoundation.org> wrote: > > > On Mon, Nov 12, 2018 at 09:43:57PM +0100, Cristian Sicilia wrote: > > > Replace equal to NULL with l

Re: [PATCH 02/10] staging: erofs: fix race when the managed cache is enabled

2018-11-22 Thread Greg Kroah-Hartman
On Tue, Nov 20, 2018 at 10:34:17PM +0800, Gao Xiang wrote: > When the managed cache is enabled, the last reference count > of a workgroup must be used for its workstation. > > Otherwise, it could lead to incorrect (un)freezes in > the reclaim path, and it would be harmful. > > A typical race as f

Re: [PATCH 02/10] staging: erofs: fix race when the managed cache is enabled

2018-11-22 Thread Greg Kroah-Hartman
On Tue, Nov 20, 2018 at 10:34:17PM +0800, Gao Xiang wrote: > When the managed cache is enabled, the last reference count > of a workgroup must be used for its workstation. > > Otherwise, it could lead to incorrect (un)freezes in > the reclaim path, and it would be harmful. > > A typical race as f

Re: [PATCH 01/10] staging: erofs: fix `trace_erofs_readpage' position

2018-11-22 Thread Greg Kroah-Hartman
On Tue, Nov 20, 2018 at 10:34:16PM +0800, Gao Xiang wrote: > `trace_erofs_readpage' should be placed in .readpage() > rather than in the internal `z_erofs_do_read_page'. Why? What happens with the code today? > > Fixes: 284db12cfda3 ("staging: erofs: add trace points for reading zipped > data"

Re: [PATCH 03/10] staging: erofs: atomic_cond_read_relaxed on ref-locked workgroup

2018-11-22 Thread Greg Kroah-Hartman
On Tue, Nov 20, 2018 at 10:34:18PM +0800, Gao Xiang wrote: > It's better to use atomic_cond_read_relaxed, which is implemented > in hardware instructions to monitor a variable changes currently > for ARM64, instead of open-coded busy waiting. > > Reviewed-by: Chao Yu > Signed-off-by: Gao Xiang >

Re: [PATCH 04/10] staging: erofs: fix `erofs_workgroup_{try_to_freeze, unfreeze}'

2018-11-22 Thread Greg Kroah-Hartman
On Tue, Nov 20, 2018 at 10:34:19PM +0800, Gao Xiang wrote: > There are two minor issues in the current freeze interface: > >1) Freeze interfaces have not related with CONFIG_DEBUG_SPINLOCK, > therefore fix the incorrect conditions; > >2) For SMP platforms, it should also disable pre

Re: [PATCH 05/10] staging: erofs: add a full barrier in erofs_workgroup_unfreeze

2018-11-22 Thread Greg Kroah-Hartman
On Tue, Nov 20, 2018 at 10:34:20PM +0800, Gao Xiang wrote: > Just like other generic locks, insert a full barrier > in case of memory reorder. > > Reviewed-by: Chao Yu > Signed-off-by: Gao Xiang > --- > drivers/staging/erofs/internal.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/d

Re: [PATCH 07/10] staging: erofs: separate into init_once / always

2018-11-22 Thread Greg Kroah-Hartman
On Tue, Nov 20, 2018 at 10:34:22PM +0800, Gao Xiang wrote: > `z_erofs_vle_workgroup' is heavily generated in the decompression, > for example, it resets 32 bytes redundantly for 64-bit platforms > even through Z_EROFS_VLE_INLINE_PAGEVECS + Z_EROFS_CLUSTER_MAX_PAGES, > default 4, pages are stored in

Re: [PATCH 08/10] staging: erofs: locked before registering for all new workgroups

2018-11-22 Thread Greg Kroah-Hartman
On Tue, Nov 20, 2018 at 10:34:23PM +0800, Gao Xiang wrote: > Let's make sure that the one registering a workgroup will also > take the primary work lock at first for two reasons: > 1) There's no need to introduce such a race window (and consequently > overhead) between registering and lockin

Re: [PATCH 01/10] staging: erofs: fix `trace_erofs_readpage' position

2018-11-22 Thread Greg Kroah-Hartman
On Thu, Nov 22, 2018 at 06:49:53PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 18:19, Greg Kroah-Hartman wrote: > > On Tue, Nov 20, 2018 at 10:34:16PM +0800, Gao Xiang wrote: > >> `trace_erofs_readpage' should be placed in .readpage() >

Re: [PATCH 04/10] staging: erofs: fix `erofs_workgroup_{try_to_freeze, unfreeze}'

2018-11-22 Thread Greg Kroah-Hartman
On Thu, Nov 22, 2018 at 06:29:34PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 18:21, Greg Kroah-Hartman wrote: > > On Tue, Nov 20, 2018 at 10:34:19PM +0800, Gao Xiang wrote: > >> There are two minor issues in the current freeze interface: > >> >

Re: [PATCH 07/10] staging: erofs: separate into init_once / always

2018-11-22 Thread Greg Kroah-Hartman
On Thu, Nov 22, 2018 at 06:34:10PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 18:23, Greg Kroah-Hartman wrote: > >> + > >> + DBG_BUGON(work->nr_pages); > >> + DBG_BUGON(work->vcnt); > > How can these ever be triggered? I understand the

Re: [PATCH 04/10] staging: erofs: fix `erofs_workgroup_{try_to_freeze, unfreeze}'

2018-11-22 Thread Greg Kroah-Hartman
On Thu, Nov 22, 2018 at 06:29:34PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 18:21, Greg Kroah-Hartman wrote: > > On Tue, Nov 20, 2018 at 10:34:19PM +0800, Gao Xiang wrote: > >> There are two minor issues in the current freeze interface: > >> >

Re: [PATCH 02/10] staging: erofs: fix race when the managed cache is enabled

2018-11-22 Thread Greg Kroah-Hartman
On Thu, Nov 22, 2018 at 06:42:52PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 18:17, Greg Kroah-Hartman wrote: > > Any specific reason why you are not using the refcount.h api instead of > > "doing it yourself" with atomic_inc/dec()? > > >

Re: [PATCH 07/10] staging: erofs: separate into init_once / always

2018-11-22 Thread Greg Kroah-Hartman
On Thu, Nov 22, 2018 at 07:11:08PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 19:05, Greg Kroah-Hartman wrote: > > On Thu, Nov 22, 2018 at 06:34:10PM +0800, Gao Xiang wrote: > >> Hi Greg, > >> > >> On 2018/11/22 18:23, Greg Kroah-Hartman wrot

Re: [PATCH 02/10] staging: erofs: fix race when the managed cache is enabled

2018-11-22 Thread Greg Kroah-Hartman
On Thu, Nov 22, 2018 at 07:43:50PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 19:06, Greg Kroah-Hartman wrote: > > On Thu, Nov 22, 2018 at 06:42:52PM +0800, Gao Xiang wrote: > >> Hi Greg, > >> > >> On 2018/11/22 18:17, Greg Kroah-Hartman wrote:

Re: [PATCH 02/10] staging: erofs: fix race when the managed cache is enabled

2018-11-22 Thread Greg Kroah-Hartman
On Thu, Nov 22, 2018 at 08:41:15PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 20:26, Greg Kroah-Hartman wrote: > > Ugh, every page? Ok, nevermind, I take back my objections. You all are > > crazy and need to do crazy things like this :) > > ...Do you have

Re: [PATCH 07/10] staging: erofs: separate into init_once / always

2018-11-22 Thread Greg Kroah-Hartman
On Thu, Nov 22, 2018 at 09:01:31PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 20:00, Gao Xiang wrote: > > Hi Greg, > > > > On 2018/11/22 19:26, Greg Kroah-Hartman wrote: > >> Don't make people rebuild your code with different options for >

Re: [PATCH 0/2] staging: erofs: fixed -Wmissing-prototype warnings.

2019-01-07 Thread Greg Kroah-Hartman
On Mon, Jan 07, 2019 at 06:25:14PM +, Jeremy Sowden wrote: > Fixes for -Wmissing-prototype warnings in the erofs driver. One group of > functions have been made static; for the second, prototypes have been moved > to a > head > > Jeremy Sowden (2): > staging: erofs: fixed -Wmissing-prototy

Re: [PATCH] staging: erofs: remove rcu_read_lock() in erofs_try_to_free_cached_page

2019-02-20 Thread Greg Kroah-Hartman
On Wed, Feb 20, 2019 at 10:38:53AM +0800, Gao Xiang wrote: > Hi Greg, > > Could you consider take some time on these two patches for linux-5.1-rc1? > 1) staging: erofs: fix race of initializing xattrs of a inode at the same > time > 2) staging: erofs: remove rcu_read_lock() in erofs_try_to_free

Re: [PATCH for-4.19 00/12] erofs fixes for linux-4.19.y

2019-02-22 Thread Greg Kroah-Hartman
On Wed, Feb 20, 2019 at 05:18:42PM +0800, Gao Xiang wrote: > This series backports bugfixes already merged in linux upstream > which we found these issues in our commerical products, which > are serious and should be fixed immediately. > > Note that it also includes some xarray modification since

Re: [PATCH for-4.19 02/12] staging: erofs: complete error handing of z_erofs_do_read_page

2019-02-25 Thread Greg Kroah-Hartman
ill unlock this page without setting > PG_uptodate. > > Reviewed-by: Chao Yu > Signed-off-by: Gao Xiang > Signed-off-by: Greg Kroah-Hartman > > Conflicts: > drivers/staging/erofs/unzip_vle.c These types of lines are not needed in backports, they just are clutter. I'll go fix it up... greg k-h

Re: [PATCH for-4.19 06/12] staging: erofs: fix race when the managed cache is enabled

2019-02-25 Thread Greg Kroah-Hartman
reeze constraint. > > Reviewed-by: Chao Yu > Signed-off-by: Gao Xiang > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Gao Xiang > > Conflicts: > drivers/staging/erofs/utils.c > Updates: > include/linux/xarray.h: > add xa_untag

Re: [PATCH for-4.20 0/7] erofs fixes for linux-4.20.y

2019-02-25 Thread Greg Kroah-Hartman
On Fri, Feb 22, 2019 at 11:46:30PM +0800, Gao Xiang wrote: > This series backports bugfixes already merged in linux upstream > which we found these issues in our commercial products, which > are serious and should be fixed immediately. > > Note that it also includes some xarray modification since

Re: [PATCH for-4.19 00/12] erofs fixes for linux-4.19.y

2019-02-25 Thread Greg Kroah-Hartman
On Wed, Feb 20, 2019 at 05:18:42PM +0800, Gao Xiang wrote: > This series backports bugfixes already merged in linux upstream > which we found these issues in our commerical products, which > are serious and should be fixed immediately. > > Note that it also includes some xarray modification since

Re: [PATCH for-4.19 06/12] staging: erofs: fix race when the managed cache is enabled

2019-02-25 Thread Greg Kroah-Hartman
On Mon, Feb 25, 2019 at 11:07:19PM +0800, Gao Xiang wrote: > > > On 2019/2/25 23:04, Greg Kroah-Hartman wrote: > > On Wed, Feb 20, 2019 at 05:18:48PM +0800, Gao Xiang wrote: > >> commit 51232df5e4b268936beccde5248f312a316800be upstream. > >> > >> W

Re: [PATCH for-4.19 06/12] staging: erofs: fix race when the managed cache is enabled

2019-02-25 Thread Greg Kroah-Hartman
On Mon, Feb 25, 2019 at 07:25:48AM -0800, Matthew Wilcox wrote: > On Mon, Feb 25, 2019 at 04:04:49PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Feb 20, 2019 at 05:18:48PM +0800, Gao Xiang wrote: > > > commit 51232df5e4b268936beccde5248f312a316800be upstream. > > > Upd

Re: [PATCH RESEND for-5.0 1/2] staging: erofs: keep corrupted fs from crashing kernel in erofs_namei()

2019-03-12 Thread Greg Kroah-Hartman
On Mon, Mar 11, 2019 at 10:29:31AM +0800, Gao Xiang wrote: > commit 419d6efc50e94bcf5d6b35cd8c71f79edadec564 upstream. > > As Al pointed out, " > ... and while we are at it, what happens to > unsigned int nameoff = le16_to_cpu(de[mid].nameoff); > unsigned int matched = min(startprfx, e

Re: [PATCH for-4.20] staging: erofs: keep corrupted fs from crashing kernel in erofs_namei()

2019-03-12 Thread Greg Kroah-Hartman
On Mon, Mar 11, 2019 at 10:40:23AM +0800, Gao Xiang wrote: > commit 419d6efc50e94bcf5d6b35cd8c71f79edadec564 upstream. > > As Al pointed out, " > ... and while we are at it, what happens to > unsigned int nameoff = le16_to_cpu(de[mid].nameoff); > unsigned int matched = min(startprfx, e

Re: [PATCH RESEND for-5.0 2/2] staging: erofs: compressed_pages should not be accessed again after freed

2019-03-12 Thread Greg Kroah-Hartman
On Mon, Mar 11, 2019 at 10:29:32AM +0800, Gao Xiang wrote: > commit af692e117cb8cd9d3d844d413095775abc1217f9 upstream. > > This patch resolves the following page use-after-free issue, > z_erofs_vle_unzip: > ... > for (i = 0; i < nr_pages; ++i) { > ... > z_erofs_onlinepage_e

Re: [PATCH 4.19 1/5] staging: erofs: add error handling for xattr submodule

2019-03-12 Thread Greg Kroah-Hartman
On Mon, Mar 11, 2019 at 02:08:54PM +0800, Gao Xiang wrote: > commit cadf1ccf1b0021d0b7a9347e102ac5258f9f98c8 upstream. > > This patch enhances the missing error handling code for > xattr submodule, which improves the stability for the rare cases. > > Reviewed-by: Chao Yu > Signed-off-by: Chao Yu

Re: [PATCH v3 for-4.19] staging: erofs: fix race when the managed cache is enabled

2019-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2019 at 03:26:34PM +0800, Gao Xiang wrote: > commit 51232df5e4b268936beccde5248f312a316800be upstream. > > When the managed cache is enabled, the last reference count > of a workgroup must be used for its workstation. > > Otherwise, it could lead to incorrect (un)freezes in > the

Re: [PATCH for-4.19 1/2] staging: erofs: fix error handling when failed to read compresssed data

2019-04-01 Thread Greg Kroah-Hartman
On Mon, Apr 01, 2019 at 02:53:08PM +0800, Gao Xiang wrote: > commit b6391ac73400eff38377a4a7364bd3df5efb5178 upstream. > > Complete read error handling paths for all three kinds of > compressed pages: > > 1) For cache-managed pages, PG_uptodate will be checked since > read_endio will unlock

Re: [PATCH v3 1/2] staging: erofs: add requirements field in superblock

2019-06-16 Thread Greg Kroah-Hartman
On Sun, Jun 16, 2019 at 03:00:38PM +0800, Gao Xiang wrote: > Hi Greg, > > Sorry for annoying... Could you help merge these two fixes? Thanks in > advance... It was only 3 days, please give me at the very least, a week or so for staging patches. > decompression inplace optimization needs these t

Re: [RFC PATCH 0/8] staging: erofs: decompression inplace approach

2019-06-17 Thread Greg Kroah-Hartman
On Sat, Jun 15, 2019 at 02:16:11AM +0800, Gao Xiang wrote: > At last, this is RFC patch v1, which means it is not suitable for > merging soon... I'm still working on it, testing its stability > these days and hope these patches get merged for 5.3 LTS > (if 5.3 is a LTS version). Why would 5.3 be a

Re: [RFC PATCH 0/8] staging: erofs: decompression inplace approach

2019-06-17 Thread Greg Kroah-Hartman
On Tue, Jun 18, 2019 at 09:47:08AM +0800, Gao Xiang wrote: > > > On 2019/6/18 4:36, Greg Kroah-Hartman wrote: > > On Sat, Jun 15, 2019 at 02:16:11AM +0800, Gao Xiang wrote: > >> At last, this is RFC patch v1, which means it is not suitable for > >> mergin

Re: [RFC PATCH 0/8] staging: erofs: decompression inplace approach

2019-06-17 Thread Greg Kroah-Hartman
On Tue, Jun 18, 2019 at 02:18:00PM +0800, Gao Xiang wrote: > > > On 2019/6/18 13:47, Greg Kroah-Hartman wrote: > > On Tue, Jun 18, 2019 at 09:47:08AM +0800, Gao Xiang wrote: > >> > >> > >> On 2019/6/18 4:36, Greg Kroah-Hartman wrote: > >>&g

Re: [RFC PATCH 0/8] staging: erofs: decompression inplace approach

2019-06-18 Thread Greg Kroah-Hartman
On Tue, Jun 18, 2019 at 02:52:21PM +0800, Gao Xiang wrote: > > > On 2019/6/18 14:45, Greg Kroah-Hartman wrote: > > On Tue, Jun 18, 2019 at 02:18:00PM +0800, Gao Xiang wrote: > >> > >> > >> On 2019/6/18 13:47, Greg Kroah-Hartman wrote: > >>&g

Re: [PATCH] erofs: promote erofs from staging

2019-07-04 Thread Greg Kroah-Hartman
On Thu, Jul 04, 2019 at 09:34:13PM +0800, Gao Xiang wrote: > EROFS file system has been in Linux-staging for about a year. > It has been proved to be stable enough to move out of staging > by 10+ millions of HUAWEI Android mobile phones on the market > from EMUI 9.0.1, and it was promoted as one of

Re: [PATCH] erofs: promote erofs from staging

2019-07-04 Thread Greg Kroah-Hartman
On Thu, Jul 04, 2019 at 10:00:53PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2019/7/4 21:50, Greg Kroah-Hartman wrote: > > On Thu, Jul 04, 2019 at 09:34:13PM +0800, Gao Xiang wrote: > >> EROFS file system has been in Linux-staging for about a year. > >> It has b

Re: [PATCH v3 01/24] erofs: add on-disk layout

2019-07-21 Thread Greg Kroah-Hartman
On Mon, Jul 22, 2019 at 01:26:16PM +1000, Stephen Rothwell wrote: > Hi Gao, > > On Mon, 22 Jul 2019 10:50:20 +0800 Gao Xiang wrote: > > > > diff --git a/fs/erofs/erofs_fs.h b/fs/erofs/erofs_fs.h > > new file mode 100644 > > index ..e418725abfd6 > > --- /dev/null > > +++ b/fs/erofs/ero

Re: [PATCH 01/22] staging: erofs: update source file headers

2019-07-30 Thread Greg Kroah-Hartman
On Mon, Jul 29, 2019 at 02:51:38PM +0800, Gao Xiang wrote: > - Use the correct style for all SPDX License Identifiers; > - Get rid of the unnecessary license boilerplate; > - Use "GPL-2.0-only" instead of "GPL-2.0" suggested-by Stephen. Note, either tag works just fine, they are identical. I'll t

Re: [PATCH v8 00/24] erofs: promote erofs from staging v8

2019-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2019 at 12:41:31PM +0800, Gao Xiang wrote: > [I strip the previous cover letter, the old one can be found in v6: > https://lore.kernel.org/r/20190802125347.166018-1-gaoxian...@huawei.com/] > > We'd like to submit a formal moving patch applied to staging tree > for 5.4, before that

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Greg Kroah-Hartman
On Sun, Aug 18, 2019 at 11:03:53AM +0200, Richard Weinberger wrote: > - Ursprüngliche Mail - > > I agree with you, but what can we do now is trying our best to fuzz > > all the fields. > > > > So, what is your opinion about EROFS? > > All I'm saying is that you should not blindly trust th

Re: [PATCH 5/6] staging: erofs: detect potential multiref due to corrupted images

2019-08-20 Thread Greg Kroah-Hartman
On Mon, Aug 19, 2019 at 10:57:42PM +0800, Chao Yu wrote: > On 2019-8-19 18:34, Gao Xiang wrote: > > As reported by erofs-utils fuzzer, currently, multiref > > (ondisk deduplication) hasn't been supported for now, > > we should forbid it properly. > > > > Fixes: 3883a79abd02 ("staging: erofs: intro

Re: [PATCH 1/2] staging/erofs/xattr.h: Fixed misaligned function arguments.

2019-08-20 Thread Greg Kroah-Hartman
dly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take

Re: [PATCH 4.19.y] erofs: correct the remaining shrink objects

2020-04-14 Thread Greg Kroah-Hartman
On Tue, Apr 14, 2020 at 11:38:20PM +0800, Gao Xiang wrote: > From: Gao Xiang > > commit 9d5a09c6f3b5fb85af20e3a34827b5d27d152b34 upstream. > > The remaining count should not include successful > shrink attempts. > > Fixes: e7e9a307be9d ("staging: erofs: introduce workstation for > decompressio

Re: [PATCH stable 5.15.y] erofs: fix compact 4B support for 16k block size

2023-07-20 Thread Greg Kroah-Hartman
On Fri, Jul 21, 2023 at 10:22:21AM +0800, Gao Xiang wrote: > commit 001b8ccd0650727e54ec16ef72bf1b8eeab7168e upstream. > > In compact 4B, two adjacent lclusters are packed together as a unit to > form on-disk indexes for effective random access, as below: > > (amortized = 4, vcnt = 2) >__

Re: [PATCH 6.5.y] erofs: ensure that the post-EOF tails are all zeroed

2023-09-02 Thread Greg Kroah-Hartman
On Thu, Aug 31, 2023 at 07:29:53PM +0800, Gao Xiang wrote: > commit e4c1cf523d820730a86cae2c6d55924833b6f7ac upstream. > > This was accidentally fixed up in commit e4c1cf523d82 but we can't > take the full change due to other dependancy issues, so here is just > the actual bugfix that is needed. >

Re: [PATCH 6.8.y 2/2] erofs: reliably distinguish block based and fscache mode

2024-05-23 Thread Greg Kroah-Hartman
On Tue, May 21, 2024 at 02:50:32PM +0800, Gao Xiang wrote: > From: Christian Brauner > > commit 7af2ae1b1531feab5d38ec9c8f472dc6cceb4606 upstream. > > When erofs_kill_sb() is called in block dev based mode, s_bdev may not > have been initialised yet, and if CONFIG_EROFS_FS_ONDEMAND is enabled, >

Re: [PATCH 6.9.y] erofs: avoid allocating DEFLATE streams before mounting

2024-06-12 Thread Greg Kroah-Hartman
On Tue, Jun 04, 2024 at 08:33:05PM +0800, Gao Xiang wrote: > Hi Greg, > > ping? Do these backport fixes miss the 6.6, 6.8, 6.9 queues.. Sorry for the delay, all now queued up. well, except for 6.8.y, that branch is now end-of-life, sorry. greg k-h

[PATCH 6.6 250/267] cachefiles, erofs: Fix NULL deref in when cachefiles is not doing ondemand-mode

2024-06-19 Thread Greg Kroah-Hartman
zlabs.org cc: ne...@lists.linux.dev cc: linux-fsde...@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/cachefiles/ondemand.c |3 +++ 1 file changed, 3 insertions(+) --- a/fs/cachefiles/ondemand.c +++ b/fs/cachefiles/ondemand.c @@ -611,6 +611,9 @@ int cachefiles_ondemand_init_object(str

[PATCH 6.1 207/217] cachefiles, erofs: Fix NULL deref in when cachefiles is not doing ondemand-mode

2024-06-19 Thread Greg Kroah-Hartman
zlabs.org cc: ne...@lists.linux.dev cc: linux-fsde...@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/cachefiles/ondemand.c |3 +++ 1 file changed, 3 insertions(+) --- a/fs/cachefiles/ondemand.c +++ b/fs/cachefiles/ondemand.c @@ -611,6 +611,9 @@ int cachefiles_ondemand_init_object(str

Re: [PATCH for-4.19] erofs: fix extended inode could cross boundary

2021-04-26 Thread Greg Kroah-Hartman
On Mon, Apr 26, 2021 at 04:29:33PM +0800, Gao Xiang wrote: > commit 0dcd3c94e02438f4a571690e26f4ee997524102a upstream. > > Each ondisk inode should be aligned with inode slot boundary > (32-byte alignment) because of nid calculation formula, so all > compact inodes (32 byte) cannot across page bou

Re: [PATCH 5.10.y 1/2] erofs: remove the occupied parameter from z_erofs_pagevec_enqueue()

2021-11-19 Thread Greg Kroah-Hartman
On Tue, Nov 16, 2021 at 09:08:18AM +0800, Gao Xiang wrote: > From: Yue Hu > > commit 7dea3de7d384f4c8156e8bd93112ba6db1eb276c upstream. > > No any behavior to variable occupied in z_erofs_attach_page() which > is only caller to z_erofs_pagevec_enqueue(). > > Link: https://lore.kernel.org/r/2021

[PATCH 5.15 164/247] iov_iter: Fix iter_xarray_get_pages{,_alloc}()

2022-06-13 Thread Greg Kroah-Hartman
From: David Howells [ Upstream commit 6c77676645ad42993e0a8bdb8dafa517851a352a ] The maths at the end of iter_xarray_get_pages() to calculate the actual size doesn't work under some circumstances, such as when it's been asked to extract a partial single page. Various terms of the equation cance

[PATCH 5.18 222/339] iov_iter: Fix iter_xarray_get_pages{,_alloc}()

2022-06-13 Thread Greg Kroah-Hartman
From: David Howells [ Upstream commit 6c77676645ad42993e0a8bdb8dafa517851a352a ] The maths at the end of iter_xarray_get_pages() to calculate the actual size doesn't work under some circumstances, such as when it's been asked to extract a partial single page. Various terms of the equation cance

[PATCH 5.17 195/298] iov_iter: Fix iter_xarray_get_pages{,_alloc}()

2022-06-13 Thread Greg Kroah-Hartman
From: David Howells [ Upstream commit 6c77676645ad42993e0a8bdb8dafa517851a352a ] The maths at the end of iter_xarray_get_pages() to calculate the actual size doesn't work under some circumstances, such as when it's been asked to extract a partial single page. Various terms of the equation cance

Re: [PATCH 6.1.y 1/5] erofs: get rid of erofs_inode_datablocks()

2024-10-08 Thread Greg Kroah-Hartman
On Tue, Oct 08, 2024 at 02:57:04PM +0800, Gao Xiang wrote: > commit 4efdec36dc9907628e590a68193d6d8e5e74d032 upstream. > > erofs_inode_datablocks() has the only one caller, let's just get > rid of it entirely. No logic changes. > > Reviewed-by: Yue Hu > Reviewed-by: Jingbo Xu > Reviewed-by: Ch

Re: [RFC PATCH 03/24] erofs: add Errno in Rust

2024-09-21 Thread Greg Kroah-Hartman
On Fri, Sep 20, 2024 at 08:49:26AM +0800, Gao Xiang wrote: > > > On 2024/9/20 03:36, Benno Lossin wrote: > > On 19.09.24 17:13, Gao Xiang wrote: > > > Hi Benno, > > > > > > On 2024/9/19 21:45, Benno Lossin wrote: > > > > Hi, > > > > > > > > Thanks for the patch series. I think it's great that y

[PATCH 6.11 123/695] cachefiles: Fix non-taking of sb_writers around set/removexattr

2024-10-02 Thread Greg Kroah-Hartman
6.11-stable review patch. If anyone has any objections, please let me know. -- From: David Howells [ Upstream commit 80887f31672970abae3aaa9cf62ac72a124e7c89 ] Unlike other vfs_() calls, vfs_setxattr() and vfs_removexattr() don't take the sb_writers lock, so the caller sho

[PATCH 6.10 107/634] cachefiles: Fix non-taking of sb_writers around set/removexattr

2024-10-02 Thread Greg Kroah-Hartman
6.10-stable review patch. If anyone has any objections, please let me know. -- From: David Howells [ Upstream commit 80887f31672970abae3aaa9cf62ac72a124e7c89 ] Unlike other vfs_() calls, vfs_setxattr() and vfs_removexattr() don't take the sb_writers lock, so the caller sho

[PATCH 6.6 081/538] cachefiles: Fix non-taking of sb_writers around set/removexattr

2024-10-02 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: David Howells [ Upstream commit 80887f31672970abae3aaa9cf62ac72a124e7c89 ] Unlike other vfs_() calls, vfs_setxattr() and vfs_removexattr() don't take the sb_writers lock, so the caller shou