[PATCH] erofs-utils: lib: fix inappropriate initialization in cache.c

2025-03-02 Thread Hongzhen Luo
This patch fixes the inappropriate initialization of `dsunit` and `bktmap` in cache.c. Fixes: 8bb6de4e7c41 ("erofs-utils: mkfs: support data alignment") Fixes: ca0f040f98b6 ("erofs-utils: lib: use bitmaps to accelerate bucket selection") Signed-off-by: Hongzhen Luo --- lib/cache.c | 4 +++- 1 f

Re: [PATCH] erofs-utils: lib: fix inappropriate initialization in cache.c

2025-03-02 Thread Gao Xiang
On 2025/3/3 13:42, Hongzhen Luo wrote: This patch fixes the inappropriate initialization of `dsunit` and `bktmap` in cache.c. Fixes: 8bb6de4e7c41 ("erofs-utils: mkfs: support data alignment") Fixes: ca0f040f98b6 ("erofs-utils: lib: use bitmaps to accelerate bucket selection") Signed-off-by:

Re: [PATCH 6.1 1/2] erofs: handle overlapped pclusters out of crafted images properly

2025-03-02 Thread Gao Xiang
Hi Fedor, On 2025/3/2 18:56, Fedor Pchelkin wrote: On Fri, 28. Feb 19:51, Alexey Panov wrote: From: Gao Xiang commit 9e2f9d34dd12e6e5b244ec488bcebd0c2d566c50 upstream. syzbot reported a task hang issue due to a deadlock case where it is waiting for the folio lock of a cached folio that will

Re: [PATCH 6.1 1/2] erofs: handle overlapped pclusters out of crafted images properly

2025-03-02 Thread Fedor Pchelkin
On Mon, 03. Mar 01:41, Gao Xiang wrote: > > > diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c > > > index 94e9e0bf3bbd..ac01c0ede7f7 100644 > > > > I'm looking at the diff of upstream commit and the first thing it does > > is to remove zeroing out the folio/page private field here: > > > >//

Re: [PATCH 6.1 1/2] erofs: handle overlapped pclusters out of crafted images properly

2025-03-02 Thread Gao Xiang
On 2025/3/3 02:13, Fedor Pchelkin wrote: On Mon, 03. Mar 01:41, Gao Xiang wrote: diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c index 94e9e0bf3bbd..ac01c0ede7f7 100644 I'm looking at the diff of upstream commit and the first thing it does is to remove zeroing out the folio/page private fi

Re: [PATCH 6.1 1/2] erofs: handle overlapped pclusters out of crafted images properly

2025-03-02 Thread Fedor Pchelkin
On Fri, 28. Feb 19:51, Alexey Panov wrote: > From: Gao Xiang > > commit 9e2f9d34dd12e6e5b244ec488bcebd0c2d566c50 upstream. > > syzbot reported a task hang issue due to a deadlock case where it is > waiting for the folio lock of a cached folio that will be used for > cache I/Os. > > After lookin

Re: [PATCH 6.1 1/2] erofs: handle overlapped pclusters out of crafted images properly

2025-03-02 Thread Gao Xiang
On 2025/3/3 01:41, Gao Xiang wrote: Hi Fedor, On 2025/3/2 18:56, Fedor Pchelkin wrote: On Fri, 28. Feb 19:51, Alexey Panov wrote: From: Gao Xiang commit 9e2f9d34dd12e6e5b244ec488bcebd0c2d566c50 upstream. syzbot reported a task hang issue due to a deadlock case where it is waiting for the