On 2024/10/8 20:55, Christoph Hellwig wrote:
On Tue, Oct 08, 2024 at 08:33:27PM +0800, Gao Xiang wrote:
how about
int get_tree_bdev_flags(struct fs_context *fc,
int (*fill_super)(struct super_block *,
struct fs_context *), bool quiet)
for now
On Tue, Oct 08, 2024 at 08:33:27PM +0800, Gao Xiang wrote:
> how about
> int get_tree_bdev_flags(struct fs_context *fc,
> int (*fill_super)(struct super_block *,
> struct fs_context *), bool quiet)
>
> for now? it can be turned into `int flags` if othe
On 2024/10/8 20:23, Christoph Hellwig wrote:
On Tue, Oct 08, 2024 at 08:10:45PM +0800, Gao Xiang wrote:
But the error message out of get_tree_bdev() is inflexible and
IMHO it's too coupled to `fc->source`.
Otherwise just passing a quiet flag of some form feels like a much
saner interface.
On Tue, Oct 08, 2024 at 08:10:45PM +0800, Gao Xiang wrote:
> But the error message out of get_tree_bdev() is inflexible and
> IMHO it's too coupled to `fc->source`.
>
> > Otherwise just passing a quiet flag of some form feels like a much
> > saner interface.
>
> I'm fine with this way, but that w
Hi Christoph,
On 2024/10/8 19:49, Christoph Hellwig wrote:
On Tue, Oct 08, 2024 at 05:56:05PM +0800, Gao Xiang wrote:
As Allison reported [1], currently get_tree_bdev() will store
"Can't lookup blockdev" error message. Although it makes sense for
pure bdev-based fses, this message may mislead
On Tue, Oct 08, 2024 at 05:56:05PM +0800, Gao Xiang wrote:
> As Allison reported [1], currently get_tree_bdev() will store
> "Can't lookup blockdev" error message. Although it makes sense for
> pure bdev-based fses, this message may mislead users who try to use
> EROFS file-backed mounts since get
