Re: [PATCH v4 07/33] netfs: Abstract out a rolling folio buffer implementation

2024-11-18 Thread David Howells
Kees Bakker wrote: > > + wreq->buffer.iter = wreq->buffer.iter; > Is this correct, an assignment to itself? That should just be removed. Both branches of the preceding if-statement set it. David

Re: [PATCH v4 07/33] netfs: Abstract out a rolling folio buffer implementation

2024-11-15 Thread Kees Bakker
Op 08-11-2024 om 18:32 schreef David Howells: A rolling buffer is a series of folios held in a list of folio_queues. New folios and folio_queue structs may be inserted at the head simultaneously with spent ones being removed from the tail without the need for locking. The rolling buffer include

[PATCH v4 07/33] netfs: Abstract out a rolling folio buffer implementation

2024-11-08 Thread David Howells
A rolling buffer is a series of folios held in a list of folio_queues. New folios and folio_queue structs may be inserted at the head simultaneously with spent ones being removed from the tail without the need for locking. The rolling buffer includes an iov_iter and it has to be careful managing