Re: [PATCH v2] mkfs: Fix input offset counting in headerball mode

2024-11-12 Thread Gao Xiang
On 2024/11/12 22:50, Mike Baynton wrote: On Mon, Nov 11, 2024 at 7:05 PM Gao Xiang wrote: Hi Mike, I will add "erofs-utils:" prefix to the patch subject but no need to add "Co-developed-by" tag. Btw, if some converter for headerball files from tarballs is available in public? It'd be bett

Re: [PATCH v2] mkfs: Fix input offset counting in headerball mode

2024-11-12 Thread Mike Baynton
On Mon, Nov 11, 2024 at 7:05 PM Gao Xiang wrote: > > Hi Mike, > > I will add "erofs-utils:" prefix to the patch subject but no need > to add "Co-developed-by" tag. > > Btw, if some converter for headerball files from tarballs is > available in public? It'd be better to get some tests for this > fe

Re: [PATCH v2] mkfs: Fix input offset counting in headerball mode

2024-11-11 Thread Gao Xiang
Hi Mike, On 2024/11/12 00:48, Mike Baynton wrote: When using --tar=headerball, most files included in the headerball are not included in the EROFS image. mkfs.erofs typically exits prematurely, having processed non-USTAR blocks as USTAR and believing they are end-of-archive markers. (Other failu

[PATCH v2] mkfs: Fix input offset counting in headerball mode

2024-11-11 Thread Mike Baynton
When using --tar=headerball, most files included in the headerball are not included in the EROFS image. mkfs.erofs typically exits prematurely, having processed non-USTAR blocks as USTAR and believing they are end-of-archive markers. (Other failure modes are probably also possible if the input stre