Re: [PATCH 8/8] gfs2: use lockref_init for qd_lockref

2025-01-22 Thread Christian Brauner via Linux-erofs
On Mon, Jan 20, 2025 at 04:44:59PM +0100, Andreas Gruenbacher wrote: > On Mon, Jan 20, 2025 at 4:25 PM Christian Brauner wrote: > > On Fri, Jan 17, 2025 at 05:03:51PM +0100, Andreas Gruenbacher wrote: > > > On Thu, 16 Jan 2025 05:32:26 +0100, Christoph Hellwig wrote: > > > > Well, if you can fix

Re: [PATCH 8/8] gfs2: use lockref_init for qd_lockref

2025-01-20 Thread Andreas Gruenbacher
On Mon, Jan 20, 2025 at 4:25 PM Christian Brauner wrote: > On Fri, Jan 17, 2025 at 05:03:51PM +0100, Andreas Gruenbacher wrote: > > On Thu, 16 Jan 2025 05:32:26 +0100, Christoph Hellwig wrote: > > > Well, if you can fix it to start with 1 we could start out with 1 > > > as the default. FYI, I al

Re: [PATCH 8/8] gfs2: use lockref_init for qd_lockref

2025-01-20 Thread Christian Brauner via Linux-erofs
On Fri, Jan 17, 2025 at 05:03:51PM +0100, Andreas Gruenbacher wrote: > On Thu, 16 Jan 2025 05:32:26 +0100, Christoph Hellwig wrote: > > Well, if you can fix it to start with 1 we could start out with 1 > > as the default. FYI, I also didn't touch the other gfs2 lockref > > because it initialize t

Re: [PATCH 8/8] gfs2: use lockref_init for qd_lockref

2025-01-17 Thread Andreas Gruenbacher
On Thu, 16 Jan 2025 05:32:26 +0100, Christoph Hellwig wrote: > Well, if you can fix it to start with 1 we could start out with 1 > as the default. FYI, I also didn't touch the other gfs2 lockref > because it initialize the lock in the slab init_once callback and > the count on every initializatio

Re: [PATCH 8/8] gfs2: use lockref_init for qd_lockref

2025-01-15 Thread Christoph Hellwig
On Wed, Jan 15, 2025 at 02:35:03PM +0100, Andreas Gruenbacher wrote: > > +++ b/fs/gfs2/quota.c > > @@ -236,8 +236,7 @@ static struct gfs2_quota_data *qd_alloc(unsigned hash, > > struct gfs2_sbd *sdp, str > > return NULL; > > > > qd->qd_sbd = sdp; > > - qd->qd_lockref.

Re: [PATCH 8/8] gfs2: use lockref_init for qd_lockref

2025-01-15 Thread Andreas Gruenbacher
On Wed, Jan 15, 2025 at 10:56 AM Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > fs/gfs2/quota.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c > index 72b48f6f5561..58bc5013ca49 100644 > --- a/fs/gfs2/quota.c > ++

[PATCH 8/8] gfs2: use lockref_init for qd_lockref

2025-01-15 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/gfs2/quota.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 72b48f6f5561..58bc5013ca49 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -236,8 +236,7 @@ static struct gfs2_quota_data *qd_al