Re: [PATCH] erofs: add error log in erofs_fc_parse_param

2025-01-18 Thread Gao Xiang
On 2025/1/18 09:25, Ian Kent wrote: On 18/1/25 08:45, Ian Kent wrote: On 17/1/25 16:52, Chen Linxuan wrote: While reading erofs code, I notice that `erofs_fc_parse_param` will return -ENOPARAM, which means that erofs do not support this option, without report anything when `fs_parse` return

Re: [PATCH] erofs: add error log in erofs_fc_parse_param

2025-01-17 Thread Ian Kent
On 18/1/25 08:45, Ian Kent wrote: On 17/1/25 16:52, Chen Linxuan wrote: While reading erofs code, I notice that `erofs_fc_parse_param` will return -ENOPARAM, which means that erofs do not support this option, without report anything when `fs_parse` return an unknown `opt`. But if an option is u

Re: [PATCH] erofs: add error log in erofs_fc_parse_param

2025-01-17 Thread Ian Kent
On 17/1/25 16:52, Chen Linxuan wrote: While reading erofs code, I notice that `erofs_fc_parse_param` will return -ENOPARAM, which means that erofs do not support this option, without report anything when `fs_parse` return an unknown `opt`. But if an option is unknown to erofs, I mean that option

Re: [PATCH] erofs: add error log in erofs_fc_parse_param

2025-01-17 Thread Gao Xiang
On 2025/1/17 18:00, Chen Linxuan wrote: On Fri, 2025-01-17 at 17:54 +0800, Gao Xiang wrote: On 2025/1/17 17:50, Chen Linxuan wrote: On Fri, 2025-01-17 at 17:28 +0800, Gao Xiang wrote: Hi Linxuan, On 2025/1/17 16:52, Chen Linxuan wrote: While reading erofs code, I notice that `erofs_fc_pa

Re: [PATCH] erofs: add error log in erofs_fc_parse_param

2025-01-17 Thread Chen Linxuan
On Fri, 2025-01-17 at 17:54 +0800, Gao Xiang wrote: > > On 2025/1/17 17:50, Chen Linxuan wrote: > > On Fri, 2025-01-17 at 17:28 +0800, Gao Xiang wrote: > > > Hi Linxuan, > > > > > > On 2025/1/17 16:52, Chen Linxuan wrote: > > > > While reading erofs code, I notice that `erofs_fc_parse_param` will

Re: [PATCH] erofs: add error log in erofs_fc_parse_param

2025-01-17 Thread Chen Linxuan
On Fri, 2025-01-17 at 17:54 +0800, Gao Xiang wrote: > > On 2025/1/17 17:50, Chen Linxuan wrote: > > On Fri, 2025-01-17 at 17:28 +0800, Gao Xiang wrote: > > > Hi Linxuan, > > > > > > On 2025/1/17 16:52, Chen Linxuan wrote: > > > > While reading erofs code, I notice that `erofs_fc_parse_param` will

Re: [PATCH] erofs: add error log in erofs_fc_parse_param

2025-01-17 Thread Gao Xiang
On 2025/1/17 17:50, Chen Linxuan wrote: On Fri, 2025-01-17 at 17:28 +0800, Gao Xiang wrote: Hi Linxuan, On 2025/1/17 16:52, Chen Linxuan wrote: While reading erofs code, I notice that `erofs_fc_parse_param` will return -ENOPARAM, which means that erofs do not support this option, without re

Re: [PATCH] erofs: add error log in erofs_fc_parse_param

2025-01-17 Thread Chen Linxuan
On Fri, 2025-01-17 at 17:28 +0800, Gao Xiang wrote: > Hi Linxuan, > > On 2025/1/17 16:52, Chen Linxuan wrote: > > While reading erofs code, I notice that `erofs_fc_parse_param` will > > return -ENOPARAM, which means that erofs do not support this option, > > without report anything when `fs_parse`

Re: [PATCH] erofs: add error log in erofs_fc_parse_param

2025-01-17 Thread Gao Xiang
Hi Linxuan, On 2025/1/17 16:52, Chen Linxuan wrote: While reading erofs code, I notice that `erofs_fc_parse_param` will return -ENOPARAM, which means that erofs do not support this option, without report anything when `fs_parse` return an unknown `opt`. But if an option is unknown to erofs, I m

[PATCH] erofs: add error log in erofs_fc_parse_param

2025-01-17 Thread Chen Linxuan
While reading erofs code, I notice that `erofs_fc_parse_param` will return -ENOPARAM, which means that erofs do not support this option, without report anything when `fs_parse` return an unknown `opt`. But if an option is unknown to erofs, I mean that option not in `erofs_fs_parameters` at all, `f