Re: [PATCH] fs: erofs: Do NULL check before dereferencing pointer

2025-07-11 Thread Tom Rini
On Fri, 04 Jul 2025 11:53:18 +0100, Andrew Goodbody wrote: > The assignments to sect and off use the pointer from ctxt.cur_dev but > that has not been NULL checked before this is done. So instead move the > assignments after the NULL check. > > This issue found by Smatch > > > [...] Applied to

Re: Security vulnerabilities report to Das-U-Boot

2025-02-25 Thread Tom Rini
t; > > - CVE-2025-26722: buffer overflow in SquashFS symlink resolution > > > - CVE-2025-26723: buffer overflow in EXT4 symlink resolution > > > - CVE-2025-26724: buffer overflow in CramFS symlink resolution > > > - CVE-2025-26724: buffer overflow in JFFS2 dirent p

Re: [PATCH v2] fs/erofs: fix an integer overflow in symlink resolution

2025-02-18 Thread Tom Rini
r repository for SquashFS (being > rolled out right now). > It'd be best to solve ASAP as people might realize the similarities > between GRUB2 and U-boot in that module. Adding back in the squashfs maintainers. > > Best regards, > Jonathan > > On Tue, Feb 18

Re: [PATCH v2] fs/erofs: fix an integer overflow in symlink resolution

2025-02-18 Thread Tom Rini
On Thu, 13 Feb 2025 19:28:47 +0800, Gao Xiang wrote: > See the original report [1], otherwise len + 1 will be overflowed. > > Note that EROFS archive can record arbitary symlink sizes in principle, > so we don't assume a short number like 4096. > > [1] https://lore.kernel.org/r/20250210164151.GN

Re: [PATCH v2 0/6] test: A few quality-of-life improvements

2025-02-17 Thread Tom Rini
On Sun, Feb 09, 2025 at 09:07:13AM -0700, Simon Glass wrote: > This little series includes a few patches to make it easier to work with > the Python tests, by shortening identifiers and renaming the 'console' > fixture to reflect its role as the top-level fixture. > > It also adds a command to fi

Re: Security vulnerabilities report to Das-U-Boot

2025-02-11 Thread Tom Rini
saw Gao Xiang's response for erofs, and I'm hoping one of the squashfs maintainers will chime in. > > Best regards, > Jonathan > > On Mon, Feb 10, 2025 at 7:51 PM Gao Xiang wrote: > > > > Hi Tom, > > > > On 2025/2/11 00:41, Tom Rini wro

Re: Security vulnerabilities report to Das-U-Boot

2025-02-10 Thread Tom Rini
ashfs maintainers.. > > Best regards, > Jonathan > > On Fri, Feb 7, 2025 at 7:50 AM Tom Rini wrote: > > > On Thu, Feb 06, 2025 at 07:47:54PM -0800, Jonathan Bar Or wrote: > > > > > Dear U-boot maintainers, > > > > > > What is the best way of re

Re: [PATCH 1/4] test/py: Shorten u_boot_console

2025-01-25 Thread Tom Rini
On Sat, Jan 25, 2025 at 03:42:00PM -0700, Simon Glass wrote: > Hi Tom, > > On Sat, 25 Jan 2025 at 14:51, Tom Rini wrote: > > > > On Sat, Jan 25, 2025 at 02:31:36PM -0700, Simon Glass wrote: > > > > > This fixture name is quite long and results in lots of v

Re: [PATCH 1/4] test/py: Shorten u_boot_console

2025-01-25 Thread Tom Rini
On Sat, Jan 25, 2025 at 02:31:36PM -0700, Simon Glass wrote: > This fixture name is quite long and results in lots of verbose code. > We know this is U-Boot so the 'u_boot_' part is not necessary. > > But it is also a bit of a misnomer, since it provides access to all the > information available

Re: [PATCH] fs/erofs: fix an overflow issue of unmapped extents

2024-06-18 Thread Tom Rini
On Wed, 05 Jun 2024 14:05:54 +, Jianan Huang wrote: > Here the size should be `length - skip`, otherwise it could cause > the destination buffer overflow. > > Applied to u-boot/next, thanks! -- Tom

Re: [PATCH] fs/erofs: add DEFLATE algorithm support

2024-04-18 Thread Tom Rini
On Sun, 14 Apr 2024 23:04:14 +0800, Jianan Huang wrote: > This patch adds DEFLATE compression algorithm support. It's a good choice > to trade off between compression ratios and performance compared to LZ4. > Alternatively, DEFLATE could be used for some specific files since EROFS > supports multi

Re: [PATCH 00/24] bootstd: Support ChromiumOS better

2023-08-24 Thread Tom Rini
On Sun, Aug 13, 2023 at 08:26:28AM -0600, Simon Glass wrote: > This updates the ChromiumOS bootmeth to detect multiple kernel partitions > on a disk. > > It also includes minor code improvements to the partition drivers, > including accessors for the optional fields. > > This series also include

Re: [PATCH v3 0/8] U-boot: fs: add generic unaligned read offset handling

2022-08-26 Thread Tom Rini
On Mon, Aug 15, 2022 at 07:45:11PM +0800, Qu Wenruo wrote: > [CHANGELOG] > v3: > - Fix an error that we always return 0 actread bytes for unsupported fses > For unsupported fses, we should also populate @total_read. > Or we will just read the data but still return 0 for actually bytes. > >

Re: [PATCH v2 1/8] fs: fat: unexport file_fat_read_at()

2022-08-05 Thread Tom Rini
On Sat, Aug 06, 2022 at 06:44:38AM +0800, Qu Wenruo wrote: > > > On 2022/8/6 05:14, Tom Rini wrote: > > On Tue, Jul 26, 2022 at 01:22:09PM +0800, Qu Wenruo wrote: > > > > > That function is only utilized inside fat driver, unexport it. > &g

Re: [PATCH v2 1/8] fs: fat: unexport file_fat_read_at()

2022-08-05 Thread Tom Rini
On Tue, Jul 26, 2022 at 01:22:09PM +0800, Qu Wenruo wrote: > That function is only utilized inside fat driver, unexport it. > > Signed-off-by: Qu Wenruo Unfortunately, the series fails CI: https://source.denx.de/u-boot/u-boot/-/jobs/478838 -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/8] fs: fat: unexport file_fat_read_at()

2022-07-25 Thread Tom Rini
On Tue, Jul 26, 2022 at 09:35:51AM +0800, Qu Wenruo wrote: > > > On 2022/7/26 06:28, Tom Rini wrote: > > On Wed, Jun 29, 2022 at 07:38:22PM +0800, Qu Wenruo wrote: > > > > > That function is only utilized inside fat driver, unexport it. > > > > > &g

Re: [PATCH 1/8] fs: fat: unexport file_fat_read_at()

2022-07-25 Thread Tom Rini
On Wed, Jun 29, 2022 at 07:38:22PM +0800, Qu Wenruo wrote: > That function is only utilized inside fat driver, unexport it. > > Signed-off-by: Qu Wenruo The series has a fails to build on nokia_rx51: https://source.denx.de/u-boot/u-boot/-/jobs/471877#L483 which to me says doing 64bit division (

Re: [PATCH 0/8] u-boot: fs: add generic unaligned read handling

2022-06-29 Thread Tom Rini
On Wed, Jun 29, 2022 at 09:40:58AM +0800, Qu Wenruo wrote: > > > On 2022/6/28 22:17, Tom Rini wrote: > > On Tue, Jun 28, 2022 at 03:28:00PM +0800, Qu Wenruo wrote: > > > [BACKGROUND] > > > Unlike FUSE/Kernel which always pass aligned read range, U-boot fs code

Re: [PATCH 0/8] u-boot: fs: add generic unaligned read handling

2022-06-28 Thread Tom Rini
On Tue, Jun 28, 2022 at 03:28:00PM +0800, Qu Wenruo wrote: > [BACKGROUND] > Unlike FUSE/Kernel which always pass aligned read range, U-boot fs code > just pass the request range to underlying fses. > > Under most case, this works fine, as U-boot only really needs to read > the whole file (aka, 0 f

Re: [PATCH v4 5/5] test/py: Add tests for the erofs

2022-03-16 Thread Tom Rini
On Sat, Feb 26, 2022 at 03:05:51PM +0800, Huang Jianan wrote: > Add Python scripts to test 'ls' and 'load' commands, as well as > test related filesystem functions. > > Signed-off-by: Huang Jianan Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 4/5] fs/erofs: add filesystem commands

2022-03-16 Thread Tom Rini
On Sat, Feb 26, 2022 at 03:05:50PM +0800, Huang Jianan wrote: > Add 'ls' and 'load' commands. > > Signed-off-by: Huang Jianan Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 3/5] fs/erofs: add lz4 decompression support

2022-03-16 Thread Tom Rini
On Sat, Feb 26, 2022 at 03:05:49PM +0800, Huang Jianan wrote: > Support EROFS lz4 compressed files. > > Signed-off-by: Huang Jianan Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 2/5] lib/lz4: update LZ4 decompressor module

2022-03-16 Thread Tom Rini
On Sat, Feb 26, 2022 at 03:05:48PM +0800, Huang Jianan wrote: > Update the LZ4 compression module based on LZ4 v1.8.3 in order to > use the newest LZ4_decompress_safe_partial() which can now decode > exactly the nb of bytes requested. > > Signed-off-by: Huang Jianan Applied to u-boot/next, than

Re: [PATCH v4 1/5] fs/erofs: add erofs filesystem support

2022-03-16 Thread Tom Rini
On Sat, Feb 26, 2022 at 03:05:47PM +0800, Huang Jianan wrote: > This patch mainly deals with uncompressed files. > > Signed-off-by: Huang Jianan Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 0/5] fs/erofs: new filesystem

2022-03-05 Thread Tom Rini
On Sat, Mar 05, 2022 at 09:06:36PM +0800, Huang Jianan wrote: > > > 在 2022/3/4 3:15, Tom Rini 写道: > > On Thu, Mar 03, 2022 at 10:51:18PM +0800, Huang Jianan wrote: > > > > > Hi Tom, > > > > > > Would you mind taking some time to check if this v

Re: [PATCH v4 0/5] fs/erofs: new filesystem

2022-03-03 Thread Tom Rini
On Thu, Mar 03, 2022 at 10:51:18PM +0800, Huang Jianan wrote: > Hi Tom, > > Would you mind taking some time to check if this version meets > the requirements ?So we could have a chance to be merged > into the next version ? > > I have triggered a CI via Github PR based on this version : > https:

Re: [PATCH v3 0/5] fs/erofs: new filesystem

2022-02-10 Thread Tom Rini
On Thu, Feb 10, 2022 at 08:43:20PM +0800, Gao Xiang wrote: > Hi Tom, > > Would you mind taking some time having a look at this version > if it meets what's needed, so we could have a chance to be > merged in the next u-boot version? > > It's almost in sync with the latest erofs-utils soruce code

Re: [PATCH v3 5/5] test/py: Add tests for the erofs

2022-02-10 Thread Tom Rini
On Tue, Feb 08, 2022 at 10:05:13PM +0800, Huang Jianan wrote: > Add Python scripts to test 'ls' and 'load' commands, as well as > test related filesystem functions. > > Signed-off-by: Huang Jianan > --- > MAINTAINERS | 1 + > configs/sandbox_defconfig | 1 +

Re: [PATCH v2 1/3] fs/erofs: add erofs filesystem support

2021-08-30 Thread Tom Rini
On Mon, Aug 30, 2021 at 11:31:28PM +0800, Huang Jianan wrote: > 在 2021/8/30 21:27, Huang Jianan 写道: > > > > > > 在 2021/8/26 6:39, Tom Rini 写道: > > > On Mon, Aug 23, 2021 at 08:36:44PM +0800, Huang Jianan wrote: > > > > > > > From: Huang Ji

Re: [PATCH v2 0/3] fs/erofs: new filesystem

2021-08-25 Thread Tom Rini
On Mon, Aug 23, 2021 at 08:36:43PM +0800, Huang Jianan wrote: > From: Huang Jianan > > Add erofs filesystem support. > > The code is adapted from erofs-utils in order to reduce maintenance > burden and keep with the latest feature. > > Changes since v1: > - fix the inconsistency between From

Re: [PATCH v2 2/3] fs/erofs: add lz4 1.8.3 decompressor

2021-08-25 Thread Tom Rini
On Mon, Aug 23, 2021 at 08:36:45PM +0800, Huang Jianan wrote: > From: Huang Jianan > > In order to use the newest LZ4_decompress_safe_partial() which can > now decode exactly the nb of bytes requested. > > Signed-off-by: Huang Jianan > --- > fs/erofs/Makefile | 3 +- > fs/erofs/lz4.c| 5

Re: [PATCH v2 1/3] fs/erofs: add erofs filesystem support

2021-08-25 Thread Tom Rini
On Mon, Aug 23, 2021 at 08:36:44PM +0800, Huang Jianan wrote: > From: Huang Jianan > > This patch mainly deals with uncompressed files. > > Signed-off-by: Huang Jianan > --- > fs/Kconfig | 1 + > fs/Makefile | 1 + > fs/erofs/Kconfig| 12 ++ > fs/erofs/Makefile |