Re: [PATCH v10 3/3] watchdog: make the device time out at open_deadline when open_timeout is used

2019-06-15 Thread Wim Van Sebroeck
Hi Rasmus, > > On Wed, Jun 05, 2019 at 02:06:44PM +, Rasmus Villemoes wrote: > >> When the watchdog device is not open by userspace, the kernel takes > >> care of pinging it. When the open_timeout feature is in use, we should > >> ensure that the hardware fires close to open_timeout seconds af

Re: [v6,3/3] watchdog: introduce CONFIG_WATCHDOG_OPEN_TIMEOUT

2017-07-11 Thread Wim Van Sebroeck
Hi Guenter, > > This allows setting a default value for the watchdog.open_timeout > > commandline parameter via Kconfig. > > > > Some BSPs allow remote updating of the kernel image and root file > > system, but updating the bootloader requires physical access. Hence, if > > one has a firmware upd

Re: [PATCH v7 1/9] watchdog: Introduce hardware maximum timeout in watchdog core

2016-02-28 Thread Wim Van Sebroeck
Hi Guenter, Code is OK, but I still have one last remark: When I coded the generic watchdog framework, I used the following terminology: * timeout for userspace timeout's * heartbeat for the internal hardware timeout. I would like us to stick to this, so that the story keeps being clear and consi

Re: [PATCH v14 0/4] Watchdog: introduce ARM SBSA watchdog driver

2016-03-04 Thread Wim Van Sebroeck
Hi Fu, > From: Fu Wei > > This patchset: > (1)Introduce Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt > for FDT info of SBSA Generic Watchdog, and give two examples of > adding SBSA Generic Watchdog device node into the dts files: > foundation-v8.dts and amd-seattle-so

Re: [PATCH v8 0/10] watchdog: Add support for keepalives triggered by infrastructure

2016-03-06 Thread Wim Van Sebroeck
Hi Guenter, > The watchdog infrastructure is currently purely passive, meaning > it only passes information from user space to drivers and vice versa. > > Since watchdog hardware tends to have its own quirks, this can result > in quite complex watchdog drivers. A number of scanarios are especiall

Re: [PATCH v8 0/10] watchdog: Add support for keepalives triggered by infrastructure

2016-03-07 Thread Wim Van Sebroeck
Hi Guenter, > Hi Wim, > > On Sun, Mar 06, 2016 at 11:49:56AM +0100, Wim Van Sebroeck wrote: > > Hi Guenter, > > > > > The watchdog infrastructure is currently purely passive, meaning > > > it only passes information from user space to drivers and vice ver